From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, narmstrong@baylibre.com,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: power: meson-ee-pwrc: add support for Meson8/8b/8m2
Date: Mon, 20 Apr 2020 12:55:15 -0500 [thread overview]
Message-ID: <20200420175515.GA28534@bogus> (raw)
In-Reply-To: <20200417190825.1363345-2-martin.blumenstingl@googlemail.com>
On Fri, 17 Apr 2020 21:08:22 +0200, Martin Blumenstingl wrote:
> The power domains on the 32-bit Meson8/Meson8b/Meson8m2 SoCs are very
> similar to what G12A still uses. The (known) differences are:
> - Meson8 doesn't use any reset lines at all
> - Meson8b and Meson8m2 use the same reset lines, which are different
> from what the 64-bit SoCs use
> - there is no "vapb" clock on the older SoCs
> - amlogic,ao-sysctrl cannot point to the whole AO sysctrl region but
> only the power management related registers
>
> Add a new compatible string and adjust clock and reset line expectations
> for each SoC.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> .../bindings/power/amlogic,meson-ee-pwrc.yaml | 75 ++++++++++++++-----
> include/dt-bindings/power/meson8-power.h | 13 ++++
> 2 files changed, 71 insertions(+), 17 deletions(-)
> create mode 100644 include/dt-bindings/power/meson8-power.h
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.example.dt.yaml: power-controller: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+'
See https://patchwork.ozlabs.org/patch/1272441
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, narmstrong@baylibre.com,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: power: meson-ee-pwrc: add support for Meson8/8b/8m2
Date: Mon, 20 Apr 2020 12:55:15 -0500 [thread overview]
Message-ID: <20200420175515.GA28534@bogus> (raw)
In-Reply-To: <20200417190825.1363345-2-martin.blumenstingl@googlemail.com>
On Fri, 17 Apr 2020 21:08:22 +0200, Martin Blumenstingl wrote:
> The power domains on the 32-bit Meson8/Meson8b/Meson8m2 SoCs are very
> similar to what G12A still uses. The (known) differences are:
> - Meson8 doesn't use any reset lines at all
> - Meson8b and Meson8m2 use the same reset lines, which are different
> from what the 64-bit SoCs use
> - there is no "vapb" clock on the older SoCs
> - amlogic,ao-sysctrl cannot point to the whole AO sysctrl region but
> only the power management related registers
>
> Add a new compatible string and adjust clock and reset line expectations
> for each SoC.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> .../bindings/power/amlogic,meson-ee-pwrc.yaml | 75 ++++++++++++++-----
> include/dt-bindings/power/meson8-power.h | 13 ++++
> 2 files changed, 71 insertions(+), 17 deletions(-)
> create mode 100644 include/dt-bindings/power/meson8-power.h
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.example.dt.yaml: power-controller: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+'
See https://patchwork.ozlabs.org/patch/1272441
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: robh+dt@kernel.org, khilman@baylibre.com,
narmstrong@baylibre.com, linux-amlogic@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: power: meson-ee-pwrc: add support for Meson8/8b/8m2
Date: Mon, 20 Apr 2020 12:55:15 -0500 [thread overview]
Message-ID: <20200420175515.GA28534@bogus> (raw)
In-Reply-To: <20200417190825.1363345-2-martin.blumenstingl@googlemail.com>
On Fri, 17 Apr 2020 21:08:22 +0200, Martin Blumenstingl wrote:
> The power domains on the 32-bit Meson8/Meson8b/Meson8m2 SoCs are very
> similar to what G12A still uses. The (known) differences are:
> - Meson8 doesn't use any reset lines at all
> - Meson8b and Meson8m2 use the same reset lines, which are different
> from what the 64-bit SoCs use
> - there is no "vapb" clock on the older SoCs
> - amlogic,ao-sysctrl cannot point to the whole AO sysctrl region but
> only the power management related registers
>
> Add a new compatible string and adjust clock and reset line expectations
> for each SoC.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> .../bindings/power/amlogic,meson-ee-pwrc.yaml | 75 ++++++++++++++-----
> include/dt-bindings/power/meson8-power.h | 13 ++++
> 2 files changed, 71 insertions(+), 17 deletions(-)
> create mode 100644 include/dt-bindings/power/meson8-power.h
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.example.dt.yaml: power-controller: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+'
See https://patchwork.ozlabs.org/patch/1272441
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-04-20 17:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 19:08 [PATCH v2 0/4] meson-ee-pwrc: support for Meson8/8b/8m2 and GX Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` [PATCH v2 1/4] dt-bindings: power: meson-ee-pwrc: add support for Meson8/8b/8m2 Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-20 17:55 ` Rob Herring [this message]
2020-04-20 17:55 ` Rob Herring
2020-04-20 17:55 ` Rob Herring
2020-04-17 19:08 ` [PATCH v2 2/4] dt-bindings: power: meson-ee-pwrc: add support for the Meson GX SoCs Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` [PATCH v2 3/4] soc: amlogic: meson-ee-pwrc: add support for Meson8/Meson8b/Meson8m2 Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` [PATCH v2 4/4] soc: amlogic: meson-ee-pwrc: add support for the Meson GX SoCs Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
2020-04-17 19:08 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420175515.GA28534@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.