From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: Push TRANS_DDI_FUNC_CTL into the encoder->enable() hook
Date: Mon, 20 Apr 2020 21:34:41 +0300 [thread overview]
Message-ID: <20200420183441.GB6112@intel.com> (raw)
In-Reply-To: <158715309508.2062.2790073223349657193@build.alporthouse.com>
On Fri, Apr 17, 2020 at 08:51:35PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2020-04-17 14:47:19)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Push the TRANS_DDI_FUNC_CTL into the encoder enable hook. The disable
> > is already there, and as a followup will enable us to pass the encoder
> > all the way down.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> In intel_ddi_transcoder_func_reg_val_get() I found a list of ddi
> crtc types (HDMI, ANALOG, DP_MST, DP_SST). Now hdmi/dp == ddi, and so we
> are left with dp_mst and crt callbacks.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Is it possible to have more BUG_ON(!transcoder_is_ddi()) scatter around
> the entry points?
I guess we could assert something about either the output_types or the
encoder type, but not sure that would get us much. Bunch of that is
anyway the same for pre-DDI stuff.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-20 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 13:47 [Intel-gfx] [PATCH 1/4] drm/i195: Pass encoder to intel_ddi_enable_pipe_clock() Ville Syrjala
2020-04-17 13:47 ` [Intel-gfx] [PATCH 2/4] drm/i915: Move the TRANS_DDI_FUNC_CTL enable to a later point Ville Syrjala
2020-04-17 19:53 ` Chris Wilson
2020-04-20 14:45 ` Jani Nikula
2020-04-20 18:27 ` Ville Syrjälä
2020-04-17 13:47 ` [Intel-gfx] [PATCH 3/4] drm/i915: Push TRANS_DDI_FUNC_CTL into the encoder->enable() hook Ville Syrjala
2020-04-17 19:51 ` Chris Wilson
2020-04-20 18:34 ` Ville Syrjälä [this message]
2020-04-17 13:47 ` [Intel-gfx] [PATCH 4/4] drm/i915: Pass encoder all the way to intel_ddi_transcoder_func_reg_val_get() Ville Syrjala
2020-04-17 19:45 ` Chris Wilson
2020-04-17 19:29 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/4] drm/i195: Pass encoder to intel_ddi_enable_pipe_clock() Patchwork
2020-04-17 19:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-17 19:52 ` [Intel-gfx] [PATCH 1/4] " Chris Wilson
2020-04-19 6:06 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420183441.GB6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.