From: Matthias Kaehlcke <mka@chromium.org>
To: Yong Mao <yong.mao@mediatek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
srv_heupstream@mediatek.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chaotian Jing <chaotian.jing@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] mmc: core: need do mmc_power_cycle in mmc_sdio_resend_if_cond
Date: Mon, 20 Apr 2020 12:15:18 -0700 [thread overview]
Message-ID: <20200420191518.GG199755@google.com> (raw)
In-Reply-To: <1586835611-13857-2-git-send-email-yong.mao@mediatek.com>
Hi,
On Tue, Apr 14, 2020 at 11:40:09AM +0800, Yong Mao wrote:
> From: yong mao <yong.mao@mediatek.com>
>
> When mmc_sdio_resned_if_cond is invoked, it indicates the SDIO
> device is not in the right state. In this condition, the previous
> implementation of mmc_sdio_resend_if_cond can't make sure SDIO
> device be back to idle state. mmc_power_cycle can reset the SDIO
> device by HW and also make sure SDIO device enter to idle state
> correctly.
>
> Signed-off-by: Yong Mao <yong.mao@mediatek.com>
> ---
> drivers/mmc/core/sdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index ebb387a..ada0a80 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -546,6 +546,7 @@ static int mmc_sdio_init_uhs_card(struct mmc_card *card)
> static void mmc_sdio_resend_if_cond(struct mmc_host *host,
> struct mmc_card *card)
> {
> + mmc_power_cycle(host, host->card->ocr);
My MMC/SDIO background is limited, but it seems this isn't needed for the
vast majority of SDIO devices, otherwise it probably would have been added
earlier. I wonder if it would make sense to make the power cycle
conditional through a quirk, to limit it to the devices that need it.
> sdio_reset(host);
> mmc_go_idle(host);
> mmc_send_if_cond(host, host->ocr_avail);
> --
> 1.9.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Yong Mao <yong.mao@mediatek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com
Subject: Re: [PATCH 1/3] mmc: core: need do mmc_power_cycle in mmc_sdio_resend_if_cond
Date: Mon, 20 Apr 2020 12:15:18 -0700 [thread overview]
Message-ID: <20200420191518.GG199755@google.com> (raw)
In-Reply-To: <1586835611-13857-2-git-send-email-yong.mao@mediatek.com>
Hi,
On Tue, Apr 14, 2020 at 11:40:09AM +0800, Yong Mao wrote:
> From: yong mao <yong.mao@mediatek.com>
>
> When mmc_sdio_resned_if_cond is invoked, it indicates the SDIO
> device is not in the right state. In this condition, the previous
> implementation of mmc_sdio_resend_if_cond can't make sure SDIO
> device be back to idle state. mmc_power_cycle can reset the SDIO
> device by HW and also make sure SDIO device enter to idle state
> correctly.
>
> Signed-off-by: Yong Mao <yong.mao@mediatek.com>
> ---
> drivers/mmc/core/sdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index ebb387a..ada0a80 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -546,6 +546,7 @@ static int mmc_sdio_init_uhs_card(struct mmc_card *card)
> static void mmc_sdio_resend_if_cond(struct mmc_host *host,
> struct mmc_card *card)
> {
> + mmc_power_cycle(host, host->card->ocr);
My MMC/SDIO background is limited, but it seems this isn't needed for the
vast majority of SDIO devices, otherwise it probably would have been added
earlier. I wonder if it would make sense to make the power cycle
conditional through a quirk, to limit it to the devices that need it.
> sdio_reset(host);
> mmc_go_idle(host);
> mmc_send_if_cond(host, host->ocr_avail);
> --
> 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Yong Mao <yong.mao@mediatek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
srv_heupstream@mediatek.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chaotian Jing <chaotian.jing@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] mmc: core: need do mmc_power_cycle in mmc_sdio_resend_if_cond
Date: Mon, 20 Apr 2020 12:15:18 -0700 [thread overview]
Message-ID: <20200420191518.GG199755@google.com> (raw)
In-Reply-To: <1586835611-13857-2-git-send-email-yong.mao@mediatek.com>
Hi,
On Tue, Apr 14, 2020 at 11:40:09AM +0800, Yong Mao wrote:
> From: yong mao <yong.mao@mediatek.com>
>
> When mmc_sdio_resned_if_cond is invoked, it indicates the SDIO
> device is not in the right state. In this condition, the previous
> implementation of mmc_sdio_resend_if_cond can't make sure SDIO
> device be back to idle state. mmc_power_cycle can reset the SDIO
> device by HW and also make sure SDIO device enter to idle state
> correctly.
>
> Signed-off-by: Yong Mao <yong.mao@mediatek.com>
> ---
> drivers/mmc/core/sdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index ebb387a..ada0a80 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -546,6 +546,7 @@ static int mmc_sdio_init_uhs_card(struct mmc_card *card)
> static void mmc_sdio_resend_if_cond(struct mmc_host *host,
> struct mmc_card *card)
> {
> + mmc_power_cycle(host, host->card->ocr);
My MMC/SDIO background is limited, but it seems this isn't needed for the
vast majority of SDIO devices, otherwise it probably would have been added
earlier. I wonder if it would make sense to make the power cycle
conditional through a quirk, to limit it to the devices that need it.
> sdio_reset(host);
> mmc_go_idle(host);
> mmc_send_if_cond(host, host->ocr_avail);
> --
> 1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-20 19:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 3:40 Fix sdio reinit card fail issue Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-14 3:40 ` [PATCH 1/3] mmc: core: need do mmc_power_cycle in mmc_sdio_resend_if_cond Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-20 19:15 ` Matthias Kaehlcke [this message]
2020-04-20 19:15 ` Matthias Kaehlcke
2020-04-20 19:15 ` Matthias Kaehlcke
2020-04-21 7:03 ` yong.mao
2020-04-21 7:03 ` yong.mao
2020-04-21 7:03 ` yong.mao
2020-04-24 10:09 ` Ulf Hansson
2020-04-24 10:09 ` Ulf Hansson
2020-04-24 10:09 ` Ulf Hansson
2020-04-28 9:27 ` yong.mao
2020-04-28 9:27 ` yong.mao
2020-04-28 9:27 ` yong.mao
2020-04-28 12:13 ` Ulf Hansson
2020-04-28 12:13 ` Ulf Hansson
2020-04-28 12:13 ` Ulf Hansson
2020-04-29 8:20 ` yong.mao
2020-04-29 8:20 ` yong.mao
2020-04-29 8:20 ` yong.mao
2020-05-05 13:13 ` Ulf Hansson
2020-05-05 13:13 ` Ulf Hansson
2020-05-05 13:13 ` Ulf Hansson
2020-04-14 3:40 ` [PATCH 2/3] mmc: core: rocr verification Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-14 3:40 ` [PATCH 3/3] mmc: core: fix mmc_sdio_reinit_card fail issue Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-14 3:40 ` Yong Mao
2020-04-22 22:46 ` Matthias Kaehlcke
2020-04-22 22:46 ` Matthias Kaehlcke
2020-04-22 22:46 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420191518.GG199755@google.com \
--to=mka@chromium.org \
--cc=chaotian.jing@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=yong.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.