Re: [PATCH] of_device: removed #include that caused a recursion in included headers

From: Rob Herring <robh@kernel.org>
To: Hadar Gat <hadar.gat@arm.com>
Cc: "Jose Abreu" <joabreu@synopsys.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"David Airlie" <airlied@linux.ie>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	dri-devel@lists.freedesktop.org,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	linux-mtd@lists.infradead.org,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	netdev@vger.kernel.org, "Kishon Vijay Abraham I" <kishon@ti.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-samsung-soc@vger.kernel.org,
	"Frank Rowand" <frowand.list@gmail.com>,
	linux-rockchip@lists.infradead.org,
	"Richard Weinberger" <richard@nod.at>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	"Andy Gross" <agross@kernel.org>,
	devicetree@vger.kernel.org,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	"Maxime Ripard" <mripard@kernel.org>,
	"Gilad Ben-Yossef" <gilad@benyossef.com>,
	iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org,
	"Daniel Vetter" <daniel@ffwll.ch>, "Chen-Yu Tsai" <wens@csie.org>,
	"Sean Paul" <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	"Ofir Drang" <ofir.drang@arm.com>,
	linux-gpio@vger.kernel.org, "JC Kuo" <jckuo@nvidia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Sudeep Holla" <sudeep.holla@arm.com>,
	dmaengine@vger.kernel.org, freedreno@lists.freedesktop.org,
	"David S. Miller" <davem@davemloft.net>,
	"Jonathan Cameron" <jic23@kernel.org>
Subject: Re: [PATCH] of_device: removed #include that caused a recursion in included headers
Date: Mon, 20 Apr 2020 15:36:47 -0500	[thread overview]
Message-ID: <20200420203647.GA23189@bogus> (raw)
In-Reply-To: <1586784960-22692-1-git-send-email-hadar.gat@arm.com>

On Mon, Apr 13, 2020 at 04:35:53PM +0300, Hadar Gat wrote:
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.

Guess we forgot about that temporary comment!

Both of these headers have a lot of things we don't want 'normal' 
drivers calling. The most common thing needed from of_device.h is 
of_match_device/of_device_get_match_data. A good number are only for 
ibmebus. Maybe the header should be split or the former just moved 
to of.h.

For of_platform.h, it seems we have a bunch of unneeded includes:

$ git grep 'of_platform\.h' drivers/ | wc
    560    1120   36049
$ git grep -E 'of_(platform_(pop|def)|find_device)' drivers/ | wc
    248    1215   20630

Would nice to drop those (or switch to of_device.h?) too.

Be sure to build on Sparc. It's the oddball.

> 
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> ---
>  drivers/base/platform.c                           | 1 +
>  drivers/bus/vexpress-config.c                     | 1 +
>  drivers/dma/at_hdmac.c                            | 1 +
>  drivers/dma/stm32-dmamux.c                        | 1 +
>  drivers/dma/ti/dma-crossbar.c                     | 1 +
>  drivers/gpu/drm/msm/adreno/a6xx_gmu.c             | 1 +
>  drivers/gpu/drm/msm/hdmi/hdmi.c                   | 1 +
>  drivers/gpu/drm/msm/msm_drv.c                     | 1 +
>  drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c   | 1 +
>  drivers/gpu/drm/sun4i/sun4i_tcon.c                | 1 +
>  drivers/iio/adc/stm32-adc-core.c                  | 1 +
>  drivers/iio/adc/stm32-dfsdm-adc.c                 | 1 +
>  drivers/iio/adc/stm32-dfsdm-core.c                | 1 +
>  drivers/iommu/tegra-smmu.c                        | 1 +
>  drivers/memory/atmel-ebi.c                        | 1 +
>  drivers/mfd/palmas.c                              | 1 +
>  drivers/mfd/ssbi.c                                | 1 +
>  drivers/mtd/nand/raw/omap2.c                      | 1 +
>  drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
>  drivers/net/ethernet/ti/cpsw.c                    | 1 +
>  drivers/phy/tegra/xusb.c                          | 1 +
>  drivers/pinctrl/nomadik/pinctrl-nomadik.c         | 1 +
>  drivers/soc/samsung/exynos-pmu.c                  | 1 +
>  drivers/soc/sunxi/sunxi_sram.c                    | 1 +
>  include/linux/of_device.h                         | 2 --
>  lib/genalloc.c                                    | 1 +
>  26 files changed, 25 insertions(+), 2 deletions(-)
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu