From: Shawn Guo <shawnguo@kernel.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Clemens Gruber <clemens.gruber@pqgruber.com>,
Rouven Czerwinski <r.czerwinski@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Russell King <linux@armlinux.org.uk>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH] ARM: imx: provide v7_cpu_resume() only on ARM_CPU_SUSPEND=y
Date: Tue, 21 Apr 2020 11:21:17 +0800 [thread overview]
Message-ID: <20200421032116.GD8571@dragon> (raw)
In-Reply-To: <20200323081933.31497-1-a.fatoum@pengutronix.de>
On Mon, Mar 23, 2020 at 09:19:33AM +0100, Ahmad Fatoum wrote:
> 512a928affd5 ("ARM: imx: build v7_cpu_resume() unconditionally")
> introduced an unintended linker error for i.MX6 configurations that have
> ARM_CPU_SUSPEND=n which can happen if neither CONFIG_PM, CONFIG_CPU_IDLE,
> nor ARM_PSCI_FW are selected.
>
> Fix this by having v7_cpu_resume() compiled only when cpu_resume() it
> calls is available as well.
>
> The C declaration for the function remains unguarded to avoid future code
> inadvertently using a stub and introducing a regression to the bug the
> original commit fixed.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 512a928affd5 ("ARM: imx: build v7_cpu_resume() unconditionally")
> Reported-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Rouven Czerwinski <r.czerwinski@pengutronix.de>,
stable@vger.kernel.org,
Clemens Gruber <clemens.gruber@pqgruber.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: imx: provide v7_cpu_resume() only on ARM_CPU_SUSPEND=y
Date: Tue, 21 Apr 2020 11:21:17 +0800 [thread overview]
Message-ID: <20200421032116.GD8571@dragon> (raw)
In-Reply-To: <20200323081933.31497-1-a.fatoum@pengutronix.de>
On Mon, Mar 23, 2020 at 09:19:33AM +0100, Ahmad Fatoum wrote:
> 512a928affd5 ("ARM: imx: build v7_cpu_resume() unconditionally")
> introduced an unintended linker error for i.MX6 configurations that have
> ARM_CPU_SUSPEND=n which can happen if neither CONFIG_PM, CONFIG_CPU_IDLE,
> nor ARM_PSCI_FW are selected.
>
> Fix this by having v7_cpu_resume() compiled only when cpu_resume() it
> calls is available as well.
>
> The C declaration for the function remains unguarded to avoid future code
> inadvertently using a stub and introducing a regression to the bug the
> original commit fixed.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 512a928affd5 ("ARM: imx: build v7_cpu_resume() unconditionally")
> Reported-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied, thanks.
next prev parent reply other threads:[~2020-04-21 3:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 8:19 [PATCH] ARM: imx: provide v7_cpu_resume() only on ARM_CPU_SUSPEND=y Ahmad Fatoum
2020-03-23 8:19 ` Ahmad Fatoum
2020-03-23 8:25 ` Ahmad Fatoum
2020-03-23 8:25 ` Ahmad Fatoum
2020-03-27 11:21 ` Ahmad Fatoum
2020-03-27 11:21 ` Ahmad Fatoum
2020-04-13 10:19 ` Roland Hieber
2020-04-13 10:19 ` Roland Hieber
2020-04-21 3:21 ` Shawn Guo [this message]
2020-04-21 3:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421032116.GD8571@dragon \
--to=shawnguo@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=clemens.gruber@pqgruber.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=r.czerwinski@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.