* [linux-next:master 2227/3715] drivers/staging/wfx/sta.c:155 wfx_filter_mcast() warn: ignoring unreachable code.
@ 2020-04-21 17:33 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-04-21 17:33 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2793 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 39a314cd1168cbcb05ebcd973098c8f1440a3064
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/staging/wfx/sta.c:155 wfx_filter_mcast() warn: ignoring unreachable code.
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c801351a9d4587aab131d018330d4b35a0b3cdcf
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout c801351a9d4587aab131d018330d4b35a0b3cdcf
vim +155 drivers/staging/wfx/sta.c
c801351a9d4587 Jérôme Pouiller 2020-04-15 147 static void wfx_filter_mcast(struct wfx_vif *wvif, bool filter_mcast)
2c69b2da378243 Jérôme Pouiller 2020-04-15 148 {
2c69b2da378243 Jérôme Pouiller 2020-04-15 149 int i;
40115bbc40e2fd Jérôme Pouiller 2019-09-19 150
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 151 // Temporary workaround for filters
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 152 hif_set_data_filtering(wvif, false, true);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 153 return;
^^^^^^^
Temporary code creates a temporary static checker warning from the
zero day kbuild bot.
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 154
c801351a9d4587 Jérôme Pouiller 2020-04-15 @155 if (!filter_mcast) {
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 156 hif_set_data_filtering(wvif, false, true);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 157 return;
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 158 }
981132aa039d90 Jérôme Pouiller 2020-04-15 159 for (i = 0; i < wvif->filter_mcast_count; i++)
981132aa039d90 Jérôme Pouiller 2020-04-15 160 hif_set_mac_addr_condition(wvif, i, wvif->filter_mcast_addr[i]);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 161 hif_set_uc_mc_bc_condition(wvif, 0,
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 162 HIF_FILTER_UNICAST | HIF_FILTER_BROADCAST);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 163 hif_set_config_data_filter(wvif, true, 0, BIT(1),
981132aa039d90 Jérôme Pouiller 2020-04-15 164 BIT(wvif->filter_mcast_count) - 1);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 165 hif_set_data_filtering(wvif, true, true);
40115bbc40e2fd Jérôme Pouiller 2019-09-19 166 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread* [kbuild] [linux-next:master 2227/3715] drivers/staging/wfx/sta.c:155 wfx_filter_mcast() warn: ignoring unreachable code.
@ 2020-04-21 17:33 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-04-21 17:33 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2793 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 39a314cd1168cbcb05ebcd973098c8f1440a3064
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/staging/wfx/sta.c:155 wfx_filter_mcast() warn: ignoring unreachable code.
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c801351a9d4587aab131d018330d4b35a0b3cdcf
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout c801351a9d4587aab131d018330d4b35a0b3cdcf
vim +155 drivers/staging/wfx/sta.c
c801351a9d4587 Jérôme Pouiller 2020-04-15 147 static void wfx_filter_mcast(struct wfx_vif *wvif, bool filter_mcast)
2c69b2da378243 Jérôme Pouiller 2020-04-15 148 {
2c69b2da378243 Jérôme Pouiller 2020-04-15 149 int i;
40115bbc40e2fd Jérôme Pouiller 2019-09-19 150
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 151 // Temporary workaround for filters
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 152 hif_set_data_filtering(wvif, false, true);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 153 return;
^^^^^^^
Temporary code creates a temporary static checker warning from the
zero day kbuild bot.
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 154
c801351a9d4587 Jérôme Pouiller 2020-04-15 @155 if (!filter_mcast) {
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 156 hif_set_data_filtering(wvif, false, true);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 157 return;
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 158 }
981132aa039d90 Jérôme Pouiller 2020-04-15 159 for (i = 0; i < wvif->filter_mcast_count; i++)
981132aa039d90 Jérôme Pouiller 2020-04-15 160 hif_set_mac_addr_condition(wvif, i, wvif->filter_mcast_addr[i]);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 161 hif_set_uc_mc_bc_condition(wvif, 0,
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 162 HIF_FILTER_UNICAST | HIF_FILTER_BROADCAST);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 163 hif_set_config_data_filter(wvif, true, 0, BIT(1),
981132aa039d90 Jérôme Pouiller 2020-04-15 164 BIT(wvif->filter_mcast_count) - 1);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 165 hif_set_data_filtering(wvif, true, true);
40115bbc40e2fd Jérôme Pouiller 2019-09-19 166 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [linux-next:master 2227/3715] drivers/staging/wfx/sta.c:155 wfx_filter_mcast() warn: ignoring unreachable code.
@ 2020-04-21 16:35 kbuild test robot
0 siblings, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2020-04-21 16:35 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2906 bytes --]
CC: kbuild-all(a)lists.01.org
TO: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 39a314cd1168cbcb05ebcd973098c8f1440a3064
commit: c801351a9d4587aab131d018330d4b35a0b3cdcf [2227/3715] staging: wfx: drop useless attribute 'filter_mcast'
:::::: branch date: 10 hours ago
:::::: commit date: 5 days ago
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/staging/wfx/sta.c:155 wfx_filter_mcast() warn: ignoring unreachable code.
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c801351a9d4587aab131d018330d4b35a0b3cdcf
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout c801351a9d4587aab131d018330d4b35a0b3cdcf
vim +155 drivers/staging/wfx/sta.c
2c69b2da378243 Jérôme Pouiller 2020-04-15 146
c801351a9d4587 Jérôme Pouiller 2020-04-15 147 static void wfx_filter_mcast(struct wfx_vif *wvif, bool filter_mcast)
2c69b2da378243 Jérôme Pouiller 2020-04-15 148 {
2c69b2da378243 Jérôme Pouiller 2020-04-15 149 int i;
40115bbc40e2fd Jérôme Pouiller 2019-09-19 150
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 151 // Temporary workaround for filters
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 152 hif_set_data_filtering(wvif, false, true);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 153 return;
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 154
c801351a9d4587 Jérôme Pouiller 2020-04-15 @155 if (!filter_mcast) {
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 156 hif_set_data_filtering(wvif, false, true);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 157 return;
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 158 }
981132aa039d90 Jérôme Pouiller 2020-04-15 159 for (i = 0; i < wvif->filter_mcast_count; i++)
981132aa039d90 Jérôme Pouiller 2020-04-15 160 hif_set_mac_addr_condition(wvif, i, wvif->filter_mcast_addr[i]);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 161 hif_set_uc_mc_bc_condition(wvif, 0,
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 162 HIF_FILTER_UNICAST | HIF_FILTER_BROADCAST);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 163 hif_set_config_data_filter(wvif, true, 0, BIT(1),
981132aa039d90 Jérôme Pouiller 2020-04-15 164 BIT(wvif->filter_mcast_count) - 1);
e86bc725ba5f96 Jérôme Pouiller 2020-04-15 165 hif_set_data_filtering(wvif, true, true);
40115bbc40e2fd Jérôme Pouiller 2019-09-19 166 }
40115bbc40e2fd Jérôme Pouiller 2019-09-19 167
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-21 17:33 [linux-next:master 2227/3715] drivers/staging/wfx/sta.c:155 wfx_filter_mcast() warn: ignoring unreachable code Dan Carpenter
2020-04-21 17:33 ` [kbuild] " Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-04-21 16:35 kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.