All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] media: uvcvideo: read bulk URBs after maxPayloadSize
Date: Wed, 22 Apr 2020 12:50:27 +0800	[thread overview]
Message-ID: <202004221200.v4lagkkr%lkp@intel.com> (raw)
In-Reply-To: <20200420024119.380416-1-julianmeyer2000@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2596 bytes --]

Hi Julian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.7-rc2 next-20200421]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Julian-Meyer/media-uvcvideo-read-bulk-URBs-after-maxPayloadSize/20200421-225554
base:   git://linuxtv.org/media_tree.git master
config: arm64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a9b137f9ffba8cb25dfd7dd1fb613e8aac121b37)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/usb/uvc/uvc_video.c:1484:3: error: expected expression
                   }
                   ^
   1 error generated.

vim +1484 drivers/media/usb/uvc/uvc_video.c

  1457	
  1458	static void uvc_video_decode_bulk(struct uvc_urb *uvc_urb,
  1459				struct uvc_buffer *buf, struct uvc_buffer *meta_buf)
  1460	{
  1461		struct urb *urb = uvc_urb->urb;
  1462		struct uvc_streaming *stream = uvc_urb->stream;
  1463		u8 *mem;
  1464		int len;
  1465		int len_processed;
  1466	
  1467		/*
  1468		 * Ignore ZLPs if they're not part of a frame, otherwise process them
  1469		 * to trigger the end of payload detection.
  1470		 */
  1471		if (urb->actual_length == 0 && stream->bulk.header_size == 0)
  1472			return;
  1473	
  1474		mem = urb->transfer_buffer;
  1475		len = urb->actual_length;
  1476	
  1477		while (len > 0) {
  1478			len_processed = uvc_video_decode_bulk_single(stream, buf,
  1479				meta_buf, uvc_urb, &mem, &len);
  1480	
  1481			// if we don't process anything, we break out of the decode loop
  1482			if (len_processed == 0) {
  1483				return
> 1484			}
  1485		}
  1486	}
  1487	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 49087 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Julian Meyer <julianmeyer2000@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-media@vger.kernel.org,
	Julian Meyer <julianmeyer2000@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v2] media: uvcvideo: read bulk URBs after maxPayloadSize
Date: Wed, 22 Apr 2020 12:50:27 +0800	[thread overview]
Message-ID: <202004221200.v4lagkkr%lkp@intel.com> (raw)
In-Reply-To: <20200420024119.380416-1-julianmeyer2000@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2525 bytes --]

Hi Julian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.7-rc2 next-20200421]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Julian-Meyer/media-uvcvideo-read-bulk-URBs-after-maxPayloadSize/20200421-225554
base:   git://linuxtv.org/media_tree.git master
config: arm64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a9b137f9ffba8cb25dfd7dd1fb613e8aac121b37)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/usb/uvc/uvc_video.c:1484:3: error: expected expression
                   }
                   ^
   1 error generated.

vim +1484 drivers/media/usb/uvc/uvc_video.c

  1457	
  1458	static void uvc_video_decode_bulk(struct uvc_urb *uvc_urb,
  1459				struct uvc_buffer *buf, struct uvc_buffer *meta_buf)
  1460	{
  1461		struct urb *urb = uvc_urb->urb;
  1462		struct uvc_streaming *stream = uvc_urb->stream;
  1463		u8 *mem;
  1464		int len;
  1465		int len_processed;
  1466	
  1467		/*
  1468		 * Ignore ZLPs if they're not part of a frame, otherwise process them
  1469		 * to trigger the end of payload detection.
  1470		 */
  1471		if (urb->actual_length == 0 && stream->bulk.header_size == 0)
  1472			return;
  1473	
  1474		mem = urb->transfer_buffer;
  1475		len = urb->actual_length;
  1476	
  1477		while (len > 0) {
  1478			len_processed = uvc_video_decode_bulk_single(stream, buf,
  1479				meta_buf, uvc_urb, &mem, &len);
  1480	
  1481			// if we don't process anything, we break out of the decode loop
  1482			if (len_processed == 0) {
  1483				return
> 1484			}
  1485		}
  1486	}
  1487	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49087 bytes --]

  reply	other threads:[~2020-04-22  4:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  2:41 [PATCH v2] media: uvcvideo: read bulk URBs after maxPayloadSize Julian Meyer
2020-04-22  4:50 ` kbuild test robot [this message]
2020-04-22  4:50   ` kbuild test robot
2020-04-22  6:16 ` kbuild test robot
2020-04-22  6:16   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202004221200.v4lagkkr%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.