From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Haiyan Song <haiyanx.song@intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
John Garry <john.garry@huawei.com>, Leo Yan <leo.yan@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/8] perf metrics: fix parse errors in cascade lake metrics
Date: Wed, 22 Apr 2020 07:38:40 -0700 [thread overview]
Message-ID: <20200422143840.GJ608746@tassilo.jf.intel.com> (raw)
In-Reply-To: <20200422074809.160248-3-irogers@google.com>
On Wed, Apr 22, 2020 at 12:48:03AM -0700, Ian Rogers wrote:
> Remove over escaping with \\.
> Remove extraneous if 1 if 0 == 1 else 0 else 0.
So where do these parse errors happen exactly? Some earlier
patches introduced them as regressions?
The original metrics worked without parse errors as far as I know.
If it fixes something earlier it would need Fixes: tags.
-Andi
next prev parent reply other threads:[~2020-04-22 14:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:48 [PATCH 0/8] perf metric fixes and test Ian Rogers
2020-04-22 7:48 ` [PATCH 1/8] perf expr: unlimited escaped characters in a symbol Ian Rogers
2020-04-22 7:48 ` [PATCH 2/8] perf metrics: fix parse errors in cascade lake metrics Ian Rogers
2020-04-22 14:38 ` Andi Kleen [this message]
2020-04-22 15:34 ` Ian Rogers
2020-04-22 16:18 ` Ian Rogers
2020-04-23 1:08 ` Jin, Yao
2020-04-23 5:53 ` Jin, Yao
2020-04-23 6:09 ` Ian Rogers
2020-04-23 7:51 ` Jin, Yao
2020-04-23 10:10 ` Jiri Olsa
2020-04-23 10:11 ` Jiri Olsa
2020-04-23 14:34 ` Ian Rogers
2020-04-22 7:48 ` [PATCH 3/8] perf metrics: fix parse errors in skylake metrics Ian Rogers
2020-04-22 7:48 ` [PATCH 4/8] perf expr: allow ',' to be an other token Ian Rogers
2020-04-22 7:48 ` [PATCH 5/8] perf expr: increase max other Ian Rogers
2020-04-22 7:48 ` [PATCH 6/8] perf expr: parse numbers as doubles Ian Rogers
2020-04-22 7:48 ` [PATCH 7/8] perf expr: debug lex if debugging yaxx Ian Rogers
2020-04-22 7:48 ` [PATCH 8/8] perf test: add expr test for pmu metrics Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422143840.GJ608746@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=haiyanx.song@intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.