From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH v2 net-next 5/5] dpaa2-eth: use bulk enqueue in .ndo_xdp_xmit
Date: Wed, 22 Apr 2020 15:51:17 +0200 [thread overview]
Message-ID: <20200422155117.419b694e@carbon> (raw)
In-Reply-To: <20200422120513.6583-6-ioana.ciornei@nxp.com>
On Wed, 22 Apr 2020 15:05:13 +0300
Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
> Take advantage of the bulk enqueue feature in .ndo_xdp_xmit.
> We cannot use the XDP_XMIT_FLUSH since the architecture is not capable
> to store all the frames dequeued in a NAPI cycle so we instead are
> enqueueing all the frames received in a ndo_xdp_xmit call right away.
>
> After setting up all FDs for the xdp_frames received, enqueue multiple
> frames at a time until all are sent or the maximum number of retries is
> hit.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Changes in v2:
> - use a statically allocated array of dpaa2_fd for each fq
> - use DEV_MAP_BULK_SIZE as the max number of xdp_frames received
Thanks for doing this.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-04-22 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 12:05 [PATCH v2 net-next 0/5] dpaa2-eth: add support for xdp bulk enqueue Ioana Ciornei
2020-04-22 12:05 ` [PATCH v2 net-next 1/5] xdp: export the DEV_MAP_BULK_SIZE macro Ioana Ciornei
2020-04-22 13:03 ` Jesper Dangaard Brouer
2020-04-22 12:05 ` [PATCH v2 net-next 2/5] dpaa2-eth: return num_enqueued frames from enqueue callback Ioana Ciornei
2020-04-22 12:05 ` [PATCH v2 net-next 3/5] dpaa2-eth: use the bulk ring mode enqueue interface Ioana Ciornei
2020-04-22 12:05 ` [PATCH v2 net-next 4/5] dpaa2-eth: split the .ndo_xdp_xmit callback into two stages Ioana Ciornei
2020-04-22 13:54 ` Jesper Dangaard Brouer
2020-04-22 12:05 ` [PATCH v2 net-next 5/5] dpaa2-eth: use bulk enqueue in .ndo_xdp_xmit Ioana Ciornei
2020-04-22 13:51 ` Jesper Dangaard Brouer [this message]
2020-04-23 3:11 ` [PATCH v2 net-next 0/5] dpaa2-eth: add support for xdp bulk enqueue David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422155117.419b694e@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.