From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH v2 net-next 4/5] dpaa2-eth: split the .ndo_xdp_xmit callback into two stages
Date: Wed, 22 Apr 2020 15:54:17 +0200 [thread overview]
Message-ID: <20200422155417.230f94a6@carbon> (raw)
In-Reply-To: <20200422120513.6583-5-ioana.ciornei@nxp.com>
On Wed, 22 Apr 2020 15:05:12 +0300
Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
> Instead of having a function that both creates a frame descriptor from
> an xdp_frame and enqueues it, split this into two stages.
> Add the dpaa2_eth_xdp_create_fd that just transforms an xdp_frame into a
> FD while the actual enqueue callback is called directly from the ndo for
> each frame.
> This is particulary useful in conjunction with bulk enqueue.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
LGTM - and I very recently had to do a deep dive into this driver code.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-04-22 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 12:05 [PATCH v2 net-next 0/5] dpaa2-eth: add support for xdp bulk enqueue Ioana Ciornei
2020-04-22 12:05 ` [PATCH v2 net-next 1/5] xdp: export the DEV_MAP_BULK_SIZE macro Ioana Ciornei
2020-04-22 13:03 ` Jesper Dangaard Brouer
2020-04-22 12:05 ` [PATCH v2 net-next 2/5] dpaa2-eth: return num_enqueued frames from enqueue callback Ioana Ciornei
2020-04-22 12:05 ` [PATCH v2 net-next 3/5] dpaa2-eth: use the bulk ring mode enqueue interface Ioana Ciornei
2020-04-22 12:05 ` [PATCH v2 net-next 4/5] dpaa2-eth: split the .ndo_xdp_xmit callback into two stages Ioana Ciornei
2020-04-22 13:54 ` Jesper Dangaard Brouer [this message]
2020-04-22 12:05 ` [PATCH v2 net-next 5/5] dpaa2-eth: use bulk enqueue in .ndo_xdp_xmit Ioana Ciornei
2020-04-22 13:51 ` Jesper Dangaard Brouer
2020-04-23 3:11 ` [PATCH v2 net-next 0/5] dpaa2-eth: add support for xdp bulk enqueue David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422155417.230f94a6@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.