From: Catalin Marinas <catalin.marinas@arm.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Steven Price <steven.price@arm.com>,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Hugh Dickins <hughd@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH 2/4] mm: Add arch hooks for saving/restoring tags
Date: Thu, 23 Apr 2020 10:09:20 +0100 [thread overview]
Message-ID: <20200423090919.GA4963@gaia> (raw)
In-Reply-To: <edd132f8-c39b-9586-1714-19a335ccea5c@intel.com>
On Wed, Apr 22, 2020 at 11:08:10AM -0700, Dave Hansen wrote:
> On 4/22/20 7:25 AM, Steven Price wrote:
> > Three new hooks are added to the swap code:
> > * arch_prepare_to_swap() and
> > * arch_swap_invalidate_page() / arch_swap_invalidate_area().
> > One new hook is added to shmem:
> > * arch_swap_restore_tags()
>
> How do the tags get restored outside of the shmem path? I was expecting
> to see more arch_swap_restore_tags() sites.
The restoring is done via set_pte_at() -> mte_sync_tags() ->
mte_restore_tags() in the arch code (see patch 3).
arch_swap_restore_tags() just calls mte_restore_tags() directly.
shmem is slightly problematic as it moves the page from the swap cache
to the shmem one and I think arch_swap_invalidate_page() would have
already been called by the time we get to set_pte_at() (Steven can
correct me if I got this wrong).
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Hugh Dickins <hughd@google.com>,
Steven Price <steven.price@arm.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] mm: Add arch hooks for saving/restoring tags
Date: Thu, 23 Apr 2020 10:09:20 +0100 [thread overview]
Message-ID: <20200423090919.GA4963@gaia> (raw)
In-Reply-To: <edd132f8-c39b-9586-1714-19a335ccea5c@intel.com>
On Wed, Apr 22, 2020 at 11:08:10AM -0700, Dave Hansen wrote:
> On 4/22/20 7:25 AM, Steven Price wrote:
> > Three new hooks are added to the swap code:
> > * arch_prepare_to_swap() and
> > * arch_swap_invalidate_page() / arch_swap_invalidate_area().
> > One new hook is added to shmem:
> > * arch_swap_restore_tags()
>
> How do the tags get restored outside of the shmem path? I was expecting
> to see more arch_swap_restore_tags() sites.
The restoring is done via set_pte_at() -> mte_sync_tags() ->
mte_restore_tags() in the arch code (see patch 3).
arch_swap_restore_tags() just calls mte_restore_tags() directly.
shmem is slightly problematic as it moves the page from the swap cache
to the shmem one and I think arch_swap_invalidate_page() would have
already been called by the time we get to set_pte_at() (Steven can
correct me if I got this wrong).
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-23 9:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 14:25 [PATCH 0/4] arm64: MTE swap and hibernation support Steven Price
2020-04-22 14:25 ` Steven Price
2020-04-22 14:25 ` [PATCH 1/4] mm: Add PG_ARCH_2 page flag Steven Price
2020-04-22 14:25 ` Steven Price
2020-04-22 14:25 ` [PATCH 2/4] mm: Add arch hooks for saving/restoring tags Steven Price
2020-04-22 14:25 ` Steven Price
2020-04-22 18:08 ` Dave Hansen
2020-04-22 18:08 ` Dave Hansen
2020-04-23 9:09 ` Catalin Marinas [this message]
2020-04-23 9:09 ` Catalin Marinas
2020-04-23 12:37 ` Steven Price
2020-04-23 12:37 ` Steven Price
2020-04-22 14:25 ` [PATCH 3/4] arm64: mte: Enable swap of tagged pages Steven Price
2020-04-22 14:25 ` Steven Price
2020-04-22 18:34 ` Dave Hansen
2020-04-22 18:34 ` Dave Hansen
2020-04-22 18:34 ` Dave Hansen
2020-04-23 13:51 ` Steven Price
2020-04-23 13:51 ` Steven Price
2020-05-03 15:29 ` Catalin Marinas
2020-05-03 15:29 ` Catalin Marinas
2020-05-04 12:53 ` Steven Price
2020-05-04 12:53 ` Steven Price
2020-04-22 14:25 ` [PATCH 4/4] arm64: mte: Save tags when hibernating Steven Price
2020-04-22 14:25 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423090919.GA4963@gaia \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@intel.com \
--cc=hughd@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=steven.price@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.