All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false
Date: Thu, 23 Apr 2020 15:02:27 +0800	[thread overview]
Message-ID: <202004231508.Yo0J11ax%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3340 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c578ddb39e565139897124e74e5a43e56538cb33
commit: afe956c577b2d5a3d9834e4424587c1ebcf90c4c kbuild: Enable -Wtautological-compare
date:   2 weeks ago
config: arm-tct_hammer_defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2de52422acf04662b45599f77c14ce1b2cec2b81)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        git checkout afe956c577b2d5a3d9834e4424587c1ebcf90c4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare]
           if (&ep->queue == NULL)
                ~~~~^~~~~    ~~~~
   1 warning generated.

vim +255 drivers/usb/gadget/udc/s3c2410_udc.c

3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  250  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  251  static void s3c2410_udc_nuke(struct s3c2410_udc *udc,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  252  		struct s3c2410_ep *ep, int status)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  253  {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  254  	/* Sanity check */
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06 @255  	if (&ep->queue == NULL)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  256  		return;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  257  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  258  	while (!list_empty(&ep->queue)) {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  259  		struct s3c2410_request *req;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  260  		req = list_entry(ep->queue.next, struct s3c2410_request,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  261  				queue);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  262  		s3c2410_udc_done(ep, req, status);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  263  	}
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  264  }
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  265  

:::::: The code at line 255 was first introduced by commit
:::::: 3fc154b6b8134b98bb94d60cad9a46ec1ffbe372 USB Gadget driver for Samsung s3c2410 ARM SoC

:::::: TO: Arnaud Patard <arnaud.patard@rtp-net.org>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 12049 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-kernel@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>
Subject: drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false
Date: Thu, 23 Apr 2020 15:02:27 +0800	[thread overview]
Message-ID: <202004231508.Yo0J11ax%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3285 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c578ddb39e565139897124e74e5a43e56538cb33
commit: afe956c577b2d5a3d9834e4424587c1ebcf90c4c kbuild: Enable -Wtautological-compare
date:   2 weeks ago
config: arm-tct_hammer_defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2de52422acf04662b45599f77c14ce1b2cec2b81)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        git checkout afe956c577b2d5a3d9834e4424587c1ebcf90c4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare]
           if (&ep->queue == NULL)
                ~~~~^~~~~    ~~~~
   1 warning generated.

vim +255 drivers/usb/gadget/udc/s3c2410_udc.c

3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  250  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  251  static void s3c2410_udc_nuke(struct s3c2410_udc *udc,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  252  		struct s3c2410_ep *ep, int status)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  253  {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  254  	/* Sanity check */
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06 @255  	if (&ep->queue == NULL)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  256  		return;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  257  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  258  	while (!list_empty(&ep->queue)) {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  259  		struct s3c2410_request *req;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  260  		req = list_entry(ep->queue.next, struct s3c2410_request,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  261  				queue);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  262  		s3c2410_udc_done(ep, req, status);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  263  	}
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  264  }
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  265  

:::::: The code at line 255 was first introduced by commit
:::::: 3fc154b6b8134b98bb94d60cad9a46ec1ffbe372 USB Gadget driver for Samsung s3c2410 ARM SoC

:::::: TO: Arnaud Patard <arnaud.patard@rtp-net.org>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 12049 bytes --]

             reply	other threads:[~2020-04-23  7:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23  7:02 kbuild test robot [this message]
2020-04-23  7:02 ` drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false kbuild test robot
2020-04-23 16:30 ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202004231508.Yo0J11ax%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.