From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: akpm@linux-foundation.org
Cc: Syed Nayyar Waris <syednwaris@gmail.com>,
andriy.shevchenko@linux.intel.com, michal.simek@xilinx.com,
arnd@arndb.de, rrichter@marvell.com, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, yamada.masahiro@socionext.com,
rui.zhang@intel.com, daniel.lezcano@linaro.org,
amit.kucheria@verdurent.com, linux-arch@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 0/6] Introduce the for_each_set_clump macro
Date: Fri, 24 Apr 2020 09:50:33 -0400 [thread overview]
Message-ID: <20200424135011.GA3255@icarus> (raw)
In-Reply-To: <20200424122407.GA5523@syed>
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Fri, Apr 24, 2020 at 05:54:07PM +0530, Syed Nayyar Waris wrote:
> This patchset introduces a new generic version of for_each_set_clump.
> The previous version of for_each_set_clump8 used a fixed size 8-bit
> clump, but the new generic version can work with clump of any size but
> less than or equal to BITS_PER_LONG. The patchset utilizes the new macro
> in several GPIO drivers.
Regarding the nomenclature, I created the term "clump" to represent an
8-bit value that was not necessarily a byte yet was a contiguous
grouping of bits. With this patchset, we now have a more generic
for_each_set_clump macro that can handle values larger and smaller than
8-bits.
Would it make sense to retire the term "clump" and instead use "nbits"
where applicable, in order to match the existing convention used by the
bitmap functions; for instance, would it be better to name this macro
for_each_set_nbits?
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-arch@vger.kernel.org, amit.kucheria@verdurent.com,
arnd@arndb.de, yamada.masahiro@socionext.com,
linus.walleij@linaro.org, daniel.lezcano@linaro.org,
michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
bgolaszewski@baylibre.com, rrichter@marvell.com,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
rui.zhang@intel.com, andriy.shevchenko@linux.intel.com,
Syed Nayyar Waris <syednwaris@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/6] Introduce the for_each_set_clump macro
Date: Fri, 24 Apr 2020 09:50:33 -0400 [thread overview]
Message-ID: <20200424135011.GA3255@icarus> (raw)
In-Reply-To: <20200424122407.GA5523@syed>
[-- Attachment #1.1: Type: text/plain, Size: 945 bytes --]
On Fri, Apr 24, 2020 at 05:54:07PM +0530, Syed Nayyar Waris wrote:
> This patchset introduces a new generic version of for_each_set_clump.
> The previous version of for_each_set_clump8 used a fixed size 8-bit
> clump, but the new generic version can work with clump of any size but
> less than or equal to BITS_PER_LONG. The patchset utilizes the new macro
> in several GPIO drivers.
Regarding the nomenclature, I created the term "clump" to represent an
8-bit value that was not necessarily a byte yet was a contiguous
grouping of bits. With this patchset, we now have a more generic
for_each_set_clump macro that can handle values larger and smaller than
8-bits.
Would it make sense to retire the term "clump" and instead use "nbits"
where applicable, in order to match the existing convention used by the
bitmap functions; for instance, would it be better to name this macro
for_each_set_nbits?
William Breathitt Gray
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-24 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 12:24 [PATCH 0/6] Introduce the for_each_set_clump macro Syed Nayyar Waris
2020-04-24 12:24 ` Syed Nayyar Waris
2020-04-24 13:50 ` William Breathitt Gray [this message]
2020-04-24 13:50 ` William Breathitt Gray
2020-04-24 16:28 ` Andy Shevchenko
2020-04-24 16:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424135011.GA3255@icarus \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=rui.zhang@intel.com \
--cc=syednwaris@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.