From: kbuild test robot <lkp@intel.com>
To: Douglas Gilbert <dgilbert@interlog.com>, linux-scsi@vger.kernel.org
Cc: kbuild-all@lists.01.org, martin.petersen@oracle.com,
jejb@linux.vnet.ibm.com, hare@suse.de
Subject: Re: [PATCH v9 25/40] sg: replace rq array with lists
Date: Fri, 24 Apr 2020 23:21:15 +0800 [thread overview]
Message-ID: <202004242322.LN5S78ti%lkp@intel.com> (raw)
In-Reply-To: <20200421215258.14348-26-dgilbert@interlog.com>
Hi Douglas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to scsi/for-next linus/master v5.7-rc2 next-20200424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Douglas-Gilbert/sg-add-v4-interface/20200423-165610
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-191-gc51a0382-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
/usr/lib/gcc/x86_64-linux-gnu/7/include/stddef.h:417:9: sparse: sparse: preprocessor token offsetof redefined
include/linux/stddef.h:17:9: sparse: this was the original definition
>> drivers/scsi/sg.c:2889:20: sparse: sparse: incorrect type in initializer (different base types) @@ expected int gfp @@ got restricted gfp_t [usertyint gfp @@
>> drivers/scsi/sg.c:2889:20: sparse: expected int gfp
>> drivers/scsi/sg.c:2889:20: sparse: got restricted gfp_t [usertype]
>> drivers/scsi/sg.c:2892:51: sparse: sparse: restricted gfp_t degrades to integer
>> drivers/scsi/sg.c:2892:49: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted gfp_t [usertype] flags @@ got [usertype] flags @@
>> drivers/scsi/sg.c:2892:49: sparse: expected restricted gfp_t [usertype] flags
>> drivers/scsi/sg.c:2892:49: sparse: got unsigned int
drivers/scsi/sg.c:2894:51: sparse: sparse: restricted gfp_t degrades to integer
drivers/scsi/sg.c:2894:49: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted gfp_t [usertype] flags @@ got [usertype] flags @@
drivers/scsi/sg.c:2894:49: sparse: expected restricted gfp_t [usertype] flags
drivers/scsi/sg.c:2894:49: sparse: got unsigned int
vim +2889 drivers/scsi/sg.c
2878
2879 /*
2880 * Makes a new sg_request object. If 'first' is set then use GFP_KERNEL which
2881 * may take time but has improved chance of success, otherwise use GFP_ATOMIC.
2882 * Note that basic initialization is done but srp is not added to either sfp
2883 * list. On error returns twisted negated errno value (not NULL).
2884 */
2885 static struct sg_request *
2886 sg_mk_srp(struct sg_fd *sfp, bool first)
2887 {
2888 struct sg_request *srp;
> 2889 int gfp = __GFP_NOWARN;
2890
2891 if (first) /* prepared to wait if none already outstanding */
> 2892 srp = kzalloc(sizeof(*srp), gfp | GFP_KERNEL);
2893 else
2894 srp = kzalloc(sizeof(*srp), gfp | GFP_ATOMIC);
2895 if (srp) {
2896 atomic_set(&srp->rq_st, SG_RS_INACTIVE);
2897 srp->parentfp = sfp;
2898 return srp;
2899 } else {
2900 return ERR_PTR(-ENOMEM);
2901 }
2902 }
2903
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v9 25/40] sg: replace rq array with lists
Date: Fri, 24 Apr 2020 23:21:15 +0800 [thread overview]
Message-ID: <202004242322.LN5S78ti%lkp@intel.com> (raw)
In-Reply-To: <20200421215258.14348-26-dgilbert@interlog.com>
[-- Attachment #1: Type: text/plain, Size: 3377 bytes --]
Hi Douglas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to scsi/for-next linus/master v5.7-rc2 next-20200424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Douglas-Gilbert/sg-add-v4-interface/20200423-165610
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-191-gc51a0382-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
/usr/lib/gcc/x86_64-linux-gnu/7/include/stddef.h:417:9: sparse: sparse: preprocessor token offsetof redefined
include/linux/stddef.h:17:9: sparse: this was the original definition
>> drivers/scsi/sg.c:2889:20: sparse: sparse: incorrect type in initializer (different base types) @@ expected int gfp @@ got restricted gfp_t [usertyint gfp @@
>> drivers/scsi/sg.c:2889:20: sparse: expected int gfp
>> drivers/scsi/sg.c:2889:20: sparse: got restricted gfp_t [usertype]
>> drivers/scsi/sg.c:2892:51: sparse: sparse: restricted gfp_t degrades to integer
>> drivers/scsi/sg.c:2892:49: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted gfp_t [usertype] flags @@ got [usertype] flags @@
>> drivers/scsi/sg.c:2892:49: sparse: expected restricted gfp_t [usertype] flags
>> drivers/scsi/sg.c:2892:49: sparse: got unsigned int
drivers/scsi/sg.c:2894:51: sparse: sparse: restricted gfp_t degrades to integer
drivers/scsi/sg.c:2894:49: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted gfp_t [usertype] flags @@ got [usertype] flags @@
drivers/scsi/sg.c:2894:49: sparse: expected restricted gfp_t [usertype] flags
drivers/scsi/sg.c:2894:49: sparse: got unsigned int
vim +2889 drivers/scsi/sg.c
2878
2879 /*
2880 * Makes a new sg_request object. If 'first' is set then use GFP_KERNEL which
2881 * may take time but has improved chance of success, otherwise use GFP_ATOMIC.
2882 * Note that basic initialization is done but srp is not added to either sfp
2883 * list. On error returns twisted negated errno value (not NULL).
2884 */
2885 static struct sg_request *
2886 sg_mk_srp(struct sg_fd *sfp, bool first)
2887 {
2888 struct sg_request *srp;
> 2889 int gfp = __GFP_NOWARN;
2890
2891 if (first) /* prepared to wait if none already outstanding */
> 2892 srp = kzalloc(sizeof(*srp), gfp | GFP_KERNEL);
2893 else
2894 srp = kzalloc(sizeof(*srp), gfp | GFP_ATOMIC);
2895 if (srp) {
2896 atomic_set(&srp->rq_st, SG_RS_INACTIVE);
2897 srp->parentfp = sfp;
2898 return srp;
2899 } else {
2900 return ERR_PTR(-ENOMEM);
2901 }
2902 }
2903
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2020-04-24 15:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 21:52 [PATCH v9 00/40] sg: add v4 interface Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 01/40] sg: move functions around Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 02/40] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 03/40] sg: sg_log and is_enabled Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 04/40] sg: rework sg_poll(), minor changes Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 05/40] sg: bitops in sg_device Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 06/40] sg: make open count an atomic Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 07/40] sg: move header to uapi section Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 08/40] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 09/40] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 10/40] sg: improve naming Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 11/40] sg: change rwlock to spinlock Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 12/40] sg: ioctl handling Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 13/40] sg: split sg_read Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 14/40] sg: sg_common_write add structure for arguments Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 15/40] sg: rework sg_vma_fault Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 16/40] sg: rework sg_mmap Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 17/40] sg: replace sg_allow_access Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 18/40] sg: rework scatter gather handling Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 19/40] sg: introduce request state machine Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 20/40] sg: sg_find_srp_by_id Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 21/40] sg: sg_fill_request_element Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 22/40] sg: printk change %p to %pK Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 23/40] sg: xarray for fds in device Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 24/40] sg: xarray for reqs in fd Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 25/40] sg: replace rq array with lists Douglas Gilbert
2020-04-24 15:21 ` kbuild test robot [this message]
2020-04-24 15:21 ` kbuild test robot
2020-04-21 21:52 ` [PATCH v9 26/40] sg: sense buffer rework Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 27/40] sg: add sg v4 interface support Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 28/40] sg: rework debug info Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 29/40] sg: add 8 byte SCSI LUN to sg_scsi_id Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 30/40] sg: expand sg_comm_wr_t Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 31/40] sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 32/40] sg: add some __must_hold macros Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 33/40] sg: move procfs objects to avoid forward decls Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 34/40] sg: protect multiple receivers Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 35/40] sg: first debugfs support Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 36/40] sg: rework mmap support Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 37/40] sg: defang allow_dio Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 38/40] sg: warn v3 write system call users Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 39/40] sg: add mmap_sz tracking Douglas Gilbert
2020-04-21 21:52 ` [PATCH v9 40/40] sg: bump version to 4.0.09 Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004242322.LN5S78ti%lkp@intel.com \
--to=lkp@intel.com \
--cc=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.