All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] panel: simple: Add BOE NV133FHM-N61
Date: Sat, 25 Apr 2020 17:43:57 +0200	[thread overview]
Message-ID: <20200425154357.GJ32235@ravnborg.org> (raw)
In-Reply-To: <20200420215742.1927498-2-bjorn.andersson@linaro.org>

On Mon, Apr 20, 2020 at 02:57:42PM -0700, Bjorn Andersson wrote:
> The BOE NV133FHM-N61 panel is a 13.3" 1920x1080 eDP panel, add support
> for it in panel-simple.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

While applying I fixed so boe_nv133fhm_n61 is defined before boe_nv140fhmn49.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..5b92583bccdf 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1124,6 +1124,36 @@ static const struct panel_desc boe_nv140fhmn49 = {
>  	.connector_type = DRM_MODE_CONNECTOR_eDP,
>  };
>  
> +static const struct drm_display_mode boe_nv133fhm_n61_modes = {
> +	.clock = 147840,
> +	.hdisplay = 1920,
> +	.hsync_start = 1920 + 48,
> +	.hsync_end = 1920 + 48 + 32,
> +	.htotal = 1920 + 48 + 32 + 200,
> +	.vdisplay = 1080,
> +	.vsync_start = 1080 + 3,
> +	.vsync_end = 1080 + 3 + 6,
> +	.vtotal = 1080 + 3 + 6 + 31,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc boe_nv133fhm_n61 = {
> +	.modes = &boe_nv133fhm_n61_modes,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 300,
> +		.height = 187,
> +	},
> +	.delay = {
> +		.hpd_absent_delay = 200,
> +		.unprepare = 500,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DATA_MSB_TO_LSB,
> +	.connector_type = DRM_MODE_CONNECTOR_eDP,
> +};
> +
>  static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
>  	.clock = 9000,
>  	.hdisplay = 480,
> @@ -3478,6 +3508,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "boe,nv101wxmn51",
>  		.data = &boe_nv101wxmn51,
> +	}, {
> +		.compatible = "boe,nv133fhm-n61",
> +		.data = &boe_nv133fhm_n61,
>  	}, {
>  		.compatible = "boe,nv140fhmn49",
>  		.data = &boe_nv140fhmn49,
> -- 
> 2.26.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] panel: simple: Add BOE NV133FHM-N61
Date: Sat, 25 Apr 2020 17:43:57 +0200	[thread overview]
Message-ID: <20200425154357.GJ32235@ravnborg.org> (raw)
In-Reply-To: <20200420215742.1927498-2-bjorn.andersson@linaro.org>

On Mon, Apr 20, 2020 at 02:57:42PM -0700, Bjorn Andersson wrote:
> The BOE NV133FHM-N61 panel is a 13.3" 1920x1080 eDP panel, add support
> for it in panel-simple.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

While applying I fixed so boe_nv133fhm_n61 is defined before boe_nv140fhmn49.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..5b92583bccdf 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1124,6 +1124,36 @@ static const struct panel_desc boe_nv140fhmn49 = {
>  	.connector_type = DRM_MODE_CONNECTOR_eDP,
>  };
>  
> +static const struct drm_display_mode boe_nv133fhm_n61_modes = {
> +	.clock = 147840,
> +	.hdisplay = 1920,
> +	.hsync_start = 1920 + 48,
> +	.hsync_end = 1920 + 48 + 32,
> +	.htotal = 1920 + 48 + 32 + 200,
> +	.vdisplay = 1080,
> +	.vsync_start = 1080 + 3,
> +	.vsync_end = 1080 + 3 + 6,
> +	.vtotal = 1080 + 3 + 6 + 31,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc boe_nv133fhm_n61 = {
> +	.modes = &boe_nv133fhm_n61_modes,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 300,
> +		.height = 187,
> +	},
> +	.delay = {
> +		.hpd_absent_delay = 200,
> +		.unprepare = 500,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DATA_MSB_TO_LSB,
> +	.connector_type = DRM_MODE_CONNECTOR_eDP,
> +};
> +
>  static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
>  	.clock = 9000,
>  	.hdisplay = 480,
> @@ -3478,6 +3508,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "boe,nv101wxmn51",
>  		.data = &boe_nv101wxmn51,
> +	}, {
> +		.compatible = "boe,nv133fhm-n61",
> +		.data = &boe_nv133fhm_n61,
>  	}, {
>  		.compatible = "boe,nv140fhmn49",
>  		.data = &boe_nv140fhmn49,
> -- 
> 2.26.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-04-25 15:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 21:57 [PATCH 1/2] dt-bindings: display: simple: Add BOE NV133FHM-N61 Bjorn Andersson
2020-04-20 21:57 ` Bjorn Andersson
2020-04-20 21:57 ` [PATCH 2/2] panel: " Bjorn Andersson
2020-04-20 21:57   ` Bjorn Andersson
2020-04-25 15:43   ` Sam Ravnborg [this message]
2020-04-25 15:43     ` Sam Ravnborg
2020-04-25 15:42 ` [PATCH 1/2] dt-bindings: display: " Sam Ravnborg
2020-04-25 15:42   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425154357.GJ32235@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.