From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: mark.rutland@arm.com, irogers@google.com, ak@linux.intel.com,
qiangqing.zhang@nxp.com, peterz@infradead.org,
robin.murphy@arm.com, linuxarm@huawei.com, acme@kernel.org,
linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com,
alexander.shishkin@linux.intel.com, mingo@redhat.com,
namhyung@kernel.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 01/13] perf parse-events: Fix comparison of evsel and leader pmu name
Date: Mon, 27 Apr 2020 10:16:24 +0200 [thread overview]
Message-ID: <20200427081624.GA1431639@krava> (raw)
In-Reply-To: <1587120084-18990-2-git-send-email-john.garry@huawei.com>
On Fri, Apr 17, 2020 at 06:41:12PM +0800, John Garry wrote:
> Since we now strdup() the pmu name for the event selector, use strcmp()
> instead of pointer equality for comparison.
>
> Fixes: d4953f7ef1a2 ("perf parse-events: Fix 3 use after frees found with clang ASANutil/parse-events.c")
> Signed-off-by: John Garry <john.garry@huawei.com>
I don't ee this change in your branch:
private-topic-perf-5.6-sys-pmu-events-v2-upstream
do you have some updated tree?
thanks,
jirka
> ---
>
> I am not 100% sure that this is the right fix....
>
> tools/perf/util/parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 10107747b361..90ddade1ba23 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1629,7 +1629,7 @@ parse_events__set_leader_for_uncore_aliase(char *name, struct list_head *list,
> * event. That can be used to distinguish the leader from
> * other members, even they have the same event name.
> */
> - if ((leader != evsel) && (leader->pmu_name == evsel->pmu_name)) {
> + if ((leader != evsel) && !strcmp(leader->pmu_name, evsel->pmu_name)) {
> is_leader = false;
> continue;
> }
> --
> 2.16.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
namhyung@kernel.org, will@kernel.org, ak@linux.intel.com,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
qiangqing.zhang@nxp.com, irogers@google.com,
robin.murphy@arm.com, zhangshaokun@hisilicon.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 01/13] perf parse-events: Fix comparison of evsel and leader pmu name
Date: Mon, 27 Apr 2020 10:16:24 +0200 [thread overview]
Message-ID: <20200427081624.GA1431639@krava> (raw)
In-Reply-To: <1587120084-18990-2-git-send-email-john.garry@huawei.com>
On Fri, Apr 17, 2020 at 06:41:12PM +0800, John Garry wrote:
> Since we now strdup() the pmu name for the event selector, use strcmp()
> instead of pointer equality for comparison.
>
> Fixes: d4953f7ef1a2 ("perf parse-events: Fix 3 use after frees found with clang ASANutil/parse-events.c")
> Signed-off-by: John Garry <john.garry@huawei.com>
I don't ee this change in your branch:
private-topic-perf-5.6-sys-pmu-events-v2-upstream
do you have some updated tree?
thanks,
jirka
> ---
>
> I am not 100% sure that this is the right fix....
>
> tools/perf/util/parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 10107747b361..90ddade1ba23 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1629,7 +1629,7 @@ parse_events__set_leader_for_uncore_aliase(char *name, struct list_head *list,
> * event. That can be used to distinguish the leader from
> * other members, even they have the same event name.
> */
> - if ((leader != evsel) && (leader->pmu_name == evsel->pmu_name)) {
> + if ((leader != evsel) && !strcmp(leader->pmu_name, evsel->pmu_name)) {
> is_leader = false;
> continue;
> }
> --
> 2.16.4
>
next prev parent reply other threads:[~2020-04-27 8:16 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 10:41 [RFC PATCH v2 00/13] perf pmu-events: Support event aliasing for system PMUs John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 01/13] perf parse-events: Fix comparison of evsel and leader pmu name John Garry
2020-04-17 10:41 ` John Garry
2020-04-27 8:16 ` Jiri Olsa [this message]
2020-04-27 8:16 ` Jiri Olsa
2020-04-27 9:03 ` John Garry
2020-04-27 9:03 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 02/13] perf jevents: Add support for an extra directory level John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 03/13] perf jevents: Add support for system events tables John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 04/13] perf vendor events arm64: Relocate hip08 events John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 05/13] perf vendor events arm64: Add Architected events smmuv3-pmcg.json John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 15:13 ` Ian Rogers
2020-04-17 15:13 ` Ian Rogers
2020-04-17 16:14 ` John Garry
2020-04-17 16:14 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 06/13] perf vendor events arm64: Add hip08 SMMUv3 PMCG events John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 07/13] perf pmu: Add pmu_id() John Garry
2020-04-17 10:41 ` John Garry
2020-04-22 11:41 ` Jiri Olsa
2020-04-22 11:41 ` Jiri Olsa
2020-04-22 11:54 ` John Garry
2020-04-22 11:54 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 08/13] perf pmu: Add pmu_add_sys_aliases() John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 09/13] perf vendor events: Add JSON metrics for imx8mm DDR Perf John Garry
2020-04-17 10:41 ` John Garry
2020-04-20 4:17 ` Joakim Zhang
2020-04-20 4:17 ` Joakim Zhang
2020-04-20 10:50 ` John Garry
2020-04-20 10:50 ` John Garry
2020-04-20 11:25 ` Joakim Zhang
2020-04-20 11:25 ` Joakim Zhang
2020-04-20 14:20 ` John Garry
2020-04-20 14:20 ` John Garry
2020-04-21 2:40 ` Joakim Zhang
2020-04-21 2:40 ` Joakim Zhang
2020-04-21 12:28 ` John Garry
2020-04-21 12:28 ` John Garry
2020-04-27 8:09 ` John Garry
2020-04-27 8:09 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 10/13] perf metricgroup: Split up metricgroup__add_metric() John Garry
2020-04-17 10:41 ` John Garry
2020-04-22 11:44 ` Jiri Olsa
2020-04-22 11:44 ` Jiri Olsa
2020-04-22 12:00 ` John Garry
2020-04-22 12:00 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 11/13] perf metricgroup: Split up metricgroup__print() John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 12/13] perf metricgroup: Support printing metric groups for system PMUs John Garry
2020-04-17 10:41 ` John Garry
2020-04-17 10:41 ` [RFC PATCH v2 13/13] perf metricgroup: Support adding metrics " John Garry
2020-04-17 10:41 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427081624.GA1431639@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.