* [Intel-gfx] [patch] PCI ID review
@ 2020-04-27 3:22 Alexei Podtelezhnikov
2020-04-27 3:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Alexei Podtelezhnikov @ 2020-04-27 3:22 UTC (permalink / raw)
To: intel-gfx
In reverse order:
- Add SKL GT1.5
- Remove wrong and non-existant devices
- Add Gen3/Gen4 twin IGDs
- Amend historic records
Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
---
src/i915_pciids.h | 72 +++++++++++++++++++++++++++++++++++++------------------
1 file changed, 49 insertions(+), 23 deletions(-)
diff --git a/src/i915_pciids.h b/src/i915_pciids.h
index 1d2c1221..a9c88eab 100644
--- a/src/i915_pciids.h
+++ b/src/i915_pciids.h
@@ -47,7 +47,11 @@ Amend historic records
0x030000, 0xff0000, \
(unsigned long) info }
+#define INTEL_I740_IDS(info) \
+ INTEL_VGA_DEVICE(0x7800, info) /* I740 */
+
#define INTEL_I810_IDS(info) \
+ INTEL_VGA_DEVICE(0x1240, info), /* I752 */ \
INTEL_VGA_DEVICE(0x7121, info), /* I810 */ \
INTEL_VGA_DEVICE(0x7123, info), /* I810_DC100 */ \
INTEL_VGA_DEVICE(0x7125, info) /* I810_E */
@@ -62,57 +66,79 @@ Add Gen3/Gen4 twin IGDs
INTEL_VGA_DEVICE(0x2562, info)
#define INTEL_I85X_IDS(info) \
- INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \
- INTEL_VGA_DEVICE(0x358e, info)
+ INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \
+ INTEL_VGA_DEVICE(0x358e, info) /* I854 */
#define INTEL_I865G_IDS(info) \
INTEL_VGA_DEVICE(0x2572, info) /* I865_G */
#define INTEL_I915G_IDS(info) \
- INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \
+ INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \
+ INTEL_VGA_DEVICE(0x2782, info), /* I915_G */ \
INTEL_VGA_DEVICE(0x258a, info) /* E7221_G */
#define INTEL_I915GM_IDS(info) \
- INTEL_VGA_DEVICE(0x2592, info) /* I915_GM */
+ INTEL_VGA_DEVICE(0x2592, info), /* I915_GM */ \
+ INTEL_VGA_DEVICE(0x2792, info) /* I915_GM */
#define INTEL_I945G_IDS(info) \
- INTEL_VGA_DEVICE(0x2772, info) /* I945_G */
+ INTEL_VGA_DEVICE(0x2772, info), /* I945_G */ \
+ INTEL_VGA_DEVICE(0x2776, info) /* I945_G */
#define INTEL_I945GM_IDS(info) \
- INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \
+ INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \
+ INTEL_VGA_DEVICE(0x27a6, info), /* I945_GM */ \
INTEL_VGA_DEVICE(0x27ae, info) /* I945_GME */
#define INTEL_I965G_IDS(info) \
INTEL_VGA_DEVICE(0x2972, info), /* I946_GZ */ \
+ INTEL_VGA_DEVICE(0x2973, info), /* I946_GZ */ \
INTEL_VGA_DEVICE(0x2982, info), /* G35_G */ \
+ INTEL_VGA_DEVICE(0x2983, info), /* G35_G */ \
INTEL_VGA_DEVICE(0x2992, info), /* I965_Q */ \
- INTEL_VGA_DEVICE(0x29a2, info) /* I965_G */
+ INTEL_VGA_DEVICE(0x2993, info), /* I965_Q */ \
+ INTEL_VGA_DEVICE(0x29a2, info), /* I965_G */ \
+ INTEL_VGA_DEVICE(0x29a3, info) /* I965_G */
#define INTEL_G33_IDS(info) \
INTEL_VGA_DEVICE(0x29b2, info), /* Q35_G */ \
+ INTEL_VGA_DEVICE(0x29b3, info), /* Q35_G */ \
INTEL_VGA_DEVICE(0x29c2, info), /* G33_G */ \
- INTEL_VGA_DEVICE(0x29d2, info) /* Q33_G */
+ INTEL_VGA_DEVICE(0x29c3, info), /* G33_G */ \
+ INTEL_VGA_DEVICE(0x29d2, info), /* Q33_G */ \
+ INTEL_VGA_DEVICE(0x29d3, info) /* Q33_G */
#define INTEL_I965GM_IDS(info) \
- INTEL_VGA_DEVICE(0x2a02, info), /* I965_GM */ \
- INTEL_VGA_DEVICE(0x2a12, info) /* I965_GME */
+ INTEL_VGA_DEVICE(0x2a02, info), /* I965_GM */ \
+ INTEL_VGA_DEVICE(0x2a03, info), /* I965_GM */ \
+ INTEL_VGA_DEVICE(0x2a12, info), /* I965_GME */ \
+ INTEL_VGA_DEVICE(0x2a13, info) /* I965_GME */
#define INTEL_GM45_IDS(info) \
- INTEL_VGA_DEVICE(0x2a42, info) /* GM45_G */
+ INTEL_VGA_DEVICE(0x2a42, info), /* GM45_G */ \
+ INTEL_VGA_DEVICE(0x2a43, info) /* GM45_G */
#define INTEL_G45_IDS(info) \
- INTEL_VGA_DEVICE(0x2e02, info), /* IGD_E_G */ \
- INTEL_VGA_DEVICE(0x2e12, info), /* Q45_G */ \
- INTEL_VGA_DEVICE(0x2e22, info), /* G45_G */ \
- INTEL_VGA_DEVICE(0x2e32, info), /* G41_G */ \
- INTEL_VGA_DEVICE(0x2e42, info), /* B43_G */ \
- INTEL_VGA_DEVICE(0x2e92, info) /* B43_G.1 */
+ INTEL_VGA_DEVICE(0x2e02, info), /* IGD_E_G */ \
+ INTEL_VGA_DEVICE(0x2e03, info), /* IGD_E_G */ \
+ INTEL_VGA_DEVICE(0x2e12, info), /* Q45_G */ \
+ INTEL_VGA_DEVICE(0x2e13, info), /* Q45_G */ \
+ INTEL_VGA_DEVICE(0x2e22, info), /* G45_G */ \
+ INTEL_VGA_DEVICE(0x2e23, info), /* G45_G */ \
+ INTEL_VGA_DEVICE(0x2e32, info), /* G41_G */ \
+ INTEL_VGA_DEVICE(0x2e33, info), /* G41_G */ \
+ INTEL_VGA_DEVICE(0x2e42, info), /* B43_G */ \
+ INTEL_VGA_DEVICE(0x2e43, info), /* B43_G */ \
+ INTEL_VGA_DEVICE(0x2e92, info), /* B43_G.1 */ \
+ INTEL_VGA_DEVICE(0x2e93, info) /* B43_G.1 */
#define INTEL_PINEVIEW_G_IDS(info) \
- INTEL_VGA_DEVICE(0xa001, info)
+ INTEL_VGA_DEVICE(0xa001, info), \
+ INTEL_VGA_DEVICE(0xa002, info)
#define INTEL_PINEVIEW_M_IDS(info) \
- INTEL_VGA_DEVICE(0xa011, info)
+ INTEL_VGA_DEVICE(0xa011, info), \
+ INTEL_VGA_DEVICE(0xa012, info)
#define INTEL_IRONLAKE_D_IDS(info) \
INTEL_VGA_DEVICE(0x0042, info)
@@ -258,9 +284,7 @@ Remove wrong and non-existant devices
INTEL_VGA_DEVICE(0x0f30, info), \
INTEL_VGA_DEVICE(0x0f31, info), \
INTEL_VGA_DEVICE(0x0f32, info), \
- INTEL_VGA_DEVICE(0x0f33, info), \
- INTEL_VGA_DEVICE(0x0157, info), \
- INTEL_VGA_DEVICE(0x0155, info)
+ INTEL_VGA_DEVICE(0x0f33, info)
#define INTEL_BDW_ULT_GT1_IDS(info) \
INTEL_VGA_DEVICE(0x1606, info), /* GT1 ULT */ \
@@ -331,7 +355,8 @@ Add SKL GT1.5
INTEL_VGA_DEVICE(0x22b3, info)
#define INTEL_SKL_ULT_GT1_IDS(info) \
- INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
+ INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
+ INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */
#define INTEL_SKL_ULX_GT1_IDS(info) \
INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
@@ -340,6 +365,7 @@ Add SKL GT1.5
INTEL_SKL_ULT_GT1_IDS(info), \
INTEL_SKL_ULX_GT1_IDS(info), \
INTEL_VGA_DEVICE(0x1902, info), /* DT GT1 */ \
+ INTEL_VGA_DEVICE(0x1917, info), /* DT GT1.5 */ \
INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
--
2.26.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI ID review 2020-04-27 3:22 [Intel-gfx] [patch] PCI ID review Alexei Podtelezhnikov @ 2020-04-27 3:52 ` Patchwork 2020-04-27 4:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-04-27 3:52 UTC (permalink / raw) To: Alexei Podtelezhnikov; +Cc: intel-gfx == Series Details == Series: PCI ID review URL : https://patchwork.freedesktop.org/series/76515/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5c94f00b8f09 PCI ID review -:8: WARNING:TYPO_SPELLING: 'existant' may be misspelled - perhaps 'existent'? #8: - Remove wrong and non-existant devices total: 0 errors, 1 warnings, 0 checks, 135 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for PCI ID review 2020-04-27 3:22 [Intel-gfx] [patch] PCI ID review Alexei Podtelezhnikov 2020-04-27 3:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2020-04-27 4:15 ` Patchwork 2020-04-27 5:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-04-27 14:02 ` [Intel-gfx] [patch] " Ville Syrjälä 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-04-27 4:15 UTC (permalink / raw) To: Alexei Podtelezhnikov; +Cc: intel-gfx == Series Details == Series: PCI ID review URL : https://patchwork.freedesktop.org/series/76515/ State : success == Summary == CI Bug Log - changes from CI_DRM_8370 -> Patchwork_17471 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/index.html Known issues ------------ Here are the changes found in Patchwork_17471 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@gt_pm: - fi-skl-6600u: [PASS][1] -> [DMESG-FAIL][2] ([i915#1791]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/fi-skl-6600u/igt@i915_selftest@live@gt_pm.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/fi-skl-6600u/igt@i915_selftest@live@gt_pm.html #### Possible fixes #### * igt@i915_selftest@live@gt_pm: - fi-bdw-5557u: [DMESG-FAIL][3] ([i915#1791]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/fi-bdw-5557u/igt@i915_selftest@live@gt_pm.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/fi-bdw-5557u/igt@i915_selftest@live@gt_pm.html - fi-whl-u: [DMESG-FAIL][5] ([i915#1791]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/fi-whl-u/igt@i915_selftest@live@gt_pm.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/fi-whl-u/igt@i915_selftest@live@gt_pm.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1791]: https://gitlab.freedesktop.org/drm/intel/issues/1791 Participating hosts (45 -> 40) ------------------------------ Missing (5): fi-cml-u2 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7500u Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8370 -> Patchwork_17471 CI-20190529: 20190529 CI_DRM_8370: 1f3ffd7683d5457e14a1f879a8714a74b7b7faeb @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5610: 71fed15724898a8f914666093352a964b70a62fc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17471: 5c94f00b8f0986a505c56dc8912a01c7ab2838db @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 5c94f00b8f09 PCI ID review == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for PCI ID review 2020-04-27 3:22 [Intel-gfx] [patch] PCI ID review Alexei Podtelezhnikov 2020-04-27 3:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2020-04-27 4:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-04-27 5:52 ` Patchwork 2020-04-27 14:02 ` [Intel-gfx] [patch] " Ville Syrjälä 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-04-27 5:52 UTC (permalink / raw) To: Alexei Podtelezhnikov; +Cc: intel-gfx == Series Details == Series: PCI ID review URL : https://patchwork.freedesktop.org/series/76515/ State : success == Summary == CI Bug Log - changes from CI_DRM_8370_full -> Patchwork_17471_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_17471_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_pm_rpm@system-suspend-execbuf: - shard-skl: [PASS][1] -> [INCOMPLETE][2] ([i915#151] / [i915#69]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl8/igt@i915_pm_rpm@system-suspend-execbuf.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl1/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [PASS][3] -> [FAIL][4] ([IGT#5]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@pipe-a-torture-move: - shard-hsw: [PASS][5] -> [INCOMPLETE][6] ([i915#61]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-hsw6/igt@kms_cursor_legacy@pipe-a-torture-move.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-hsw4/igt@kms_cursor_legacy@pipe-a-torture-move.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#180] / [i915#93] / [i915#95]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_hdr@bpc-switch-suspend: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-apl6/igt@kms_hdr@bpc-switch-suspend.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-apl2/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - shard-kbl: [PASS][11] -> [FAIL][12] ([i915#53] / [i915#93] / [i915#95]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-kbl7/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-kbl2/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html - shard-apl: [PASS][13] -> [FAIL][14] ([i915#53] / [i915#95]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-apl2/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-apl7/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html #### Possible fixes #### * igt@gem_exec_params@invalid-bsd-ring: - shard-iclb: [SKIP][21] ([fdo#109276]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-iclb7/igt@gem_exec_params@invalid-bsd-ring.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-iclb1/igt@gem_exec_params@invalid-bsd-ring.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [DMESG-WARN][23] ([i915#180]) -> [PASS][24] +6 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-apl6/igt@gem_workarounds@suspend-resume-context.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-apl2/igt@gem_workarounds@suspend-resume-context.html * igt@kms_color@pipe-a-ctm-green-to-red: - shard-skl: [FAIL][25] ([i915#129]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl1/igt@kms_color@pipe-a-ctm-green-to-red.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl9/igt@kms_color@pipe-a-ctm-green-to-red.html * igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen: - shard-skl: [FAIL][27] ([i915#54]) -> [PASS][28] +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html * igt@kms_cursor_legacy@cursor-vs-flip-toggle: - shard-hsw: [FAIL][29] ([i915#57]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite: - shard-skl: [FAIL][31] ([i915#49]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl9/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][33] ([i915#1188]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-kbl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][37] ([fdo#108145] / [i915#265]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_suspend: - shard-iclb: [SKIP][39] ([fdo#109441]) -> [PASS][40] +2 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-iclb8/igt@kms_psr@psr2_suspend.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-iclb2/igt@kms_psr@psr2_suspend.html * igt@kms_setmode@basic: - shard-hsw: [FAIL][41] ([i915#31]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-hsw4/igt@kms_setmode@basic.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-hsw1/igt@kms_setmode@basic.html * {igt@perf@blocking-parameterized}: - shard-hsw: [FAIL][43] ([i915#1542]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-hsw6/igt@perf@blocking-parameterized.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-hsw4/igt@perf@blocking-parameterized.html #### Warnings #### * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][45] ([i915#658]) -> [SKIP][46] ([i915#588]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_suspend@sysfs-reader: - shard-kbl: [INCOMPLETE][47] ([CI#80]) -> [INCOMPLETE][48] ([CI#80] / [i915#155]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-kbl6/igt@i915_suspend@sysfs-reader.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-kbl3/igt@i915_suspend@sysfs-reader.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-apl: [FAIL][49] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][50] ([fdo#108145] / [i915#265]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8370/shard-apl7/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80 [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#129]: https://gitlab.freedesktop.org/drm/intel/issues/129 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57 [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8370 -> Patchwork_17471 CI-20190529: 20190529 CI_DRM_8370: 1f3ffd7683d5457e14a1f879a8714a74b7b7faeb @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5610: 71fed15724898a8f914666093352a964b70a62fc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17471: 5c94f00b8f0986a505c56dc8912a01c7ab2838db @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17471/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [patch] PCI ID review 2020-04-27 3:22 [Intel-gfx] [patch] PCI ID review Alexei Podtelezhnikov ` (2 preceding siblings ...) 2020-04-27 5:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-04-27 14:02 ` Ville Syrjälä 2020-04-27 14:14 ` Chris Wilson 3 siblings, 1 reply; 11+ messages in thread From: Ville Syrjälä @ 2020-04-27 14:02 UTC (permalink / raw) To: Alexei Podtelezhnikov; +Cc: intel-gfx On Sun, Apr 26, 2020 at 11:22:32PM -0400, Alexei Podtelezhnikov wrote: > In reverse order: > - Add SKL GT1.5 > - Remove wrong and non-existant devices > - Add Gen3/Gen4 twin IGDs > - Amend historic records Please split into separate patches and justify each with a proper commit message. > > Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com> > --- > src/i915_pciids.h | 72 +++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 49 insertions(+), 23 deletions(-) > > diff --git a/src/i915_pciids.h b/src/i915_pciids.h > index 1d2c1221..a9c88eab 100644 > --- a/src/i915_pciids.h > +++ b/src/i915_pciids.h > @@ -47,7 +47,11 @@ Amend historic records > 0x030000, 0xff0000, \ > (unsigned long) info } > > +#define INTEL_I740_IDS(info) \ > + INTEL_VGA_DEVICE(0x7800, info) /* I740 */ > + > #define INTEL_I810_IDS(info) \ > + INTEL_VGA_DEVICE(0x1240, info), /* I752 */ \ > INTEL_VGA_DEVICE(0x7121, info), /* I810 */ \ > INTEL_VGA_DEVICE(0x7123, info), /* I810_DC100 */ \ > INTEL_VGA_DEVICE(0x7125, info) /* I810_E */ > @@ -62,57 +66,79 @@ Add Gen3/Gen4 twin IGDs > INTEL_VGA_DEVICE(0x2562, info) > > #define INTEL_I85X_IDS(info) \ > - INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \ > - INTEL_VGA_DEVICE(0x358e, info) > + INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \ > + INTEL_VGA_DEVICE(0x358e, info) /* I854 */ > > #define INTEL_I865G_IDS(info) \ > INTEL_VGA_DEVICE(0x2572, info) /* I865_G */ > > #define INTEL_I915G_IDS(info) \ > - INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \ > + INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \ > + INTEL_VGA_DEVICE(0x2782, info), /* I915_G */ \ > INTEL_VGA_DEVICE(0x258a, info) /* E7221_G */ > > #define INTEL_I915GM_IDS(info) \ > - INTEL_VGA_DEVICE(0x2592, info) /* I915_GM */ > + INTEL_VGA_DEVICE(0x2592, info), /* I915_GM */ \ > + INTEL_VGA_DEVICE(0x2792, info) /* I915_GM */ > > #define INTEL_I945G_IDS(info) \ > - INTEL_VGA_DEVICE(0x2772, info) /* I945_G */ > + INTEL_VGA_DEVICE(0x2772, info), /* I945_G */ \ > + INTEL_VGA_DEVICE(0x2776, info) /* I945_G */ > > #define INTEL_I945GM_IDS(info) \ > - INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \ > + INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \ > + INTEL_VGA_DEVICE(0x27a6, info), /* I945_GM */ \ > INTEL_VGA_DEVICE(0x27ae, info) /* I945_GME */ > > #define INTEL_I965G_IDS(info) \ > INTEL_VGA_DEVICE(0x2972, info), /* I946_GZ */ \ > + INTEL_VGA_DEVICE(0x2973, info), /* I946_GZ */ \ > INTEL_VGA_DEVICE(0x2982, info), /* G35_G */ \ > + INTEL_VGA_DEVICE(0x2983, info), /* G35_G */ \ > INTEL_VGA_DEVICE(0x2992, info), /* I965_Q */ \ > - INTEL_VGA_DEVICE(0x29a2, info) /* I965_G */ > + INTEL_VGA_DEVICE(0x2993, info), /* I965_Q */ \ > + INTEL_VGA_DEVICE(0x29a2, info), /* I965_G */ \ > + INTEL_VGA_DEVICE(0x29a3, info) /* I965_G */ > > #define INTEL_G33_IDS(info) \ > INTEL_VGA_DEVICE(0x29b2, info), /* Q35_G */ \ > + INTEL_VGA_DEVICE(0x29b3, info), /* Q35_G */ \ > INTEL_VGA_DEVICE(0x29c2, info), /* G33_G */ \ > - INTEL_VGA_DEVICE(0x29d2, info) /* Q33_G */ > + INTEL_VGA_DEVICE(0x29c3, info), /* G33_G */ \ > + INTEL_VGA_DEVICE(0x29d2, info), /* Q33_G */ \ > + INTEL_VGA_DEVICE(0x29d3, info) /* Q33_G */ > > #define INTEL_I965GM_IDS(info) \ > - INTEL_VGA_DEVICE(0x2a02, info), /* I965_GM */ \ > - INTEL_VGA_DEVICE(0x2a12, info) /* I965_GME */ > + INTEL_VGA_DEVICE(0x2a02, info), /* I965_GM */ \ > + INTEL_VGA_DEVICE(0x2a03, info), /* I965_GM */ \ > + INTEL_VGA_DEVICE(0x2a12, info), /* I965_GME */ \ > + INTEL_VGA_DEVICE(0x2a13, info) /* I965_GME */ > > #define INTEL_GM45_IDS(info) \ > - INTEL_VGA_DEVICE(0x2a42, info) /* GM45_G */ > + INTEL_VGA_DEVICE(0x2a42, info), /* GM45_G */ \ > + INTEL_VGA_DEVICE(0x2a43, info) /* GM45_G */ > > #define INTEL_G45_IDS(info) \ > - INTEL_VGA_DEVICE(0x2e02, info), /* IGD_E_G */ \ > - INTEL_VGA_DEVICE(0x2e12, info), /* Q45_G */ \ > - INTEL_VGA_DEVICE(0x2e22, info), /* G45_G */ \ > - INTEL_VGA_DEVICE(0x2e32, info), /* G41_G */ \ > - INTEL_VGA_DEVICE(0x2e42, info), /* B43_G */ \ > - INTEL_VGA_DEVICE(0x2e92, info) /* B43_G.1 */ > + INTEL_VGA_DEVICE(0x2e02, info), /* IGD_E_G */ \ > + INTEL_VGA_DEVICE(0x2e03, info), /* IGD_E_G */ \ > + INTEL_VGA_DEVICE(0x2e12, info), /* Q45_G */ \ > + INTEL_VGA_DEVICE(0x2e13, info), /* Q45_G */ \ > + INTEL_VGA_DEVICE(0x2e22, info), /* G45_G */ \ > + INTEL_VGA_DEVICE(0x2e23, info), /* G45_G */ \ > + INTEL_VGA_DEVICE(0x2e32, info), /* G41_G */ \ > + INTEL_VGA_DEVICE(0x2e33, info), /* G41_G */ \ > + INTEL_VGA_DEVICE(0x2e42, info), /* B43_G */ \ > + INTEL_VGA_DEVICE(0x2e43, info), /* B43_G */ \ > + INTEL_VGA_DEVICE(0x2e92, info), /* B43_G.1 */ \ > + INTEL_VGA_DEVICE(0x2e93, info) /* B43_G.1 */ > > #define INTEL_PINEVIEW_G_IDS(info) \ > - INTEL_VGA_DEVICE(0xa001, info) > + INTEL_VGA_DEVICE(0xa001, info), \ > + INTEL_VGA_DEVICE(0xa002, info) > > #define INTEL_PINEVIEW_M_IDS(info) \ > - INTEL_VGA_DEVICE(0xa011, info) > + INTEL_VGA_DEVICE(0xa011, info), \ > + INTEL_VGA_DEVICE(0xa012, info) > > #define INTEL_IRONLAKE_D_IDS(info) \ > INTEL_VGA_DEVICE(0x0042, info) > @@ -258,9 +284,7 @@ Remove wrong and non-existant devices > INTEL_VGA_DEVICE(0x0f30, info), \ > INTEL_VGA_DEVICE(0x0f31, info), \ > INTEL_VGA_DEVICE(0x0f32, info), \ > - INTEL_VGA_DEVICE(0x0f33, info), \ > - INTEL_VGA_DEVICE(0x0157, info), \ > - INTEL_VGA_DEVICE(0x0155, info) > + INTEL_VGA_DEVICE(0x0f33, info) > > #define INTEL_BDW_ULT_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x1606, info), /* GT1 ULT */ \ > @@ -331,7 +355,8 @@ Add SKL GT1.5 > INTEL_VGA_DEVICE(0x22b3, info) > > #define INTEL_SKL_ULT_GT1_IDS(info) \ > - INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */ > + INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \ > + INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */ > > #define INTEL_SKL_ULX_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */ > @@ -340,6 +365,7 @@ Add SKL GT1.5 > INTEL_SKL_ULT_GT1_IDS(info), \ > INTEL_SKL_ULX_GT1_IDS(info), \ > INTEL_VGA_DEVICE(0x1902, info), /* DT GT1 */ \ > + INTEL_VGA_DEVICE(0x1917, info), /* DT GT1.5 */ \ > INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \ > INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */ > > -- > 2.26.1 > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [patch] PCI ID review 2020-04-27 14:02 ` [Intel-gfx] [patch] " Ville Syrjälä @ 2020-04-27 14:14 ` Chris Wilson 2020-04-27 14:40 ` Alexei Podtelezhnikov 0 siblings, 1 reply; 11+ messages in thread From: Chris Wilson @ 2020-04-27 14:14 UTC (permalink / raw) To: Ville Syrjälä, Alexei Podtelezhnikov; +Cc: intel-gfx Quoting Ville Syrjälä (2020-04-27 15:02:48) > On Sun, Apr 26, 2020 at 11:22:32PM -0400, Alexei Podtelezhnikov wrote: > > In reverse order: > > - Add SKL GT1.5 > > - Remove wrong and non-existant devices > > - Add Gen3/Gen4 twin IGDs > > - Amend historic records > > Please split into separate patches and justify each with > a proper commit message. > > > > > Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com> > > --- > > src/i915_pciids.h | 72 +++++++++++++++++++++++++++++++++++++------------------ > > 1 file changed, 49 insertions(+), 23 deletions(-) > > > > diff --git a/src/i915_pciids.h b/src/i915_pciids.h > > index 1d2c1221..a9c88eab 100644 > > --- a/src/i915_pciids.h > > +++ b/src/i915_pciids.h > > @@ -47,7 +47,11 @@ Amend historic records > > 0x030000, 0xff0000, \ > > (unsigned long) info } > > > > +#define INTEL_I740_IDS(info) \ > > + INTEL_VGA_DEVICE(0x7800, info) /* I740 */ > > + > > #define INTEL_I810_IDS(info) \ > > + INTEL_VGA_DEVICE(0x1240, info), /* I752 */ \ > > INTEL_VGA_DEVICE(0x7121, info), /* I810 */ \ > > INTEL_VGA_DEVICE(0x7123, info), /* I810_DC100 */ \ > > INTEL_VGA_DEVICE(0x7125, info) /* I810_E */ > > @@ -62,57 +66,79 @@ Add Gen3/Gen4 twin IGDs > > INTEL_VGA_DEVICE(0x2562, info) > > > > #define INTEL_I85X_IDS(info) \ > > - INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \ > > - INTEL_VGA_DEVICE(0x358e, info) > > + INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \ > > + INTEL_VGA_DEVICE(0x358e, info) /* I854 */ > > > > #define INTEL_I865G_IDS(info) \ > > INTEL_VGA_DEVICE(0x2572, info) /* I865_G */ > > > > #define INTEL_I915G_IDS(info) \ > > - INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \ > > + INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \ > > + INTEL_VGA_DEVICE(0x2782, info), /* I915_G */ \ > > INTEL_VGA_DEVICE(0x258a, info) /* E7221_G */ > > > > #define INTEL_I915GM_IDS(info) \ > > - INTEL_VGA_DEVICE(0x2592, info) /* I915_GM */ > > + INTEL_VGA_DEVICE(0x2592, info), /* I915_GM */ \ > > + INTEL_VGA_DEVICE(0x2792, info) /* I915_GM */ > > > > #define INTEL_I945G_IDS(info) \ > > - INTEL_VGA_DEVICE(0x2772, info) /* I945_G */ > > + INTEL_VGA_DEVICE(0x2772, info), /* I945_G */ \ > > + INTEL_VGA_DEVICE(0x2776, info) /* I945_G */ > > > > #define INTEL_I945GM_IDS(info) \ > > - INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \ > > + INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \ > > + INTEL_VGA_DEVICE(0x27a6, info), /* I945_GM */ \ > > INTEL_VGA_DEVICE(0x27ae, info) /* I945_GME */ > > > > #define INTEL_I965G_IDS(info) \ > > INTEL_VGA_DEVICE(0x2972, info), /* I946_GZ */ \ > > + INTEL_VGA_DEVICE(0x2973, info), /* I946_GZ */ \ These do not exist. They are fake PCI-ID for Windows95 multi monitor. The single device appears twice on the bus as a second function. We never had that restriction and could do multiple monitors on the single device. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [patch] PCI ID review 2020-04-27 14:14 ` Chris Wilson @ 2020-04-27 14:40 ` Alexei Podtelezhnikov 2020-04-27 14:45 ` Chris Wilson 0 siblings, 1 reply; 11+ messages in thread From: Alexei Podtelezhnikov @ 2020-04-27 14:40 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx > > These do not exist. They are fake PCI-ID for Windows95 multi monitor. > The single device appears twice on the bus as a second function. We > never had that restriction and could do multiple monitors on the single > device. Windows 10 drivers list them, they do show up on lspci and I'll quote from Atom datasheet. "This register is unique in Function 1 (the Function 0 DID is separate). This difference in Device ID is necessary for allowing distinct Plug and Play enumeration of function 1 when both function 0 and function 1 have the same class code." Whatever this means. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [patch] PCI ID review 2020-04-27 14:40 ` Alexei Podtelezhnikov @ 2020-04-27 14:45 ` Chris Wilson 2020-04-27 15:18 ` Alexei Podtelezhnikov 0 siblings, 1 reply; 11+ messages in thread From: Chris Wilson @ 2020-04-27 14:45 UTC (permalink / raw) To: Alexei Podtelezhnikov; +Cc: intel-gfx Quoting Alexei Podtelezhnikov (2020-04-27 15:40:42) > > > > These do not exist. They are fake PCI-ID for Windows95 multi monitor. > > The single device appears twice on the bus as a second function. We > > never had that restriction and could do multiple monitors on the single > > device. > > Windows 10 drivers list them, they do show up on lspci and I'll quote > from Atom datasheet. > "This register is unique in Function 1 (the Function 0 DID is > separate). This difference in Device ID is necessary for allowing > distinct Plug and Play enumeration of function 1 when both function 0 > and function 1 have the same class code." > Whatever this means. It means it's a hack for the Window's driver. There is no HW behind it. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [patch] PCI ID review 2020-04-27 14:45 ` Chris Wilson @ 2020-04-27 15:18 ` Alexei Podtelezhnikov 2020-04-27 17:07 ` Rodrigo Vivi 0 siblings, 1 reply; 11+ messages in thread From: Alexei Podtelezhnikov @ 2020-04-27 15:18 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx On Mon, Apr 27, 2020 at 10:45 AM Chris Wilson <chris@chris-wilson.co.uk> wrote: > > Quoting Alexei Podtelezhnikov (2020-04-27 15:40:42) > > > > > > These do not exist. They are fake PCI-ID for Windows95 multi monitor. > > > The single device appears twice on the bus as a second function. We > > > never had that restriction and could do multiple monitors on the single > > > device. > > > > Windows 10 drivers list them, they do show up on lspci and I'll quote > > from Atom datasheet. > > "This register is unique in Function 1 (the Function 0 DID is > > separate). This difference in Device ID is necessary for allowing > > distinct Plug and Play enumeration of function 1 when both function 0 > > and function 1 have the same class code." > > Whatever this means. > > It means it's a hack for the Window's driver. There is no HW behind it. Intel talks about two separate engines (threads?) https://www.intel.com/content/www/us/en/support/articles/000005880/graphics-drivers/legacy-graphics.html https://www.intel.com/content/www/us/en/support/articles/000005747/graphics-drivers.html Still not buying? _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [patch] PCI ID review 2020-04-27 15:18 ` Alexei Podtelezhnikov @ 2020-04-27 17:07 ` Rodrigo Vivi 2020-04-27 22:14 ` Ville Syrjälä 0 siblings, 1 reply; 11+ messages in thread From: Rodrigo Vivi @ 2020-04-27 17:07 UTC (permalink / raw) To: Alexei Podtelezhnikov; +Cc: intel-gfx, Chris Wilson On Mon, Apr 27, 2020 at 11:18:46AM -0400, Alexei Podtelezhnikov wrote: > On Mon, Apr 27, 2020 at 10:45 AM Chris Wilson <chris@chris-wilson.co.uk> wrote: > > > > Quoting Alexei Podtelezhnikov (2020-04-27 15:40:42) > > > > > > > > These do not exist. They are fake PCI-ID for Windows95 multi monitor. > > > > The single device appears twice on the bus as a second function. We > > > > never had that restriction and could do multiple monitors on the single > > > > device. > > > > > > Windows 10 drivers list them, they do show up on lspci and I'll quote > > > from Atom datasheet. > > > "This register is unique in Function 1 (the Function 0 DID is > > > separate). This difference in Device ID is necessary for allowing > > > distinct Plug and Play enumeration of function 1 when both function 0 > > > and function 1 have the same class code." > > > Whatever this means. > > > > It means it's a hack for the Window's driver. There is no HW behind it. > > Intel talks about two separate engines (threads?) > https://www.intel.com/content/www/us/en/support/articles/000005880/graphics-drivers/legacy-graphics.html > https://www.intel.com/content/www/us/en/support/articles/000005747/graphics-drivers.html > Still not buying? Hi Alexei, thanks for these. With this information in mind it looks very wrong to simply add the PCI ID. ADD2 device is not supported by i915. I don't believe it will be as simple as just adding the PCI ID here. > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [patch] PCI ID review 2020-04-27 17:07 ` Rodrigo Vivi @ 2020-04-27 22:14 ` Ville Syrjälä 0 siblings, 0 replies; 11+ messages in thread From: Ville Syrjälä @ 2020-04-27 22:14 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx, Chris Wilson On Mon, Apr 27, 2020 at 10:07:06AM -0700, Rodrigo Vivi wrote: > On Mon, Apr 27, 2020 at 11:18:46AM -0400, Alexei Podtelezhnikov wrote: > > On Mon, Apr 27, 2020 at 10:45 AM Chris Wilson <chris@chris-wilson.co.uk> wrote: > > > > > > Quoting Alexei Podtelezhnikov (2020-04-27 15:40:42) > > > > > > > > > > These do not exist. They are fake PCI-ID for Windows95 multi monitor. > > > > > The single device appears twice on the bus as a second function. We > > > > > never had that restriction and could do multiple monitors on the single > > > > > device. > > > > > > > > Windows 10 drivers list them, they do show up on lspci and I'll quote > > > > from Atom datasheet. > > > > "This register is unique in Function 1 (the Function 0 DID is > > > > separate). This difference in Device ID is necessary for allowing > > > > distinct Plug and Play enumeration of function 1 when both function 0 > > > > and function 1 have the same class code." > > > > Whatever this means. > > > > > > It means it's a hack for the Window's driver. There is no HW behind it. > > > > Intel talks about two separate engines (threads?) > > https://www.intel.com/content/www/us/en/support/articles/000005880/graphics-drivers/legacy-graphics.html > > https://www.intel.com/content/www/us/en/support/articles/000005747/graphics-drivers.html > > Still not buying? > > Hi Alexei, thanks for these. > > With this information in mind it looks very wrong to simply add the PCI ID. > > ADD2 device is not supported by i915. I don't believe it will be as simple > as just adding the PCI ID here. ADD2==sdvo, which is supported just fine. It has nothing to do with the second fake PCI function though. In practice adding the fake PCI IDs shouldn't do any harm as we reject anything but function 0 in the driver probe. But it also means that there is no point in adding them either. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-04-27 22:14 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-04-27 3:22 [Intel-gfx] [patch] PCI ID review Alexei Podtelezhnikov 2020-04-27 3:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2020-04-27 4:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-04-27 5:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-04-27 14:02 ` [Intel-gfx] [patch] " Ville Syrjälä 2020-04-27 14:14 ` Chris Wilson 2020-04-27 14:40 ` Alexei Podtelezhnikov 2020-04-27 14:45 ` Chris Wilson 2020-04-27 15:18 ` Alexei Podtelezhnikov 2020-04-27 17:07 ` Rodrigo Vivi 2020-04-27 22:14 ` Ville Syrjälä
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.