From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jeremy Kerr <jk@ozlabs.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"Eric W . Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 1/5] powerpc/spufs: simplify spufs core dumping
Date: Mon, 27 Apr 2020 21:49:53 +0100 [thread overview]
Message-ID: <20200427204953.GY23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200427200626.1622060-2-hch@lst.de>
On Mon, Apr 27, 2020 at 10:06:21PM +0200, Christoph Hellwig wrote:
> @@ -1988,7 +1984,12 @@ static ssize_t spufs_mbox_info_read(struct file *file, char __user *buf,
> if (ret)
> return ret;
> spin_lock(&ctx->csa.register_lock);
> - ret = __spufs_mbox_info_read(ctx, buf, len, pos);
> + /* EOF if there's no entry in the mbox */
> + if (ctx->csa.prob.mb_stat_R & 0x0000ff) {
> + ret = simple_read_from_buffer(buf, len, pos,
> + &ctx->csa.prob.pu_mb_R,
> + sizeof(ctx->csa.prob.pu_mb_R));
> + }
> spin_unlock(&ctx->csa.register_lock);
> spu_release_saved(ctx);
Again, this really needs fixing. Preferably - as a separate commit preceding
this series, so that it could be backported. simple_read_from_buffer() is
a blocking operation. Yes, I understand that mainline has the same bug;
it really does need to be fixed and having to backport this series is not
a good idea, for obvious reasons.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeremy Kerr <jk@ozlabs.org>, Arnd Bergmann <arnd@arndb.de>,
"Eric W . Biederman" <ebiederm@xmission.com>,
linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] powerpc/spufs: simplify spufs core dumping
Date: Mon, 27 Apr 2020 21:49:53 +0100 [thread overview]
Message-ID: <20200427204953.GY23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200427200626.1622060-2-hch@lst.de>
On Mon, Apr 27, 2020 at 10:06:21PM +0200, Christoph Hellwig wrote:
> @@ -1988,7 +1984,12 @@ static ssize_t spufs_mbox_info_read(struct file *file, char __user *buf,
> if (ret)
> return ret;
> spin_lock(&ctx->csa.register_lock);
> - ret = __spufs_mbox_info_read(ctx, buf, len, pos);
> + /* EOF if there's no entry in the mbox */
> + if (ctx->csa.prob.mb_stat_R & 0x0000ff) {
> + ret = simple_read_from_buffer(buf, len, pos,
> + &ctx->csa.prob.pu_mb_R,
> + sizeof(ctx->csa.prob.pu_mb_R));
> + }
> spin_unlock(&ctx->csa.register_lock);
> spu_release_saved(ctx);
Again, this really needs fixing. Preferably - as a separate commit preceding
this series, so that it could be backported. simple_read_from_buffer() is
a blocking operation. Yes, I understand that mainline has the same bug;
it really does need to be fixed and having to backport this series is not
a good idea, for obvious reasons.
next prev parent reply other threads:[~2020-04-27 20:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 20:06 remove set_fs calls from the coredump code v4 Christoph Hellwig
2020-04-27 20:06 ` Christoph Hellwig
2020-04-27 20:06 ` [PATCH 1/5] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-04-27 20:06 ` Christoph Hellwig
2020-04-27 20:49 ` Al Viro [this message]
2020-04-27 20:49 ` Al Viro
2020-04-28 2:51 ` Jeremy Kerr
2020-04-28 2:51 ` Jeremy Kerr
2020-04-28 6:57 ` Christoph Hellwig
2020-04-28 6:57 ` Christoph Hellwig
2020-04-28 12:02 ` [RFC PATCH] powerpc/spufs: fix copy_to_user while atomic Jeremy Kerr
2020-04-28 12:02 ` Jeremy Kerr
2020-04-28 13:54 ` Christoph Hellwig
2020-04-28 13:54 ` Christoph Hellwig
2020-04-28 16:00 ` Arnd Bergmann
2020-04-28 16:00 ` Arnd Bergmann
2020-04-28 17:11 ` Christoph Hellwig
2020-04-28 17:11 ` Christoph Hellwig
2020-04-29 1:36 ` Jeremy Kerr
2020-04-29 1:36 ` Jeremy Kerr
2020-04-29 6:05 ` Christoph Hellwig
2020-04-29 6:05 ` Christoph Hellwig
2020-04-29 6:13 ` Christoph Hellwig
2020-04-29 6:13 ` Christoph Hellwig
2020-04-29 6:15 ` Christoph Hellwig
2020-04-29 6:15 ` Christoph Hellwig
2020-04-29 6:33 ` Jeremy Kerr
2020-04-29 6:33 ` Jeremy Kerr
2020-04-29 7:42 ` Arnd Bergmann
2020-04-29 7:42 ` Arnd Bergmann
2020-04-27 20:06 ` [PATCH 2/5] signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32 Christoph Hellwig
2020-04-27 20:06 ` Christoph Hellwig
2020-04-27 20:06 ` [PATCH 3/5] binfmt_elf: remove the set_fs in fill_siginfo_note Christoph Hellwig
2020-04-27 20:06 ` Christoph Hellwig
2020-04-27 20:06 ` [PATCH 4/5] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-04-27 20:06 ` Christoph Hellwig
2020-04-27 20:06 ` [PATCH 5/5] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
2020-04-27 20:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427204953.GY23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=jk@ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.