Re: [PATCH v2 5/6] gpio: thunderx: Utilize for_each_set_clump macro

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5308 bytes --]

Hi Syed,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[also build test ERROR on linus/master v5.7-rc3 next-20200424]
[cannot apply to xlnx/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_each_set_clump-macro/20200427-184103
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: x86_64-randconfig-g001-20200427 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bitops.h:383:0,
                    from include/linux/bitops.h:29,
                    from drivers/gpio/gpio-thunderx.c:9:
   drivers/gpio/gpio-thunderx.c: In function 'thunderx_gpio_set_multiple':
>> include/asm-generic/bitops/find.h:100:18: error: passing argument 1 of 'find_next_clump' from incompatible pointer type [-Werror=incompatible-pointer-types]
     find_next_clump((clump), (bits), (size), 0, (clump_size))
                     ^
>> include/linux/bitops.h:62:17: note: in expansion of macro 'find_first_clump'
     for ((start) = find_first_clump(&(clump), (bits), (size), (clump_size)); \
                    ^~~~~~~~~~~~~~~~
   drivers/gpio/gpio-thunderx.c:284:2: note: in expansion of macro 'for_each_set_clump'
     for_each_set_clump(offset, gpio_mask, mask, chip->ngpio, bank_size) {
     ^~~~~~~~~~~~~~~~~~
   include/asm-generic/bitops/find.h:94:22: note: expected 'long unsigned int *' but argument is of type 'u64 * {aka long long unsigned int *}'
    extern unsigned long find_next_clump(unsigned long *clump,
                         ^~~~~~~~~~~~~~~
   In file included from drivers/gpio/gpio-thunderx.c:9:0:
   include/linux/bitops.h:64:33: error: passing argument 1 of 'find_next_clump' from incompatible pointer type [-Werror=incompatible-pointer-types]
          (start) = find_next_clump(&(clump), (bits), (size), (start) + (clump_size), (clump_size)))
                                    ^
   drivers/gpio/gpio-thunderx.c:284:2: note: in expansion of macro 'for_each_set_clump'
     for_each_set_clump(offset, gpio_mask, mask, chip->ngpio, bank_size) {
     ^~~~~~~~~~~~~~~~~~
   In file included from arch/x86/include/asm/bitops.h:383:0,
                    from include/linux/bitops.h:29,
                    from drivers/gpio/gpio-thunderx.c:9:
   include/asm-generic/bitops/find.h:94:22: note: expected 'long unsigned int *' but argument is of type 'u64 * {aka long long unsigned int *}'
    extern unsigned long find_next_clump(unsigned long *clump,
                         ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/find_next_clump +100 include/asm-generic/bitops/find.h

708ff2a0097b02 Akinobu Mita      2010-09-29   82  
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   83  /**
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   84   * find_next_clump - find next clump with set bits in a memory region
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   85   * @clump: location to store copy of found clump
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   86   * @addr: address to base the search on
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   87   * @size: bitmap size in number of bits
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   88   * @offset: bit offset at which to start searching
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   89   * @clump_size: clump size in bits
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   90   *
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   91   * Returns the bit offset for the next set clump; the found clump value is
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   92   * copied to the location pointed by @clump. If no bits are set, returns @size.
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   93   */
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   94  extern unsigned long find_next_clump(unsigned long *clump,
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   95  				      const unsigned long *addr,
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   96  				      unsigned long size, unsigned long offset,
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   97  				      unsigned long clump_size);
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   98  
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26   99  #define find_first_clump(clump, bits, size, clump_size) \
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26 @100  	find_next_clump((clump), (bits), (size), 0, (clump_size))
c1b8ffb88d31d5 Syed Nayyar Waris 2020-04-26  101  

:::::: The code at line 100 was first introduced by commit
:::::: c1b8ffb88d31d5ed311afb9fec47eded4b9410c6 bitops: Introduce the the for_each_set_clump macro

:::::: TO: Syed Nayyar Waris <syednwaris@gmail.com>
:::::: CC: 0day robot <lkp@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41941 bytes --]