From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Charles Keepax <ckeepax@opensource.cirrus.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 4/4] ASoC: wm8994: Silence warnings during deferred probe
Date: Tue, 28 Apr 2020 11:36:38 +0100 [thread overview]
Message-ID: <20200428103638.GP3559@dell> (raw)
In-Reply-To: <20200427112202.GB4272@sirena.org.uk>
On Mon, 27 Apr 2020, Mark Brown wrote:
> On Mon, Apr 27, 2020 at 09:48:32AM +0200, Marek Szyprowski wrote:
> > Don't confuse user with meaningless warning about the failure in getting
> > clocks in case of deferred probe.
>
> > if (ret < 0) {
> > - dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
>
> This completely eliminates the diagnostics which means that if the clock
> isn't there the user is a bit stuck trying to work out what's missing.
> There should still be a diagnostic.
The driver won't defer forever though. The final pass should fail
with a different error. At which point the error will be released to
the system log, no?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 4/4] ASoC: wm8994: Silence warnings during deferred probe
Date: Tue, 28 Apr 2020 11:36:38 +0100 [thread overview]
Message-ID: <20200428103638.GP3559@dell> (raw)
In-Reply-To: <20200427112202.GB4272@sirena.org.uk>
On Mon, 27 Apr 2020, Mark Brown wrote:
> On Mon, Apr 27, 2020 at 09:48:32AM +0200, Marek Szyprowski wrote:
> > Don't confuse user with meaningless warning about the failure in getting
> > clocks in case of deferred probe.
>
> > if (ret < 0) {
> > - dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
>
> This completely eliminates the diagnostics which means that if the clock
> isn't there the user is a bit stuck trying to work out what's missing.
> There should still be a diagnostic.
The driver won't defer forever though. The final pass should fail
with a different error. At which point the error will be released to
the system log, no?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-28 10:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200427074841eucas1p10523e8e342a8fa2d7cdfb2bc4e25d485@eucas1p1.samsung.com>
2020-04-27 7:48 ` [PATCH RESEND 0/4] Minor WM8994 MFD/codec fixes Marek Szyprowski
2020-04-27 7:48 ` Marek Szyprowski
2020-04-27 7:48 ` [PATCH 1/4] mfd: wm8994: Fix driver operation if loaded as modules Marek Szyprowski
2020-04-27 7:48 ` Marek Szyprowski
2020-04-28 10:37 ` Lee Jones
2020-04-28 10:37 ` Lee Jones
2020-05-22 8:06 ` Lee Jones
2020-05-22 8:06 ` Lee Jones
2020-04-27 7:48 ` [PATCH 2/4] mfd: wm8994: Fix unbalanced calls to regulator_bulk_disable() Marek Szyprowski
2020-04-27 7:48 ` Marek Szyprowski
2020-04-28 10:37 ` Lee Jones
2020-04-28 10:37 ` Lee Jones
2020-05-22 8:07 ` Lee Jones
2020-05-22 8:07 ` Lee Jones
2020-04-27 7:48 ` [PATCH 3/4] mfd: wm8994: Silence warning about supplies during deferred probe Marek Szyprowski
2020-04-27 7:48 ` Marek Szyprowski
2020-04-27 10:31 ` Charles Keepax
2020-04-27 10:31 ` Charles Keepax
2020-05-22 8:07 ` Lee Jones
2020-05-22 8:07 ` Lee Jones
2020-04-27 7:48 ` [PATCH 4/4] ASoC: wm8994: Silence warnings " Marek Szyprowski
2020-04-27 7:48 ` Marek Szyprowski
2020-04-27 10:32 ` Charles Keepax
2020-04-27 10:32 ` Charles Keepax
2020-04-27 11:22 ` Mark Brown
2020-04-27 11:22 ` Mark Brown
2020-04-28 10:36 ` Lee Jones [this message]
2020-04-28 10:36 ` Lee Jones
2020-04-28 11:14 ` Mark Brown
2020-04-28 11:14 ` Mark Brown
2020-04-29 7:15 ` Lee Jones
2020-04-29 7:15 ` Lee Jones
2020-04-29 9:56 ` Mark Brown
2020-04-29 9:56 ` Mark Brown
2020-05-22 7:57 ` [PATCH RESEND 0/4] Minor WM8994 MFD/codec fixes Marek Szyprowski
2020-05-22 7:57 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428103638.GP3559@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.