From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rylan Dmello <mail@rylan.coffee>
Cc: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Benjamin Poirier <bpoirier@suse.com>,
Jiri Pirko <jpirko@redhat.com>
Subject: Re: [PATCH 2/3] staging: qlge: Remove print statement for vlgrp field
Date: Tue, 28 Apr 2020 15:06:56 +0300 [thread overview]
Message-ID: <20200428120655.GC2014@kadam> (raw)
In-Reply-To: <51bae37a54d414491779e4a3329508cc864ab900.1587959245.git.mail@rylan.coffee>
On Mon, Apr 27, 2020 at 12:14:44AM -0400, Rylan Dmello wrote:
> Remove statement that tries to print the non-existent 'vlgrp' field
> in the 'ql_adapter' struct, which causes a compilation failure when
> QL_DEV_DUMP is set.
>
> vlgrp seems to have been removed from ql_adapter as a part of
> commit 18c49b91777c ("qlge: do vlan cleanup") in 2011.
>
> vlgrp might be replaced by the 'active_vlans' array introduced in the
> aforementioned commit. But I'm not sure if printing all 64 values of
> that array would help with debugging this driver, so I'm leaving it
> out of the debug code in this patch.
>
> Signed-off-by: Rylan Dmello <mail@rylan.coffee>
Fixes: 18c49b91777c ("qlge: do vlan cleanup")
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-28 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 4:13 [PATCH 0/3] staging: qlge: Fix compilation failures in qlge_dbg.c when QL_DEV_DUMP is set Rylan Dmello
2020-04-27 4:14 ` [PATCH 1/3] staging: qlge: Remove unnecessary parentheses around struct field Rylan Dmello
2020-04-28 12:04 ` Dan Carpenter
2020-04-27 4:14 ` [PATCH 2/3] staging: qlge: Remove print statement for vlgrp field Rylan Dmello
2020-04-28 12:06 ` Dan Carpenter [this message]
2020-04-27 4:15 ` [PATCH 3/3] staging: qlge: Remove print statements for lbq_clean_idx and lbq_free_cnt Rylan Dmello
2020-04-28 12:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428120655.GC2014@kadam \
--to=dan.carpenter@oracle.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=bpoirier@suse.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@rylan.coffee \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.