From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rylan Dmello <mail@rylan.coffee>
Cc: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Benjamin Poirier <bpoirier@suse.com>,
Jiri Pirko <jpirko@redhat.com>
Subject: Re: [PATCH 3/3] staging: qlge: Remove print statements for lbq_clean_idx and lbq_free_cnt
Date: Tue, 28 Apr 2020 15:07:58 +0300 [thread overview]
Message-ID: <20200428120757.GD2014@kadam> (raw)
In-Reply-To: <aa7e0197f4e34cec0855124e45696e33dd9527e5.1587959245.git.mail@rylan.coffee>
On Mon, Apr 27, 2020 at 12:15:18AM -0400, Rylan Dmello wrote:
> Remove debug print statements referring to non-existent fields
> 'lbq_clean_idx' and 'lbq_free_cnt' in the 'rx_ring' struct, which causes
> a compilation failure when QL_DEV_DUMP is set.
>
> These fields were initially removed as a part of commit aec626d2092f
> ("staging: qlge: Update buffer queue prod index despite oom") in 2019.
>
> Their replacement fields ('next_to_use' and 'next_to_clean') are already
> being printed, so this patch does not add new debug statements for them.
>
> Signed-off-by: Rylan Dmello <mail@rylan.coffee>
Fixes: aec626d2092f ("staging: qlge: Update buffer queue prod index despite oom")
regards,
dan carpenter
prev parent reply other threads:[~2020-04-28 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 4:13 [PATCH 0/3] staging: qlge: Fix compilation failures in qlge_dbg.c when QL_DEV_DUMP is set Rylan Dmello
2020-04-27 4:14 ` [PATCH 1/3] staging: qlge: Remove unnecessary parentheses around struct field Rylan Dmello
2020-04-28 12:04 ` Dan Carpenter
2020-04-27 4:14 ` [PATCH 2/3] staging: qlge: Remove print statement for vlgrp field Rylan Dmello
2020-04-28 12:06 ` Dan Carpenter
2020-04-27 4:15 ` [PATCH 3/3] staging: qlge: Remove print statements for lbq_clean_idx and lbq_free_cnt Rylan Dmello
2020-04-28 12:07 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428120757.GD2014@kadam \
--to=dan.carpenter@oracle.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=bpoirier@suse.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@rylan.coffee \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.