From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: liweihang <liweihang@huawei.com>
Cc: kbuild test robot <lkp@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
Linuxarm <linuxarm@huawei.com>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH v3 for-next 1/5] RDMA/hns: Optimize PBL buffer allocation process
Date: Tue, 28 Apr 2020 12:10:13 +0100 [thread overview]
Message-ID: <20200428121013.00001041@Huawei.com> (raw)
In-Reply-To: <B82435381E3B2943AA4D2826ADEF0B3A0232A154@DGGEML522-MBX.china.huawei.com>
On Tue, 28 Apr 2020 16:12:39 +0800
liweihang <liweihang@huawei.com> wrote:
> On 2020/4/28 10:53, kbuild test robot wrote:
> > Hi Weihang,
> >
> > I love your patch! Perhaps something to improve:
> >
> > [auto build test WARNING on rdma/for-next]
> > [also build test WARNING on linus/master v5.7-rc3 next-20200424]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> > improve the system. BTW, we also suggest to use '--base' option to specify the
> > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> >
> > url: https://github.com/0day-ci/linux/commits/Weihang-Li/RDMA-hns-Refactor-process-of-buffer-allocation-and-calculation/20200428-015905
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
> > reproduce:
> > # apt-get install sparse
> > # sparse version: v0.6.1-191-gc51a0382-dirty
> > make ARCH=x86_64 allmodconfig
> > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> >
> > sparse warnings: (new ones prefixed by >>)
> >
> >>> drivers/infiniband/hw/hns/hns_roce_mr.c:375:6: sparse: sparse: symbol 'hns_roce_mr_free' was not declared. Should it be static?
> >
> > Please review and possibly fold the followup patch.
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> >
>
> It will be used out of this file in later series, but it's better to add
> a static currently. Will fix it, thanks.
Alternative would be to declare it in the header at this stage.
Jonathan
>
> Weihang
>
>
> _______________________________________________
> Linuxarm mailing list
> Linuxarm@huawei.com
> http://hulk.huawei.com/mailman/listinfo/linuxarm
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 for-next 1/5] RDMA/hns: Optimize PBL buffer allocation process
Date: Tue, 28 Apr 2020 12:10:13 +0100 [thread overview]
Message-ID: <20200428121013.00001041@Huawei.com> (raw)
In-Reply-To: <B82435381E3B2943AA4D2826ADEF0B3A0232A154@DGGEML522-MBX.china.huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]
On Tue, 28 Apr 2020 16:12:39 +0800
liweihang <liweihang@huawei.com> wrote:
> On 2020/4/28 10:53, kbuild test robot wrote:
> > Hi Weihang,
> >
> > I love your patch! Perhaps something to improve:
> >
> > [auto build test WARNING on rdma/for-next]
> > [also build test WARNING on linus/master v5.7-rc3 next-20200424]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> > improve the system. BTW, we also suggest to use '--base' option to specify the
> > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> >
> > url: https://github.com/0day-ci/linux/commits/Weihang-Li/RDMA-hns-Refactor-process-of-buffer-allocation-and-calculation/20200428-015905
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
> > reproduce:
> > # apt-get install sparse
> > # sparse version: v0.6.1-191-gc51a0382-dirty
> > make ARCH=x86_64 allmodconfig
> > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> >
> > sparse warnings: (new ones prefixed by >>)
> >
> >>> drivers/infiniband/hw/hns/hns_roce_mr.c:375:6: sparse: sparse: symbol 'hns_roce_mr_free' was not declared. Should it be static?
> >
> > Please review and possibly fold the followup patch.
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> >
>
> It will be used out of this file in later series, but it's better to add
> a static currently. Will fix it, thanks.
Alternative would be to declare it in the header at this stage.
Jonathan
>
> Weihang
>
>
> _______________________________________________
> Linuxarm mailing list
> Linuxarm(a)huawei.com
> http://hulk.huawei.com/mailman/listinfo/linuxarm
next prev parent reply other threads:[~2020-04-28 11:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 6:42 [PATCH v3 for-next 0/5] RDMA/hns: Refactor process of buffer allocation and calculation Weihang Li
2020-04-26 6:42 ` [PATCH v3 for-next 1/5] RDMA/hns: Optimize PBL buffer allocation process Weihang Li
2020-04-28 2:52 ` kbuild test robot
2020-04-28 2:52 ` kbuild test robot
2020-04-28 8:12 ` liweihang
2020-04-28 8:12 ` liweihang
2020-04-28 11:10 ` Jonathan Cameron [this message]
2020-04-28 11:10 ` Jonathan Cameron
2020-04-28 12:28 ` liweihang
2020-04-28 12:28 ` liweihang
2020-04-28 2:52 ` [RFC PATCH] RDMA/hns: hns_roce_mr_free() can be static kbuild test robot
2020-04-28 2:52 ` kbuild test robot
2020-04-26 6:42 ` [PATCH v3 for-next 2/5] RDMA/hns: Remove unused MTT functions Weihang Li
2020-04-26 6:42 ` [PATCH v3 for-next 3/5] RDMA/hns: Optimize WQE buffer size calculating process Weihang Li
2020-04-26 6:42 ` [PATCH v3 for-next 4/5] RDMA/hns: Move SRQ code to the reasonable place Weihang Li
2020-04-26 6:42 ` [PATCH v3 for-next 5/5] RDMA/hns: Optimize SRQ buffer size calculating process Weihang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428121013.00001041@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kbuild-all@lists.01.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.