All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-mediatek@lists.infradead.org, lorenzo.bianconi@redhat.com,
	sean.wang@mediatek.com, linux-wireless@vger.kernel.org,
	Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] mt76: mt7663: add the possibility to load firmware v2
Date: Tue, 28 Apr 2020 15:25:28 +0200	[thread overview]
Message-ID: <20200428132528.GA7716@localhost.localdomain> (raw)
In-Reply-To: <87k11zlu0k.fsf@codeaurora.org>


[-- Attachment #1.1: Type: text/plain, Size: 1745 bytes --]

> Felix Fietkau <nbd@nbd.name> writes:
> 
> > On 2020-04-28 13:07, Kalle Valo wrote:
> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >> 
> >>> mt7663 firmware v2 is used for embedded devices since it has more completed
> >>> features in AP mode.
> >>> Add the capability to specify in mt7615 Kconfig which firmware load first
> >>> (v3 or v2) and fallback to the other one if the selected firmware fails
> >>> to load
> >>>
> >>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >>> ---
> >>>  .../net/wireless/mediatek/mt76/mt7615/Kconfig | 13 +++++
> >>>  .../net/wireless/mediatek/mt76/mt7615/mcu.c   | 50 ++++++++++++++++---
> >>>  .../wireless/mediatek/mt76/mt7615/mt7615.h    |  6 ++-
> >>>  .../net/wireless/mediatek/mt76/mt7615/pci.c   |  2 +
> >>>  .../net/wireless/mediatek/mt76/mt7615/usb.c   |  2 +
> >>>  5 files changed, 65 insertions(+), 8 deletions(-)
> >>>

[...]

> 
> > If you want to switch without recompiling, you can always just delete
> > the set of firmware files you don't want to use. The driver will fall
> > back to the other type.
> 
> My problem here is the new Kconfig option and the way I see is that this
> feature doesn't justify the need of a new Kconfig option. A Kconfig
> option shouldn't change the driver behaviour, it should be more about
> enabling and disabling components and other compilation specific
> configuration.
> 
> What about a module parameter? That would be much better and at least I
> can't think of a technical reason why it wouldn't work.

ack, I will post a v2 adding a kernel parameter and removing the kconfig entry

Regards,
Lorenzo

> 
> -- 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Felix Fietkau <nbd@nbd.name>,
	linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
	sean.wang@mediatek.com, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: mt7663: add the possibility to load firmware v2
Date: Tue, 28 Apr 2020 15:25:28 +0200	[thread overview]
Message-ID: <20200428132528.GA7716@localhost.localdomain> (raw)
In-Reply-To: <87k11zlu0k.fsf@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]

> Felix Fietkau <nbd@nbd.name> writes:
> 
> > On 2020-04-28 13:07, Kalle Valo wrote:
> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >> 
> >>> mt7663 firmware v2 is used for embedded devices since it has more completed
> >>> features in AP mode.
> >>> Add the capability to specify in mt7615 Kconfig which firmware load first
> >>> (v3 or v2) and fallback to the other one if the selected firmware fails
> >>> to load
> >>>
> >>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >>> ---
> >>>  .../net/wireless/mediatek/mt76/mt7615/Kconfig | 13 +++++
> >>>  .../net/wireless/mediatek/mt76/mt7615/mcu.c   | 50 ++++++++++++++++---
> >>>  .../wireless/mediatek/mt76/mt7615/mt7615.h    |  6 ++-
> >>>  .../net/wireless/mediatek/mt76/mt7615/pci.c   |  2 +
> >>>  .../net/wireless/mediatek/mt76/mt7615/usb.c   |  2 +
> >>>  5 files changed, 65 insertions(+), 8 deletions(-)
> >>>

[...]

> 
> > If you want to switch without recompiling, you can always just delete
> > the set of firmware files you don't want to use. The driver will fall
> > back to the other type.
> 
> My problem here is the new Kconfig option and the way I see is that this
> feature doesn't justify the need of a new Kconfig option. A Kconfig
> option shouldn't change the driver behaviour, it should be more about
> enabling and disabling components and other compilation specific
> configuration.
> 
> What about a module parameter? That would be much better and at least I
> can't think of a technical reason why it wouldn't work.

ack, I will post a v2 adding a kernel parameter and removing the kconfig entry

Regards,
Lorenzo

> 
> -- 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2020-04-28 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 14:40 [PATCH] mt76: mt7663: add the possibility to load firmware v2 Lorenzo Bianconi
2020-04-26 14:40 ` Lorenzo Bianconi
2020-04-28 11:07 ` Kalle Valo
2020-04-28 11:07   ` Kalle Valo
2020-04-28 11:16   ` Felix Fietkau
2020-04-28 11:16     ` Felix Fietkau
2020-04-28 11:38     ` Kalle Valo
2020-04-28 11:38       ` Kalle Valo
2020-04-28 13:25       ` Lorenzo Bianconi [this message]
2020-04-28 13:25         ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428132528.GA7716@localhost.localdomain \
    --to=lorenzo@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.