From: Christoph Hellwig <hch@lst.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
hch@lst.de, viro@zeniv.linux.org.uk, jk@ozlabs.org
Subject: Re: [PATCH] powerpc/spufs: Add rcu_read_lock() around fcheck()
Date: Tue, 28 Apr 2020 15:52:45 +0200 [thread overview]
Message-ID: <20200428135245.GA2827@lst.de> (raw)
In-Reply-To: <20200428114811.68436-1-mpe@ellerman.id.au>
On Tue, Apr 28, 2020 at 09:48:11PM +1000, Michael Ellerman wrote:
>
> This comes from fcheck_files() via fcheck().
>
> It's pretty clearly documented that fcheck() must be wrapped with
> rcu_read_lock(), so fix it.
But for this to actually be useful you'd need the rcu read lock until
your are done with the file (or got a reference).
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, hch@lst.de, jk@ozlabs.org,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/spufs: Add rcu_read_lock() around fcheck()
Date: Tue, 28 Apr 2020 15:52:45 +0200 [thread overview]
Message-ID: <20200428135245.GA2827@lst.de> (raw)
In-Reply-To: <20200428114811.68436-1-mpe@ellerman.id.au>
On Tue, Apr 28, 2020 at 09:48:11PM +1000, Michael Ellerman wrote:
>
> This comes from fcheck_files() via fcheck().
>
> It's pretty clearly documented that fcheck() must be wrapped with
> rcu_read_lock(), so fix it.
But for this to actually be useful you'd need the rcu read lock until
your are done with the file (or got a reference).
next prev parent reply other threads:[~2020-04-28 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 11:48 [PATCH] powerpc/spufs: Add rcu_read_lock() around fcheck() Michael Ellerman
2020-04-28 11:48 ` Michael Ellerman
2020-04-28 13:52 ` Christoph Hellwig [this message]
2020-04-28 13:52 ` Christoph Hellwig
2020-04-29 11:42 ` Michael Ellerman
2020-04-29 11:42 ` Michael Ellerman
2020-05-07 6:54 ` Christoph Hellwig
2020-05-07 6:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428135245.GA2827@lst.de \
--to=hch@lst.de \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.