From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Sumit Semwal <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org,
amd-gfx@lists.freedesktop.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse
Date: Tue, 28 Apr 2020 16:02:57 +0200 [thread overview]
Message-ID: <20200428140257.GA3433@lst.de> (raw)
In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com>
On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote:
> 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use
> a proper sg_table entries and call respective DMA-mapping functions
> and adapt current code to it
That sounds reasonable to me. Those could be pretty trivial wrappers.
>
>
> 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state
> which one refers to which part of the scatterlist; I'm open for
> other names for those entries
nr_cpu_ents and nr_dma_ents might be better names, but it still would be
a whole lot of churn for little gain. I think just good wrappers like
suggested above might be more helpful.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Sumit Semwal <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org,
amd-gfx@lists.freedesktop.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse
Date: Tue, 28 Apr 2020 16:02:57 +0200 [thread overview]
Message-ID: <20200428140257.GA3433@lst.de> (raw)
In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com>
On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote:
> 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use
> a proper sg_table entries and call respective DMA-mapping functions
> and adapt current code to it
That sounds reasonable to me. Those could be pretty trivial wrappers.
>
>
> 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state
> which one refers to which part of the scatterlist; I'm open for
> other names for those entries
nr_cpu_ents and nr_dma_ents might be better names, but it still would be
a whole lot of churn for little gain. I think just good wrappers like
suggested above might be more helpful.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Sumit Semwal <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org,
amd-gfx@lists.freedesktop.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse
Date: Tue, 28 Apr 2020 16:02:57 +0200 [thread overview]
Message-ID: <20200428140257.GA3433@lst.de> (raw)
In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com>
On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote:
> 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use
> a proper sg_table entries and call respective DMA-mapping functions
> and adapt current code to it
That sounds reasonable to me. Those could be pretty trivial wrappers.
>
>
> 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state
> which one refers to which part of the scatterlist; I'm open for
> other names for those entries
nr_cpu_ents and nr_dma_ents might be better names, but it still would be
a whole lot of churn for little gain. I think just good wrappers like
suggested above might be more helpful.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Sumit Semwal <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org,
amd-gfx@lists.freedesktop.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse
Date: Tue, 28 Apr 2020 16:02:57 +0200 [thread overview]
Message-ID: <20200428140257.GA3433@lst.de> (raw)
In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com>
On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote:
> 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use
> a proper sg_table entries and call respective DMA-mapping functions
> and adapt current code to it
That sounds reasonable to me. Those could be pretty trivial wrappers.
>
>
> 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state
> which one refers to which part of the scatterlist; I'm open for
> other names for those entries
nr_cpu_ents and nr_dma_ents might be better names, but it still would be
a whole lot of churn for little gain. I think just good wrappers like
suggested above might be more helpful.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
intel-gfx@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse
Date: Tue, 28 Apr 2020 16:02:57 +0200 [thread overview]
Message-ID: <20200428140257.GA3433@lst.de> (raw)
In-Reply-To: <20200428132005.21424-1-m.szyprowski@samsung.com>
On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote:
> 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use
> a proper sg_table entries and call respective DMA-mapping functions
> and adapt current code to it
That sounds reasonable to me. Those could be pretty trivial wrappers.
>
>
> 2. rename nents and orig_nents to nr_pages, nr_dmas to clearly state
> which one refers to which part of the scatterlist; I'm open for
> other names for those entries
nr_cpu_ents and nr_dma_ents might be better names, but it still would be
a whole lot of churn for little gain. I think just good wrappers like
suggested above might be more helpful.
next prev parent reply other threads:[~2020-04-28 14:10 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200428132022eucas1p2aa4716cbaca61c432ee8028be15fef7a@eucas1p2.samsung.com>
2020-04-28 13:19 ` [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [RFC 01/17] drm: core: fix " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [RFC 02/17] drm: amdgpu: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 15:14 ` Christian König
2020-04-28 15:14 ` Christian König
2020-04-28 15:14 ` [Intel-gfx] " Christian König
2020-04-28 15:14 ` Christian König
2020-04-28 15:14 ` Christian König
2020-04-28 15:14 ` Christian König
2020-04-28 13:19 ` [RFC 03/17] drm: armada: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [RFC 04/17] drm: etnaviv: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [RFC 05/17] drm: exynos: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 21:59 ` kbuild test robot
2020-04-28 13:19 ` [RFC 06/17] drm: i915: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 14:27 ` [Intel-gfx] " Tvrtko Ursulin
2020-04-28 14:27 ` Tvrtko Ursulin
2020-04-28 14:27 ` Tvrtko Ursulin
2020-04-28 14:27 ` Tvrtko Ursulin
2020-04-28 14:27 ` Tvrtko Ursulin
2020-04-28 14:27 ` Tvrtko Ursulin
2020-04-30 14:17 ` Marek Szyprowski
2020-04-30 14:17 ` Marek Szyprowski
2020-04-30 14:17 ` Marek Szyprowski
2020-04-30 14:17 ` Marek Szyprowski
2020-04-30 14:17 ` Marek Szyprowski
2020-04-30 14:17 ` Marek Szyprowski
2020-04-28 23:04 ` kbuild test robot
2020-04-29 3:21 ` kbuild test robot
2020-04-28 13:19 ` [RFC 07/17] drm: lima: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [RFC 08/17] drm: msm: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [RFC 09/17] drm: panfrost: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [RFC 10/17] drm: radeon: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 15:15 ` Christian König
2020-04-28 15:15 ` Christian König
2020-04-28 15:15 ` [Intel-gfx] " Christian König
2020-04-28 15:15 ` Christian König
2020-04-28 15:15 ` Christian König
2020-04-28 15:15 ` Christian König
2020-04-28 13:19 ` [RFC 11/17] drm: rockchip: " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:19 ` Marek Szyprowski
2020-04-28 13:20 ` [RFC 12/17] drm: tegra: " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [RFC 13/17] drm: virtio: " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [RFC 14/17] drm: vmwgfx: " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [RFC 15/17] drm: xen: " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [RFC 16/17] drm: host1x: " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [RFC 17/17] dmabuf: " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` [Intel-gfx] " Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 13:20 ` Marek Szyprowski
2020-04-28 14:02 ` Christoph Hellwig [this message]
2020-04-28 14:02 ` [RFC 00/17] DRM: fix struct " Christoph Hellwig
2020-04-28 14:02 ` [Intel-gfx] " Christoph Hellwig
2020-04-28 14:02 ` Christoph Hellwig
2020-04-28 14:02 ` Christoph Hellwig
2020-04-28 15:32 ` Daniel Vetter
2020-04-28 15:32 ` Daniel Vetter
2020-04-28 15:32 ` [Intel-gfx] " Daniel Vetter
2020-04-28 15:32 ` Daniel Vetter
2020-04-28 15:32 ` Daniel Vetter
2020-04-28 15:32 ` Daniel Vetter
2020-04-28 16:02 ` Robin Murphy
2020-04-28 16:02 ` Robin Murphy
2020-04-28 16:02 ` [Intel-gfx] " Robin Murphy
2020-04-28 16:02 ` Robin Murphy
2020-04-28 16:02 ` Robin Murphy
2020-04-28 16:02 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428140257.GA3433@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=b.zolnierkie@samsung.com \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.