From: Cyril Hrubis <chrubis@suse.cz>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: kernel test robot <rong.a.chen@intel.com>,
Josh Triplett <josh@joshtriplett.org>,
linux-arch@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, lkp@lists.01.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
ltp@lists.linux.it
Subject: Re: [LTP] [fs] ce436509a8: ltp.openat203.fail
Date: Tue, 28 Apr 2020 17:30:22 +0200 [thread overview]
Message-ID: <20200428153022.GC4244@yuki.lan> (raw)
In-Reply-To: <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com>
Hi!
> > > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds")
> > > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939
> > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next
> >
> > This commit adds fd parameter to the how structure where LTP test was
> > previously passing garbage, which obviously causes the difference in
> > errno.
> >
> > This could be safely ignored for now, if the patch gets merged the test
> > needs to be updated.
>
> It wouldn't be a bad idea to switch the test to figure out the ksize of
> the struct, so that you only add bad padding after that. But then again,
> this would be a bit ugly -- having CHECK_FIELDS would make this simpler.
Any pointers how can be the size figured out without relying on the
E2BIG we are testing for? Does the kernel export it somewhere?
--
Cyril Hrubis
chrubis@suse.cz
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis-AlSwsSmVLrQ@public.gmane.org>
To: Aleksa Sarai <cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
kernel test robot
<rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>,
lkp-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Alexander Viro
<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
io-uring-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ltp-cunTk1MwBs91InPhgRC9rw@public.gmane.org
Subject: Re: [fs] ce436509a8: ltp.openat203.fail
Date: Tue, 28 Apr 2020 17:30:22 +0200 [thread overview]
Message-ID: <20200428153022.GC4244@yuki.lan> (raw)
In-Reply-To: <20200428005126.6wncibudt6ohghvc-DDZ4AMo6ZIKk7xURhxcYY1aTQe2KTcn/@public.gmane.org>
Hi!
> > > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds")
> > > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939
> > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next
> >
> > This commit adds fd parameter to the how structure where LTP test was
> > previously passing garbage, which obviously causes the difference in
> > errno.
> >
> > This could be safely ignored for now, if the patch gets merged the test
> > needs to be updated.
>
> It wouldn't be a bad idea to switch the test to figure out the ksize of
> the struct, so that you only add bad padding after that. But then again,
> this would be a bit ugly -- having CHECK_FIELDS would make this simpler.
Any pointers how can be the size figured out without relying on the
E2BIG we are testing for? Does the kernel export it somewhere?
--
Cyril Hrubis
chrubis-AlSwsSmVLrQ@public.gmane.org
--
Mailing list info: https://lists.linux.it/listinfo/ltp
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [fs] ce436509a8: ltp.openat203.fail
Date: Tue, 28 Apr 2020 17:30:22 +0200 [thread overview]
Message-ID: <20200428153022.GC4244@yuki.lan> (raw)
In-Reply-To: <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com>
Hi!
> > > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds")
> > > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939
> > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next
> >
> > This commit adds fd parameter to the how structure where LTP test was
> > previously passing garbage, which obviously causes the difference in
> > errno.
> >
> > This could be safely ignored for now, if the patch gets merged the test
> > needs to be updated.
>
> It wouldn't be a bad idea to switch the test to figure out the ksize of
> the struct, so that you only add bad padding after that. But then again,
> this would be a bit ugly -- having CHECK_FIELDS would make this simpler.
Any pointers how can be the size figured out without relying on the
E2BIG we are testing for? Does the kernel export it somewhere?
--
Cyril Hrubis
chrubis@suse.cz
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: lkp@lists.01.org
Subject: Re: [LTP] [fs] ce436509a8: ltp.openat203.fail
Date: Tue, 28 Apr 2020 17:30:22 +0200 [thread overview]
Message-ID: <20200428153022.GC4244@yuki.lan> (raw)
In-Reply-To: <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com>
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
Hi!
> > > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds")
> > > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939
> > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next
> >
> > This commit adds fd parameter to the how structure where LTP test was
> > previously passing garbage, which obviously causes the difference in
> > errno.
> >
> > This could be safely ignored for now, if the patch gets merged the test
> > needs to be updated.
>
> It wouldn't be a bad idea to switch the test to figure out the ksize of
> the struct, so that you only add bad padding after that. But then again,
> this would be a bit ugly -- having CHECK_FIELDS would make this simpler.
Any pointers how can be the size figured out without relying on the
E2BIG we are testing for? Does the kernel export it somewhere?
--
Cyril Hrubis
chrubis(a)suse.cz
next prev parent reply other threads:[~2020-04-28 15:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 2:14 [PATCH v4 0/3] Support userspace-selected fds Josh Triplett
2020-04-14 2:15 ` [PATCH v4 1/3] fs: Support setting a minimum fd for "lowest available fd" allocation Josh Triplett
2020-04-14 2:15 ` [PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds Josh Triplett
2020-04-19 10:44 ` Aleksa Sarai
2020-04-19 21:18 ` David Laight
2020-04-19 22:22 ` Jens Axboe
2020-04-20 2:06 ` Aleksa Sarai
2020-04-20 21:14 ` Josh Triplett
[not found] ` <f969e7d45a8e83efc1ca13d675efd8775f13f376.1586830316.git.josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
2020-04-27 13:52 ` [fs] ce436509a8: ltp.openat203.fail kernel test robot
2020-04-27 13:52 ` kernel test robot
2020-04-27 13:52 ` [LTP] " kernel test robot
2020-04-27 14:27 ` Cyril Hrubis
2020-04-27 14:27 ` Cyril Hrubis
2020-04-27 14:27 ` Cyril Hrubis
2020-04-28 0:51 ` Aleksa Sarai
2020-04-28 0:51 ` Aleksa Sarai
2020-04-28 0:51 ` Aleksa Sarai
2020-04-28 15:30 ` Cyril Hrubis [this message]
2020-04-28 15:30 ` Cyril Hrubis
2020-04-28 15:30 ` Cyril Hrubis
2020-04-28 15:30 ` Cyril Hrubis
2020-04-28 15:35 ` [LTP] " Aleksa Sarai
2020-04-28 15:35 ` Aleksa Sarai
2020-04-28 15:35 ` Aleksa Sarai
2020-04-14 2:16 ` [PATCH v4 3/3] fs: pipe2: Support O_SPECIFIC_FD Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428153022.GC4244@yuki.lan \
--to=chrubis@suse.cz \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=cyphar@cyphar.com \
--cc=io-uring@vger.kernel.org \
--cc=josh@joshtriplett.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=ltp@lists.linux.it \
--cc=rong.a.chen@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.