All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] perf c2c: Remove unneeded semicolon
@ 2020-04-28  8:58 Zou Wei
  2020-04-28 17:49 ` Arnaldo Carvalho de Melo
  2020-05-08 13:05 ` [tip: perf/core] " tip-bot2 for Zou Wei
  0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-28  8:58 UTC (permalink / raw)
  To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
	namhyung
  Cc: linux-kernel, Zou Wei

Fixes coccicheck warnings:

 tools/perf/builtin-c2c.c:1712:2-3: Unneeded semicolon
 tools/perf/builtin-c2c.c:1928:2-3: Unneeded semicolon
 tools/perf/builtin-c2c.c:2962:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 tools/perf/builtin-c2c.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 0d544c4..0e14c18 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1709,7 +1709,7 @@ static struct c2c_dimension *get_dimension(const char *name)
 
 		if (!strcmp(dim->name, name))
 			return dim;
-	};
+	}
 
 	return NULL;
 }
@@ -1925,7 +1925,7 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
 		FILTER_HITM(tot_hitm);
 	default:
 		break;
-	};
+	}
 
 #undef FILTER_HITM
 
@@ -2959,7 +2959,7 @@ static int perf_c2c__record(int argc, const char **argv)
 
 		rec_argv[i++] = "-e";
 		rec_argv[i++] = perf_mem_events__name(j);
-	};
+	}
 
 	if (all_user)
 		rec_argv[i++] = "--all-user";
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] perf c2c: Remove unneeded semicolon
  2020-04-28  8:58 [PATCH -next] perf c2c: Remove unneeded semicolon Zou Wei
@ 2020-04-28 17:49 ` Arnaldo Carvalho de Melo
  2020-05-08 13:05 ` [tip: perf/core] " tip-bot2 for Zou Wei
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-04-28 17:49 UTC (permalink / raw)
  To: Zou Wei
  Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, namhyung,
	linux-kernel

Em Tue, Apr 28, 2020 at 04:58:56PM +0800, Zou Wei escreveu:
> Fixes coccicheck warnings:
> 
>  tools/perf/builtin-c2c.c:1712:2-3: Unneeded semicolon
>  tools/perf/builtin-c2c.c:1928:2-3: Unneeded semicolon
>  tools/perf/builtin-c2c.c:2962:2-3: Unneeded semicolon

Thanks, applied.

- Arnaldo
 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  tools/perf/builtin-c2c.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 0d544c4..0e14c18 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -1709,7 +1709,7 @@ static struct c2c_dimension *get_dimension(const char *name)
>  
>  		if (!strcmp(dim->name, name))
>  			return dim;
> -	};
> +	}
>  
>  	return NULL;
>  }
> @@ -1925,7 +1925,7 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
>  		FILTER_HITM(tot_hitm);
>  	default:
>  		break;
> -	};
> +	}
>  
>  #undef FILTER_HITM
>  
> @@ -2959,7 +2959,7 @@ static int perf_c2c__record(int argc, const char **argv)
>  
>  		rec_argv[i++] = "-e";
>  		rec_argv[i++] = perf_mem_events__name(j);
> -	};
> +	}
>  
>  	if (all_user)
>  		rec_argv[i++] = "--all-user";
> -- 
> 2.6.2
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip: perf/core] perf c2c: Remove unneeded semicolon
  2020-04-28  8:58 [PATCH -next] perf c2c: Remove unneeded semicolon Zou Wei
  2020-04-28 17:49 ` Arnaldo Carvalho de Melo
@ 2020-05-08 13:05 ` tip-bot2 for Zou Wei
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Zou Wei @ 2020-05-08 13:05 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Hulk Robot, Zou Wei, Alexander Shishkin, Jiri Olsa, Mark Rutland,
	Namhyung Kim, Peter Zijlstra, Arnaldo Carvalho de Melo, x86, LKML

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     2cca512ad2fe14d060838eaf8581cda600764141
Gitweb:        https://git.kernel.org/tip/2cca512ad2fe14d060838eaf8581cda600764141
Author:        Zou Wei <zou_wei@huawei.com>
AuthorDate:    Tue, 28 Apr 2020 16:58:56 +08:00
Committer:     Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Thu, 30 Apr 2020 10:48:32 -03:00

perf c2c: Remove unneeded semicolon

Fixes coccicheck warnings:

 tools/perf/builtin-c2c.c:1712:2-3: Unneeded semicolon
 tools/perf/builtin-c2c.c:1928:2-3: Unneeded semicolon
 tools/perf/builtin-c2c.c:2962:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/1588064336-70456-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-c2c.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 0d544c4..0e14c18 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1709,7 +1709,7 @@ static struct c2c_dimension *get_dimension(const char *name)
 
 		if (!strcmp(dim->name, name))
 			return dim;
-	};
+	}
 
 	return NULL;
 }
@@ -1925,7 +1925,7 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
 		FILTER_HITM(tot_hitm);
 	default:
 		break;
-	};
+	}
 
 #undef FILTER_HITM
 
@@ -2959,7 +2959,7 @@ static int perf_c2c__record(int argc, const char **argv)
 
 		rec_argv[i++] = "-e";
 		rec_argv[i++] = perf_mem_events__name(j);
-	};
+	}
 
 	if (all_user)
 		rec_argv[i++] = "--all-user";

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-08 13:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-28  8:58 [PATCH -next] perf c2c: Remove unneeded semicolon Zou Wei
2020-04-28 17:49 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] " tip-bot2 for Zou Wei

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.