[PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable

[PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable

[Zou Wei]

Fixes coccicheck warning:

tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 tools/perf/builtin-report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 26d8fc2..02c09fd 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1400,7 +1400,7 @@ int cmd_report(int argc, const char **argv)
 	}
 	if (branch_call_mode) {
 		callchain_param.key = CCKEY_ADDRESS;
-		callchain_param.branch_callstack = 1;
+		callchain_param.branch_callstack = true;
 		symbol_conf.use_callchain = true;
 		callchain_register_param(&callchain_param);
 		if (sort_order == NULL)
-- 
2.6.2

Re: [PATCH -next] perf report: fix warning Comparison of 0/1 to bool variable

[Arnaldo Carvalho de Melo]

Em Sun, Apr 26, 2020 at 08:38:03PM +0800, Zou Wei escreveu:
> Fixes coccicheck warning:
> 
> tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable


Fixed the subject line to have "assignment", not "comparison",

Thanks, applied,

- Arnaldo

[tip: perf/core] perf report: Fix warning assignment of 0/1 to bool variable

[tip-bot2 for Zou Wei]

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     6fa9c3e779b89612c56f8ee0096b2252d906357a
Gitweb:        https://git.kernel.org/tip/6fa9c3e779b89612c56f8ee0096b2252d906357a
Author:        Zou Wei <zou_wei@huawei.com>
AuthorDate:    Sun, 26 Apr 2020 20:38:03 +08:00
Committer:     Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Thu, 30 Apr 2020 10:48:33 -03:00

perf report: Fix warning assignment of 0/1 to bool variable

Fixes coccicheck warning:

  tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/1587904683-3510-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 0c32767..7da1342 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1413,7 +1413,7 @@ repeat:
 	}
 	if (branch_call_mode) {
 		callchain_param.key = CCKEY_ADDRESS;
-		callchain_param.branch_callstack = 1;
+		callchain_param.branch_callstack = true;
 		symbol_conf.use_callchain = true;
 		callchain_register_param(&callchain_param);
 		if (sort_order == NULL)