From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sayali Lokhande <sayalil@codeaurora.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Markus Elfring <Markus.Elfring@web.de>,
Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
Date: Wed, 29 Apr 2020 12:44:02 +0000 [thread overview]
Message-ID: <20200429124402.GP2014@kadam> (raw)
In-Reply-To: <433d4ad5-22e5-fd2b-cab3-9752ed0c66fb@codeaurora.org>
On Wed, Apr 29, 2020 at 10:28:36AM +0530, Sayali Lokhande wrote:
> Hi Markus
>
> On 4/27/2020 4:08 PM, Markus Elfring wrote:
> > > … This results in deadlock as
> > > iput() tries to hold cp_rwsem, which is already held at the
> > > beginning by checkpoint->block_operations().
> > Will another imperative wording become helpful besides the provided information
> > for this change description?
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idj8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
> >
> > Would you like to add the tag “Fixes” because of adjustments
> > for the data synchronisation?
>
> I couldn't find any past commit which suits to be added under "Fixes" here.
> Let me know if you have any other comment.
This looks really old. Maybe commit 399368372ed9 ("f2fs: introduce a
new global lock scheme")?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sayali Lokhande <sayalil@codeaurora.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Markus Elfring <Markus.Elfring@web.de>,
Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
Date: Wed, 29 Apr 2020 15:44:02 +0300 [thread overview]
Message-ID: <20200429124402.GP2014@kadam> (raw)
In-Reply-To: <433d4ad5-22e5-fd2b-cab3-9752ed0c66fb@codeaurora.org>
On Wed, Apr 29, 2020 at 10:28:36AM +0530, Sayali Lokhande wrote:
> Hi Markus
>
> On 4/27/2020 4:08 PM, Markus Elfring wrote:
> > > … This results in deadlock as
> > > iput() tries to hold cp_rwsem, which is already held at the
> > > beginning by checkpoint->block_operations().
> > Will another imperative wording become helpful besides the provided information
> > for this change description?
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
> >
> > Would you like to add the tag “Fixes” because of adjustments
> > for the data synchronisation?
>
> I couldn't find any past commit which suits to be added under "Fixes" here.
> Let me know if you have any other comment.
This looks really old. Maybe commit 399368372ed9 ("f2fs: introduce a
new global lock scheme")?
regards,
dan carpenter
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sayali Lokhande <sayalil@codeaurora.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
Date: Wed, 29 Apr 2020 15:44:02 +0300 [thread overview]
Message-ID: <20200429124402.GP2014@kadam> (raw)
In-Reply-To: <433d4ad5-22e5-fd2b-cab3-9752ed0c66fb@codeaurora.org>
On Wed, Apr 29, 2020 at 10:28:36AM +0530, Sayali Lokhande wrote:
> Hi Markus
>
> On 4/27/2020 4:08 PM, Markus Elfring wrote:
> > > … This results in deadlock as
> > > iput() tries to hold cp_rwsem, which is already held at the
> > > beginning by checkpoint->block_operations().
> > Will another imperative wording become helpful besides the provided information
> > for this change description?
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
> >
> > Would you like to add the tag “Fixes” because of adjustments
> > for the data synchronisation?
>
> I couldn't find any past commit which suits to be added under "Fixes" here.
> Let me know if you have any other comment.
This looks really old. Maybe commit 399368372ed9 ("f2fs: introduce a
new global lock scheme")?
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-29 12:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:38 [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint Markus Elfring
2020-04-27 10:38 ` Markus Elfring
2020-04-27 10:38 ` Markus Elfring
2020-04-29 4:58 ` Sayali Lokhande
2020-04-29 4:59 ` Sayali Lokhande
2020-04-29 4:58 ` Sayali Lokhande
2020-04-29 12:44 ` Dan Carpenter [this message]
2020-04-29 12:44 ` Dan Carpenter
2020-04-29 12:44 ` Dan Carpenter
2020-04-29 16:52 ` Sayali Lokhande
2020-04-29 16:53 ` Sayali Lokhande
2020-04-29 16:52 ` Sayali Lokhande
-- strict thread matches above, loose matches on Subject: below --
2020-04-27 6:00 Sayali Lokhande
2020-04-27 6:08 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429124402.GP2014@kadam \
--to=dan.carpenter@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=jaegeuk@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sayalil@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.