All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v12 4/8] iommu/vt-d: Add bind guest PASID support
Date: Wed, 29 Apr 2020 15:30:03 -0700	[thread overview]
Message-ID: <20200429153003.31d2edf7@jacob-builder> (raw)
In-Reply-To: <72d52eba-8c78-9d99-2537-b03dbfb3b543@redhat.com>

On Wed, 29 Apr 2020 16:12:01 +0200
Auger Eric <eric.auger@redhat.com> wrote:

> >> in last review Eric raised the open about what about binding the
> >> same PASID to the same pdev multiple times. We discussed that
> >> should be disallowed. Here can you check whether aux_domain is
> >> enabled on pdev to restrict multiple-binding only for
> >> sub-devices?  
> > Why aux_domain is sufficient? A pdev could have aux_domain enabled
> > but still bind pdev many times more than its mdevs.
> > 
> > Either we allow multiple bind or not.  
> 
> I tried to figure out whether binding the same PASID to the same pdev
> was meaningful. I understood it is not. If this case can be detected
> at VFIO level I am fine as well.
I will remove the multiple bind support for now. Reintroduce it when we
enable mdev.

Thanks,

Jacob
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	Jonathan Cameron <jic23@kernel.org>,
	jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v12 4/8] iommu/vt-d: Add bind guest PASID support
Date: Wed, 29 Apr 2020 15:30:03 -0700	[thread overview]
Message-ID: <20200429153003.31d2edf7@jacob-builder> (raw)
In-Reply-To: <72d52eba-8c78-9d99-2537-b03dbfb3b543@redhat.com>

On Wed, 29 Apr 2020 16:12:01 +0200
Auger Eric <eric.auger@redhat.com> wrote:

> >> in last review Eric raised the open about what about binding the
> >> same PASID to the same pdev multiple times. We discussed that
> >> should be disallowed. Here can you check whether aux_domain is
> >> enabled on pdev to restrict multiple-binding only for
> >> sub-devices?  
> > Why aux_domain is sufficient? A pdev could have aux_domain enabled
> > but still bind pdev many times more than its mdevs.
> > 
> > Either we allow multiple bind or not.  
> 
> I tried to figure out whether binding the same PASID to the same pdev
> was meaningful. I understood it is not. If this case can be detected
> at VFIO level I am fine as well.
I will remove the multiple bind support for now. Reintroduce it when we
enable mdev.

Thanks,

Jacob

  reply	other threads:[~2020-04-29 22:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 18:52 [PATCH v12 0/8] Nested Shared Virtual Address (SVA) VT-d support Jacob Pan
2020-04-21 18:52 ` Jacob Pan
2020-04-21 18:52 ` [PATCH v12 1/8] iommu/vt-d: Move domain helper to header Jacob Pan
2020-04-21 18:52   ` Jacob Pan
2020-04-21 18:52 ` [PATCH v12 2/8] iommu/vt-d: Use a helper function to skip agaw for SL Jacob Pan
2020-04-21 18:52   ` Jacob Pan
2020-04-23  7:29   ` Tian, Kevin
2020-04-23  7:29     ` Tian, Kevin
2020-04-21 18:52 ` [PATCH v12 3/8] iommu/vt-d: Add nested translation helper function Jacob Pan
2020-04-21 18:52   ` Jacob Pan
2020-04-21 18:52 ` [PATCH v12 4/8] iommu/vt-d: Add bind guest PASID support Jacob Pan
2020-04-21 18:52   ` Jacob Pan
2020-04-24 10:47   ` Tian, Kevin
2020-04-24 10:47     ` Tian, Kevin
2020-04-27 20:34     ` Jacob Pan
2020-04-27 20:34       ` Jacob Pan
2020-04-29 14:12       ` Auger Eric
2020-04-29 14:12         ` Auger Eric
2020-04-29 22:30         ` Jacob Pan [this message]
2020-04-29 22:30           ` Jacob Pan
2020-04-21 18:52 ` [PATCH v12 5/8] iommu/vt-d: Support flushing more translation cache types Jacob Pan
2020-04-21 18:52   ` Jacob Pan
2020-04-21 18:52 ` [PATCH v12 6/8] iommu/vt-d: Add svm/sva invalidate function Jacob Pan
2020-04-21 18:52   ` Jacob Pan
2020-04-29 13:46   ` Auger Eric
2020-04-29 13:46     ` Auger Eric
2020-04-21 18:52 ` [PATCH v12 7/8] iommu/vt-d: Enlightened PASID allocation Jacob Pan
2020-04-21 18:52   ` Jacob Pan
2020-04-21 18:52 ` [PATCH v12 8/8] iommu/vt-d: Add custom allocator for IOASID Jacob Pan
2020-04-21 18:52   ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429153003.31d2edf7@jacob-builder \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=ashok.raj@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=eric.auger@redhat.com \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jean-philippe@linaro.com \
    --cc=jic23@kernel.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.