* [PATCH RFC 1/3] content: Document balloon feature free page hints
2020-04-29 17:27 [PATCH RFC 0/3] virtio-spec: Add documentation for recently added balloon features Alexander Duyck
@ 2020-04-29 17:27 ` Alexander Duyck
2020-04-29 17:27 ` [PATCH RFC 2/3] content: Document balloon feature page poison Alexander Duyck
2020-04-29 17:27 ` [PATCH RFC 3/3] content: Document balloon feature free page reporting Alexander Duyck
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Duyck @ 2020-04-29 17:27 UTC (permalink / raw)
To: cohuck, david, mst; +Cc: virtio-dev, virtio-comment
From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Free page hints allow the balloon driver to provide information on what
pages are not currently in use so that we can avoid the cost of copying
them in migration scenarios. Add a feature description for free page hints
describing basic functioning and requirements.
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
content.tex | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 110 insertions(+), 3 deletions(-)
diff --git a/content.tex b/content.tex
index b91a132df146..796901e83a71 100644
--- a/content.tex
+++ b/content.tex
@@ -5006,9 +5006,12 @@ \subsection{Virtqueues}\label{sec:Device Types / Memory Balloon Device / Virtque
\item[0] inflateq
\item[1] deflateq
\item[2] statsq.
+\item[3] free_page_vq.
\end{description}
- Virtqueue 2 only exists if VIRTIO_BALLOON_F_STATS_VQ set.
+ statsq only exists if VIRTIO_BALLOON_F_STATS_VQ set.
+
+ free_page_vq only exists if VIRTIO_BALLOON_F_FREE_PAGE_HINT set.
\subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Feature bits}
\begin{description}
@@ -5019,6 +5022,10 @@ \subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Featu
memory statistics is present.
\item[VIRTIO_BALLOON_F_DEFLATE_ON_OOM (2) ] Deflate balloon on
guest out of memory condition.
+\item[ VIRTIO_BALLOON_F_FREE_PAGE_HINT(3) ] Device has support for free
+ page hinting. A virtqueue for providing hints as to what memory is
+ currently free is present. Configuration field free_page_hint_cmd_id
+ is valid.
\end{description}
@@ -5042,13 +5049,15 @@ \subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Featu
VIRTIO_BALLOON_F_MUST_TELL_HOST is not negotiated.
\subsection{Device configuration layout}\label{sec:Device Types / Memory Balloon Device / Device configuration layout}
- Both fields of this configuration
- are always available.
+ The first two fields of this configuration are always present. The
+ availability of the others all depend on various feature bits as
+ indicated above.
\begin{lstlisting}
struct virtio_balloon_config {
le32 num_pages;
le32 actual;
+ le32 free_page_hint_cmd_id;
};
\end{lstlisting}
@@ -5075,6 +5084,9 @@ \subsection{Device Initialization}\label{sec:Device Types / Memory Balloon Devic
\item DRIVER_OK is set: device operation begins.
\item Notify the device about the stats virtqueue buffer.
\end{enumerate}
+
+\item If the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature bit is negotiated the
+ free_page_vq is identified.
\end{enumerate}
\subsection{Device Operation}\label{sec:Device Types / Memory Balloon Device / Device Operation}
@@ -5345,6 +5357,101 @@ \subsubsection{Memory Statistics Tags}\label{sec:Device Types / Memory Balloon D
allocations in the guest.
\end{description}
+\subsubsection{Free Page Hinting}\label{sec:Device Types / Memory Balloon Device / Device Operation / Free Page Hinting}
+
+Free page hinting is used during migration to determine what pages within
+the guest are current unused so that they can be skipped over when it comes
+time for migration. The device will indicate that it is ready to start
+performing hinting by setting the \field{free_page_hint_cmd_id} to one of the
+non-reserved values that can be used as a command ID:
+
+\begin{description}
+\item[VIRTIO_BALLOON_CMD_ID_STOP (0)] Any previous command ID is invalid.
+ All hinting SHOULD halt until a new command ID is supplied.
+
+\item[VIRTIO_BALLOON_CMD_ID_DONE (1)] Any previous command ID is invalid.
+ All hinting SHOULD halt and pages returned to the guest for use.
+\end{description}
+
+A request for free page hintings proceeds as follows:
+
+\begin{enumerate}
+
+\item \field{free_page_hint_cmd_id} configuration field is examined. If it
+ contains a non-reserved value then inflation of the balloon will begin.
+
+\item To supply memory to the hinting balloon:
+ \begin{enumerate}
+ \item The driver constructs an output descriptor containing the new value
+ from \field{free_page_hint_cmd_id} configuration field and adds it to
+ the free_page_hint_vq.
+ \item The driver driver maps a series of pages and adds them to the
+ free_page_hint_vq as individual scatter-gather entries.
+ \item When the driver is no longer able to fetch additional pages to add
+ to the free_page_hint_vq it will construct an output descriptor
+ containing the command ID VIRTIO_BALLOON_CMD_ID_STOP.
+ \end{enumerate}
+
+\item A round of hinting ends either when the driver is no longer able to
+ add more pages to the balloon as described above, or when the device
+ updates \field{free_page_hint_cmd_id} configuration field contain either
+ VIRTIO_BALLOON_CMD_ID_STOP or VIRTIO_BALLOON_CMD_ID_DONE.
+
+\item The device may follow VIRTIO_BALLOON_CMD_ID_STOP with a new
+ non-reserved value for \field{free_page_hint_cmd_id} configuration field
+ in which case it will resume supplying the hinting balloon.
+
+\item Otherwise, if the device provides VIRTIO_BALLOON_CMD_ID_DONE then
+ hinting is complete and the guest may begin to re-use pages preivously
+ given to the balloon.
+
+\end{enumerate}
+
+\drivernormative{\paragraph}{Free Page Hinting}{Device Types / Memory Balloon Device / Device Operation / Free Page Hinting}
+
+Normative statements in this section apply if and only if the
+VIRTIO_BALLOON_F_FREE_PAGE_HINT feature has been negotiated.
+
+The driver SHOULD supply pages to the hinting balloon when
+\field{free_page_hint_cmd_id} reports a value of 2 or greater.
+
+The driver MUST start hinting by providing an output descriptor
+containing the current command ID for the given block of pages.
+
+The driver SHOULD stop supplying pages to the hinting balloon when
+\field{free_page_hint_cmd_id} reports a value of VIRTIO_BALLOON_CMD_ID_STOP.
+
+If the driver is unable to supply pages it MUST complete hinting by adding
+an output descriptor containing the command ID VIRTIO_BALLOON_CMD_ID_STOP.
+
+The driver MAY use pages from the balloon after adding them to the balloon,
+including when the device has not acknowledged the hinting request.
+
+The driver SHOULD return pages for use once \field{free_page_hint_cmd_id}
+reports a value of VIRTIO_BALLOON_CMD_ID_DONE.
+
+\devicenormative{\paragraph}{Free Page Hinting}{Device Types / Memory Balloon Device / Device Operation / Free Page Hinting}
+
+Normative statements in this section apply if and only if the
+VIRTIO_BALLOON_F_FREE_PAGE_HINT feature has been negotiated.
+
+The device MUST set \field{free_page_hint_cmd_id} to
+VIRTIO_BALLOON_CMD_ID_STOP any time that the host dirty bits for the given
+guest are being recorded.
+
+The device MUST guarantee that command ID is not reused until it has
+received an output descriptor containing VIRTIO_BALLOON_CMD_ID_STOP from
+the driver.
+
+The device MUST not perform hinting on pages that are provided with a
+command ID that does not match the current value in
+\field{free_page_hint_cmd_id}.
+
+The device MAY modify the contents of the page in the balloon at any time
+after detecting its physical number until it has either been written to by
+the guest or \field{free_page_hint_cmd_id} is set to
+VIRTIO_BALLOON_CMD_ID_DONE.
+
\section{SCSI Host Device}\label{sec:Device Types / SCSI Host Device}
The virtio SCSI host device groups together one or more virtual
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH RFC 2/3] content: Document balloon feature page poison
2020-04-29 17:27 [PATCH RFC 0/3] virtio-spec: Add documentation for recently added balloon features Alexander Duyck
2020-04-29 17:27 ` [PATCH RFC 1/3] content: Document balloon feature free page hints Alexander Duyck
@ 2020-04-29 17:27 ` Alexander Duyck
2020-04-29 17:27 ` [PATCH RFC 3/3] content: Document balloon feature free page reporting Alexander Duyck
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Duyck @ 2020-04-29 17:27 UTC (permalink / raw)
To: cohuck, david, mst; +Cc: virtio-dev, virtio-comment
From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Page poison provides a way for the guest to notify the host of the content
expected to be found in pages when they are added back to the guest after
being discarded. The feature currently doesn't apply to the existing
balloon features, however it will apply to an upcoming feature, free page
reporting. Add documentation for the page poison feature describing the
basic functionality and requirements.
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
content.tex | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/content.tex b/content.tex
index 796901e83a71..c98b8ea9526a 100644
--- a/content.tex
+++ b/content.tex
@@ -5026,6 +5026,9 @@ \subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Featu
page hinting. A virtqueue for providing hints as to what memory is
currently free is present. Configuration field free_page_hint_cmd_id
is valid.
+\item[ VIRTIO_BALLOON_F_PAGE_POISON(4) ] Host has to be notified if guest
+ is expecting reported pages to contain a certain value when returned.
+ Configuration field poison_val is valid.
\end{description}
@@ -5033,6 +5036,9 @@ \subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Featu
The driver SHOULD accept the VIRTIO_BALLOON_F_MUST_TELL_HOST
feature if offered by the device.
+The driver SHOULD clear the VIRTIO_BALLOON_F_PAGE_POISON flag if it is not
+expecting any specific value to be stored in the page.
+
\devicenormative{\subsubsection}{Feature bits}{Device Types / Memory Balloon Device / Feature bits}
If the device offers the VIRTIO_BALLOON_F_MUST_TELL_HOST feature
bit, and if the driver did not accept this feature bit, the
@@ -5058,6 +5064,7 @@ \subsection{Device configuration layout}\label{sec:Device Types / Memory Balloon
le32 num_pages;
le32 actual;
le32 free_page_hint_cmd_id;
+ le32 poison_val;
};
\end{lstlisting}
@@ -5087,6 +5094,9 @@ \subsection{Device Initialization}\label{sec:Device Types / Memory Balloon Devic
\item If the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature bit is negotiated the
free_page_vq is identified.
+
+\item If the VIRTIO_BALLOON_F_PAGE_POISON feature bit is negotiated then
+ the driver MUST update the poison_val configuration field.
\end{enumerate}
\subsection{Device Operation}\label{sec:Device Types / Memory Balloon Device / Device Operation}
@@ -5452,6 +5462,41 @@ \subsubsection{Free Page Hinting}\label{sec:Device Types / Memory Balloon Device
the guest or \field{free_page_hint_cmd_id} is set to
VIRTIO_BALLOON_CMD_ID_DONE.
+\subsubsection{Page Poison}\label{sec:Device Types / Memory Balloon Device / Device Operation / Page Poison}
+
+Page Poison provides a way to notify the host of the contents that are
+currently in the balloon pages, and those that are expected to be in the
+pages when they are pulled from the balloon. It is used for in-place
+reporting of pages without needing to pull them from the memory allocator
+of the guest.
+
+\begin{enumerate}
+
+\item If VIRTIO_BALLOON_F_PAGE_POISON feature is negotiated, the guest will
+ place the expected poison value in \field{poison_val} configuration data.
+
+\end{enumerate}
+
+\drivernormative{\paragraph}{Page Poison}{Device Types / Memory Balloon Device / Device Operation / Page Poison}
+
+Normative statements in this section apply if and only if the
+VIRTIO_BALLOON_F_PAGE_POISON feature has been negotiated.
+
+The driver MUST populate the \field{poison_val} configuration data if it is
+expecting the page to contain some fixed value when free.
+
+The driver MAY opt to disable the feature if it will take care of
+re-initializing pages when first accessing them.
+
+\devicenormative{\paragraph}{Page Poison}{Device Types / Memory Balloon Device / Device Operation / Page Poison}
+
+Normative statements in this section apply if and only if the
+VIRTIO_BALLOON_F_PAGE_POISON feature has been negotiated.
+
+The device MAY ignore the \field{poison_val} for normal balloon operations and
+free page hinting as this feature did not exist prior to those features being
+added.
+
\section{SCSI Host Device}\label{sec:Device Types / SCSI Host Device}
The virtio SCSI host device groups together one or more virtual
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH RFC 3/3] content: Document balloon feature free page reporting
2020-04-29 17:27 [PATCH RFC 0/3] virtio-spec: Add documentation for recently added balloon features Alexander Duyck
2020-04-29 17:27 ` [PATCH RFC 1/3] content: Document balloon feature free page hints Alexander Duyck
2020-04-29 17:27 ` [PATCH RFC 2/3] content: Document balloon feature page poison Alexander Duyck
@ 2020-04-29 17:27 ` Alexander Duyck
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Duyck @ 2020-04-29 17:27 UTC (permalink / raw)
To: cohuck, david, mst; +Cc: virtio-dev, virtio-comment
From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Free page reporting is a feature that allows the guest to proactively
report unused pages to the host. By making use of this feature is is
possible to reduce the overall memory footprint of the guest in cases where
some significant portion of the memory is idle. Add documentation for the
free page reporting feature describing the functionality and requirements.
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
content.tex | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 74 insertions(+)
diff --git a/content.tex b/content.tex
index c98b8ea9526a..52955c8ff007 100644
--- a/content.tex
+++ b/content.tex
@@ -5007,12 +5007,15 @@ \subsection{Virtqueues}\label{sec:Device Types / Memory Balloon Device / Virtque
\item[1] deflateq
\item[2] statsq.
\item[3] free_page_vq.
+\item[4] reporting_vq.
\end{description}
statsq only exists if VIRTIO_BALLOON_F_STATS_VQ set.
free_page_vq only exists if VIRTIO_BALLOON_F_FREE_PAGE_HINT set.
+ reporting_vq only exists if VIRTIO_BALLOON_F_PAGE_REPORTING set.
+
\subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Feature bits}
\begin{description}
\item[VIRTIO_BALLOON_F_MUST_TELL_HOST (0)] Host has to be told before
@@ -5029,6 +5032,8 @@ \subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Featu
\item[ VIRTIO_BALLOON_F_PAGE_POISON(4) ] Host has to be notified if guest
is expecting reported pages to contain a certain value when returned.
Configuration field poison_val is valid.
+\item[ VIRTIO_BALLOON_F_PAGE_REPORTING(5) ] Device has support for free
+ page reporting. A virtqueue for reporting free guest memory is present.
\end{description}
@@ -5039,6 +5044,10 @@ \subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Featu
The driver SHOULD clear the VIRTIO_BALLOON_F_PAGE_POISON flag if it is not
expecting any specific value to be stored in the page.
+The driver MUST NOT accept VIRTIO_BALLOON_F_PAGE_REPORTING if it is expecting
+the pages to retain some initialized value and it has not negotiated
+VIRTIO_BALLOON_F_PAGE_POISON as a feature.
+
\devicenormative{\subsubsection}{Feature bits}{Device Types / Memory Balloon Device / Feature bits}
If the device offers the VIRTIO_BALLOON_F_MUST_TELL_HOST feature
bit, and if the driver did not accept this feature bit, the
@@ -5097,6 +5106,13 @@ \subsection{Device Initialization}\label{sec:Device Types / Memory Balloon Devic
\item If the VIRTIO_BALLOON_F_PAGE_POISON feature bit is negotiated then
the driver MUST update the poison_val configuration field.
+
+\item If the VIRTIO_BALLOON_F_PAGE_REPORTING feature bit is negotiated:
+ \begin{enumerate}
+ \item Identify the reporting virtqueue.
+ \item DRIVER_OK is set: device operation begins.
+ \item Begin reporting free pages to device.
+ \end{enumerate}
\end{enumerate}
\subsection{Device Operation}\label{sec:Device Types / Memory Balloon Device / Device Operation}
@@ -5497,6 +5513,64 @@ \subsubsection{Page Poison}\label{sec:Device Types / Memory Balloon Device / Dev
free page hinting as this feature did not exist prior to those features being
added.
+\subsubsection{Free Page Reporting}\label{sec:Device Types / Memory Balloon Device / Device Operation / Free Page Reporting}
+
+Free Page Reporting provides a mechanism similar to balloon inflation,
+however it does not provide a deflation queue. The expectation is that the
+device will have a means by which it can detect the guest page access and
+fault in such pages with some initial value, likely a zero page.
+
+The driver will respond to to memory conditions and begin reporting free
+pages when some number of pages are available.
+
+\begin{enumerate}
+
+\item The driver determines it has enough pages available to begin
+ reporting pages.
+
+\item The driver gathers pages into a scatter-gather list and adds them to
+ the reporting_vq.
+
+\item The device acknowledges the reporting request.
+
+\item Once the device has acknowledged the report, the pages can be
+ returned to the location from which they were pulled.
+
+\item The driver can then continue to gather and report pages until it
+ has determined it has reported a suffcient quantity of pages.
+
+\end{enumerate}
+
+\drivernormative{\paragraph}{Free Page Reporting}{Device Types / Memory Balloon Device / Device Operation / Free Page Reporting}
+
+Normative statements in this section apply if and only if the
+VIRTIO_BALLOON_F_PAGE_REPORTING feature has been negotiated.
+
+If the guest is expecting the free page to contain some initial value it
+MUST make use of the VIRTIO_BALLOON_F_PAGE_POISON feature to notify the
+device of this expectation via \field{poison_val}.
+
+The driver MUST NOT use the reported pages until the device has
+acknowledged the reporting request.
+
+The driver MAY report free pages any time after DRIVER_OK is set.
+
+It is RECOMMENDED that the driver avoid unecessary reads or writes to the
+page contents as this could reduce the performance for free page reporting.
+
+\devicenormative{\paragraph}{Free Page Reporting}{Device Types / Memory Balloon Device / Device Operation / Free Page Reporting}
+
+Normative statements in this section apply if and only if the
+VIRTIO_BALLOON_F_PAGE_REPORTING feature has been negotiated.
+
+The device MAY modify the contents of a page in the report after detecting
+its physical number in an report request and before acknowledging the
+reporting request by using the reporting_vq descriptor.
+
+If the VIRTIO_BALLOON_F_PAGE_POISON feature is negotiated, the device
+SHALL NOT modify the the page if this will result in the page containing a
+value other than \field{poison_val}.
+
\section{SCSI Host Device}\label{sec:Device Types / SCSI Host Device}
The virtio SCSI host device groups together one or more virtual
^ permalink raw reply related [flat|nested] 4+ messages in thread