From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to status
Date: Wed, 29 Apr 2020 19:54:02 +0000 [thread overview]
Message-ID: <20200429195402.GS2014@kadam> (raw)
In-Reply-To: <20200429154055.286617-1-colin.king@canonical.com>
On Wed, Apr 29, 2020 at 04:40:55PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable status is being assigned with a value that is never read
> hence the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Better to remove the "status" variable entirely.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to status
Date: Wed, 29 Apr 2020 22:54:02 +0300 [thread overview]
Message-ID: <20200429195402.GS2014@kadam> (raw)
In-Reply-To: <20200429154055.286617-1-colin.king@canonical.com>
On Wed, Apr 29, 2020 at 04:40:55PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable status is being assigned with a value that is never read
> hence the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Better to remove the "status" variable entirely.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-29 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 15:40 [PATCH] scsi: pm80xx: remove redundant assignments to status Colin King
2020-04-29 15:40 ` Colin King
2020-04-29 19:54 ` Dan Carpenter [this message]
2020-04-29 19:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429195402.GS2014@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.