All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michael Tretter <m.tretter@pengutronix.de>
Cc: devicetree@vger.kernel.org, Dhaval Shah <dshah@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Michael Tretter <m.tretter@pengutronix.de>,
	kernel@pengutronix.de,
	Rohit Visavalia <rohit.visavalia@xilinx.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/6] dt-bindings: soc: xlnx: extract xlnx, vcu-settings to separate binding
Date: Wed, 29 Apr 2020 16:36:59 -0500	[thread overview]
Message-ID: <20200429213659.GA9051@bogus> (raw)
In-Reply-To: <20200417070526.7178-5-m.tretter@pengutronix.de>

On Fri, 17 Apr 2020 09:05:24 +0200, Michael Tretter wrote:
> The xlnx,vcu binding comprises two adjacent register banks:
> 
> The first register bank ("vcu_slcr") contains registers for setting the
> clocks of the vcu and controlling the performance monitors. The second
> bank ("logicoreip") contains the configuration settings of the video codec
> unit, which are set before synthesizing the bitstream.
> 
> Drivers that drive the actual video codec unit need to to read the
> registers from the logicoreip register bank for configuring the vcu
> firmware.
> 
> As logicoreip is a too generic name for this register bank, use
> "vcu-settings" as a binding name, because the register bank basically
> provides the configuration settings of the VCU.
> 
> Therefore, add the vcu-settings binding to provide a syscon interface
> for other drivers to read these registers.
> 
> The alternative would have been to merge the two register banks of the
> xlnx,vcu binding into one register bank and make xlnx,vcu provide a
> syscon interface, but that would lead to more incompatibility than
> making second register bank of xlnx,vcu optional.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> Changelog:
> 
> v2 -> v3:
> - none
> 
> v1 -> v2:
> - drop custom select for syscon
> ---
>  .../soc/xilinx/xlnx,vcu-settings.yaml         | 34 +++++++++++++++++++
>  .../bindings/soc/xilinx/xlnx,vcu.txt          |  9 ++---
>  2 files changed, 36 insertions(+), 7 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Michael Tretter <m.tretter@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Rohit Visavalia <rohit.visavalia@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Dhaval Shah <dshah@xilinx.com>,
	kernel@pengutronix.de, Michael Tretter <m.tretter@pengutronix.de>
Subject: Re: [PATCH v3 4/6] dt-bindings: soc: xlnx: extract xlnx,vcu-settings to separate binding
Date: Wed, 29 Apr 2020 16:36:59 -0500	[thread overview]
Message-ID: <20200429213659.GA9051@bogus> (raw)
In-Reply-To: <20200417070526.7178-5-m.tretter@pengutronix.de>

On Fri, 17 Apr 2020 09:05:24 +0200, Michael Tretter wrote:
> The xlnx,vcu binding comprises two adjacent register banks:
> 
> The first register bank ("vcu_slcr") contains registers for setting the
> clocks of the vcu and controlling the performance monitors. The second
> bank ("logicoreip") contains the configuration settings of the video codec
> unit, which are set before synthesizing the bitstream.
> 
> Drivers that drive the actual video codec unit need to to read the
> registers from the logicoreip register bank for configuring the vcu
> firmware.
> 
> As logicoreip is a too generic name for this register bank, use
> "vcu-settings" as a binding name, because the register bank basically
> provides the configuration settings of the VCU.
> 
> Therefore, add the vcu-settings binding to provide a syscon interface
> for other drivers to read these registers.
> 
> The alternative would have been to merge the two register banks of the
> xlnx,vcu binding into one register bank and make xlnx,vcu provide a
> syscon interface, but that would lead to more incompatibility than
> making second register bank of xlnx,vcu optional.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> Changelog:
> 
> v2 -> v3:
> - none
> 
> v1 -> v2:
> - drop custom select for syscon
> ---
>  .../soc/xilinx/xlnx,vcu-settings.yaml         | 34 +++++++++++++++++++
>  .../bindings/soc/xilinx/xlnx,vcu.txt          |  9 ++---
>  2 files changed, 36 insertions(+), 7 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2020-04-29 21:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17  7:05 [PATCH v3 0/6] soc: xilinx: vcu: provide interfaces for other drivers Michael Tretter
2020-04-17  7:05 ` Michael Tretter
2020-04-17  7:05 ` [PATCH v3 1/6] soc: xilinx: vcu: drop useless success message Michael Tretter
2020-04-17  7:05   ` Michael Tretter
2020-04-17  7:05 ` [PATCH v3 2/6] ARM: dts: define indexes for output clocks Michael Tretter
2020-04-17  7:05   ` Michael Tretter
2020-04-29 21:36   ` Rob Herring
2020-04-29 21:36     ` Rob Herring
2020-04-17  7:05 ` [PATCH v3 3/6] soc: xilinx: vcu: implement clock provider " Michael Tretter
2020-04-17  7:05   ` Michael Tretter
2020-04-17  7:05 ` [PATCH v3 4/6] dt-bindings: soc: xlnx: extract xlnx, vcu-settings to separate binding Michael Tretter
2020-04-17  7:05   ` [PATCH v3 4/6] dt-bindings: soc: xlnx: extract xlnx,vcu-settings " Michael Tretter
2020-04-29 21:36   ` Rob Herring [this message]
2020-04-29 21:36     ` Rob Herring
2020-04-17  7:05 ` [PATCH v3 5/6] soc: xilinx: vcu: use vcu-settings syscon registers Michael Tretter
2020-04-17  7:05   ` Michael Tretter
2020-04-17  7:05 ` [PATCH v3 6/6] soc: xilinx: vcu: add missing register NUM_CORE Michael Tretter
2020-04-17  7:05   ` Michael Tretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429213659.GA9051@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dshah@xilinx.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=m.tretter@pengutronix.de \
    --cc=michal.simek@xilinx.com \
    --cc=rohit.visavalia@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.