From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
stable@vger.kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: xilinx_uartps: Add the id to the console
Date: Thu, 30 Apr 2020 10:49:15 +0200 [thread overview]
Message-ID: <20200430084915.GD2496467@kroah.com> (raw)
In-Reply-To: <06195dc0effe2fb82e264e4faefcfdd6ebc00516.1588234277.git.michal.simek@xilinx.com>
On Thu, Apr 30, 2020 at 10:11:21AM +0200, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> Update the console index. Once the serial node is found update it to the
> console index.
>
> Fixes: 18cc7ac8a28e ("Revert "serial: uartps: Register own uart console and driver structures"")
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Greg: Would be good if you can take this patch to 5.7 and also to stable
> trees.
WHy? I don't understand what bug this fixes/resolves, please be much
more descriptive in your changelog text showing this if you wish for it
to be backported to a stable tree. As it is, this just looks like you
are adding a new feature.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: monstr@monstr.eu,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
git@xilinx.com, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: xilinx_uartps: Add the id to the console
Date: Thu, 30 Apr 2020 10:49:15 +0200 [thread overview]
Message-ID: <20200430084915.GD2496467@kroah.com> (raw)
In-Reply-To: <06195dc0effe2fb82e264e4faefcfdd6ebc00516.1588234277.git.michal.simek@xilinx.com>
On Thu, Apr 30, 2020 at 10:11:21AM +0200, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> Update the console index. Once the serial node is found update it to the
> console index.
>
> Fixes: 18cc7ac8a28e ("Revert "serial: uartps: Register own uart console and driver structures"")
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Greg: Would be good if you can take this patch to 5.7 and also to stable
> trees.
WHy? I don't understand what bug this fixes/resolves, please be much
more descriptive in your changelog text showing this if you wish for it
to be backported to a stable tree. As it is, this just looks like you
are adding a new feature.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-30 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 8:11 [PATCH] tty: xilinx_uartps: Add the id to the console Michal Simek
2020-04-30 8:11 ` Michal Simek
2020-04-30 8:49 ` Greg Kroah-Hartman [this message]
2020-04-30 8:49 ` Greg Kroah-Hartman
2020-04-30 9:02 ` Michal Simek
2020-04-30 9:02 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430084915.GD2496467@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=git@xilinx.com \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.