From: Wolfram Sang <wsa@the-dreams.de>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition.
Date: Thu, 30 Apr 2020 16:17:01 +0200 [thread overview]
Message-ID: <20200430141701.GC3355@ninjato> (raw)
In-Reply-To: <20200429033737.2781-1-ryan_chen@aspeedtech.com>
On Wed, Apr 29, 2020 at 11:37:37AM +0800, ryan_chen wrote:
> In AST2600 there have a slow peripheral bus between CPU
> and i2c controller.
> Therefore GIC i2c interrupt status clear have delay timing,
> when CPU issue write clear i2c controller interrupt status.
> To avoid this issue, the driver need have read after write
> clear at i2c ISR.
>
> Signed-off-by: ryan_chen <ryan_chen@aspeedtech.com>
Applied to for-current with a Fixes tag, thanks! Please, try to add one
next time and please also check how the subsystem formats the $subject
line.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20200430/f27edc1e/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: ryan_chen <ryan_chen@aspeedtech.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition.
Date: Thu, 30 Apr 2020 16:17:01 +0200 [thread overview]
Message-ID: <20200430141701.GC3355@ninjato> (raw)
In-Reply-To: <20200429033737.2781-1-ryan_chen@aspeedtech.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Wed, Apr 29, 2020 at 11:37:37AM +0800, ryan_chen wrote:
> In AST2600 there have a slow peripheral bus between CPU
> and i2c controller.
> Therefore GIC i2c interrupt status clear have delay timing,
> when CPU issue write clear i2c controller interrupt status.
> To avoid this issue, the driver need have read after write
> clear at i2c ISR.
>
> Signed-off-by: ryan_chen <ryan_chen@aspeedtech.com>
Applied to for-current with a Fixes tag, thanks! Please, try to add one
next time and please also check how the subsystem formats the $subject
line.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: ryan_chen <ryan_chen@aspeedtech.com>
Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
openbmc@lists.ozlabs.org,
Brendan Higgins <brendanhiggins@google.com>,
linux-kernel@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition.
Date: Thu, 30 Apr 2020 16:17:01 +0200 [thread overview]
Message-ID: <20200430141701.GC3355@ninjato> (raw)
In-Reply-To: <20200429033737.2781-1-ryan_chen@aspeedtech.com>
[-- Attachment #1.1: Type: text/plain, Size: 568 bytes --]
On Wed, Apr 29, 2020 at 11:37:37AM +0800, ryan_chen wrote:
> In AST2600 there have a slow peripheral bus between CPU
> and i2c controller.
> Therefore GIC i2c interrupt status clear have delay timing,
> when CPU issue write clear i2c controller interrupt status.
> To avoid this issue, the driver need have read after write
> clear at i2c ISR.
>
> Signed-off-by: ryan_chen <ryan_chen@aspeedtech.com>
Applied to for-current with a Fixes tag, thanks! Please, try to add one
next time and please also check how the subsystem formats the $subject
line.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-30 14:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 3:37 [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition ryan_chen
2020-04-29 3:37 ` ryan_chen
2020-04-29 3:37 ` ryan_chen
2020-04-29 7:53 ` Wolfram Sang
2020-04-29 7:53 ` Wolfram Sang
2020-04-29 7:53 ` Wolfram Sang
2020-04-29 8:12 ` Ryan Chen
2020-04-29 8:12 ` Ryan Chen
2020-04-29 8:12 ` Ryan Chen
2020-04-29 9:03 ` Wolfram Sang
2020-04-29 9:03 ` Wolfram Sang
2020-04-29 9:03 ` Wolfram Sang
2020-04-30 10:55 ` Benjamin Herrenschmidt
2020-04-30 10:55 ` Benjamin Herrenschmidt
2020-04-30 10:55 ` Benjamin Herrenschmidt
2020-05-05 1:52 ` Ryan Chen
2020-05-05 1:52 ` Ryan Chen
2020-05-05 1:52 ` Ryan Chen
2020-04-30 10:52 ` Benjamin Herrenschmidt
2020-04-30 10:52 ` Benjamin Herrenschmidt
2020-04-30 10:52 ` Benjamin Herrenschmidt
2020-04-30 14:17 ` Wolfram Sang [this message]
2020-04-30 14:17 ` Wolfram Sang
2020-04-30 14:17 ` Wolfram Sang
2020-05-05 1:51 ` Ryan Chen
2020-05-05 1:51 ` Ryan Chen
2020-05-05 1:51 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430141701.GC3355@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.