All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	"bridge@lists.linux-foundation.org"
	<bridge@lists.linux-foundation.org>,
	davem@davemloft.net,
	Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Subject: Re: [Bridge] BUG: soft lockup while deleting tap interface from vlan aware bridge
Date: Thu, 30 Apr 2020 18:56:45 +0300	[thread overview]
Message-ID: <20200430155645.GA4076599@splinter> (raw)
In-Reply-To: <4b3a6079-d8d4-24c5-8fc9-15bcb96bca80@cumulusnetworks.com>

On Thu, Apr 30, 2020 at 02:20:23PM +0300, Nikolay Aleksandrov wrote:
> Maybe we can batch the deletes at say 32 at a time?

Hi Nik,

Thanks for looking into this!

I don't really feel comfortable hard coding an arbitrary number of
entries before calling cond_resched(). I didn't see a noticeable
difference in execution time with the previous patch versus an unpatched
kernel. Also, in the examples I saw in the networking code
cond_resched() is always called after each loop iteration.

Let me know how you prefer it and I will send a patch.

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>,
	roopa@cumulusnetworks.com, davem@davemloft.net,
	"bridge@lists.linux-foundation.org" 
	<bridge@lists.linux-foundation.org>,
	netdev@vger.kernel.org
Subject: Re: BUG: soft lockup while deleting tap interface from vlan aware bridge
Date: Thu, 30 Apr 2020 18:56:45 +0300	[thread overview]
Message-ID: <20200430155645.GA4076599@splinter> (raw)
In-Reply-To: <4b3a6079-d8d4-24c5-8fc9-15bcb96bca80@cumulusnetworks.com>

On Thu, Apr 30, 2020 at 02:20:23PM +0300, Nikolay Aleksandrov wrote:
> Maybe we can batch the deletes at say 32 at a time?

Hi Nik,

Thanks for looking into this!

I don't really feel comfortable hard coding an arbitrary number of
entries before calling cond_resched(). I didn't see a noticeable
difference in execution time with the previous patch versus an unpatched
kernel. Also, in the examples I saw in the networking code
cond_resched() is always called after each loop iteration.

Let me know how you prefer it and I will send a patch.

  reply	other threads:[~2020-04-30 15:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 20:52 BUG: soft lockup while deleting tap interface from vlan aware bridge Stefan Priebe - Profihost AG
2020-04-29 21:23 ` [Bridge] " Nikolay Aleksandrov
2020-04-29 21:23   ` Nikolay Aleksandrov
2020-04-30  6:47   ` Stefan Priebe - Profihost AG
2020-04-30 10:55 ` [Bridge] " Ido Schimmel
2020-04-30 10:55   ` Ido Schimmel
2020-04-30 11:20   ` [Bridge] " Nikolay Aleksandrov
2020-04-30 11:20     ` Nikolay Aleksandrov
2020-04-30 15:56     ` Ido Schimmel [this message]
2020-04-30 15:56       ` Ido Schimmel
2020-04-30 15:57       ` [Bridge] " Nikolay Aleksandrov
2020-04-30 15:57         ` Nikolay Aleksandrov
2020-04-30 13:18   ` Stefan Priebe - Profihost AG
2020-04-30 15:57     ` [Bridge] " Ido Schimmel
2020-04-30 15:57       ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430155645.GA4076599@splinter \
    --to=idosch@idosch.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=s.priebe@profihost.ag \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.