From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH 1/3] nvme-pci: clear shadow doorbell memory on resets
Date: Fri, 1 May 2020 14:49:29 +0200 [thread overview]
Message-ID: <20200501124929.GA5197@lst.de> (raw)
In-Reply-To: <20200427235243.2268765-1-kbusch@kernel.org>
On Mon, Apr 27, 2020 at 04:52:41PM -0700, Keith Busch wrote:
> The host memory doorbell and event buffers need to be initialized on
> each reset so the driver doesn't observe stale values from the previous
> instantiation.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> drivers/nvme/host/pci.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index cf386c84588b..d388fff9c358 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -228,8 +228,11 @@ static int nvme_dbbuf_dma_alloc(struct nvme_dev *dev)
> {
> unsigned int mem_size = nvme_dbbuf_size(dev->db_stride);
>
> - if (dev->dbbuf_dbs)
> + if (dev->dbbuf_dbs) {
> + memset(dev->dbbuf_dbs, 0, mem_size);
> + memset(dev->dbbuf_eis, 0, mem_size);
> return 0;
Can you throw in a comment why the memory is cleared?
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-05-01 12:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 23:52 [PATCH 1/3] nvme-pci: clear shadow doorbell memory on resets Keith Busch
2020-04-27 23:52 ` [PATCH 2/3] nvme-pci: remove cached shadow doorbell offsets Keith Busch
2020-04-30 6:36 ` Dongli Zhang
2020-04-30 19:07 ` Keith Busch
2020-05-01 12:54 ` Christoph Hellwig
2021-10-04 9:42 ` John Levon
2020-04-27 23:52 ` [PATCH 3/3] nvme-pci: reshuffle nvme_queue members Keith Busch
2020-05-01 12:57 ` Christoph Hellwig
2020-05-01 15:08 ` Keith Busch
2020-05-01 15:12 ` Christoph Hellwig
2020-05-01 15:23 ` Keith Busch
2020-05-04 18:18 ` Keith Busch
2020-05-01 12:49 ` Christoph Hellwig [this message]
2021-10-04 9:35 ` [PATCH 1/3] nvme-pci: clear shadow doorbell memory on resets John Levon
2021-10-06 12:07 ` Keith Busch
2021-10-06 16:05 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501124929.GA5197@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.