From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Walter Harms <wharms@bfs.de>
Cc: Colin King <colin.king@canonical.com>,
Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: sja1105: fix speed setting for 10 MBPS
Date: Fri, 01 May 2020 18:37:03 +0000 [thread overview]
Message-ID: <20200501183703.GS1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <9018be0b7dc441cd8aad625c6cc44e1c@bfs.de>
On Fri, May 01, 2020 at 06:00:52PM +0000, Walter Harms wrote:
> IMHO it would be better to use switch case here to improve readability.
>
> switch (bmcr & mask) {
>
> case BMCR_SPEED1000:
> speed = SPEED_1000;
> break;
> case BMCR_SPEED100:
> speed = SPEED_100;
> break;
> case BMCR_SPEED10:
> speed = SPEED_10;
> break;
> default:
> speed = SPEED_UNKNOWN
> }
>
> jm2c,
> wh
>
> btw: an_enabled ? why not !enabled, mich more easy to read
You misinterpret "an_enabled". It's not "negated enabled". It's not
even "disabled". It's short for "autonegotiation enabled". It's
positive logic too.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Walter Harms <wharms@bfs.de>
Cc: Colin King <colin.king@canonical.com>,
Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: sja1105: fix speed setting for 10 MBPS
Date: Fri, 1 May 2020 19:37:03 +0100 [thread overview]
Message-ID: <20200501183703.GS1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <9018be0b7dc441cd8aad625c6cc44e1c@bfs.de>
On Fri, May 01, 2020 at 06:00:52PM +0000, Walter Harms wrote:
> IMHO it would be better to use switch case here to improve readability.
>
> switch (bmcr & mask) {
>
> case BMCR_SPEED1000:
> speed = SPEED_1000;
> break;
> case BMCR_SPEED100:
> speed = SPEED_100;
> break;
> case BMCR_SPEED10:
> speed = SPEED_10;
> break;
> default:
> speed = SPEED_UNKNOWN
> }
>
> jm2c,
> wh
>
> btw: an_enabled ? why not !enabled, mich more easy to read
You misinterpret "an_enabled". It's not "negated enabled". It's not
even "disabled". It's short for "autonegotiation enabled". It's
positive logic too.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next prev parent reply other threads:[~2020-05-01 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 13:43 [PATCH] net: dsa: sja1105: fix speed setting for 10 MBPS Colin King
2020-05-01 13:43 ` Colin King
2020-05-01 18:00 ` AW: " Walter Harms
2020-05-01 18:00 ` Walter Harms
2020-05-01 18:37 ` Russell King - ARM Linux admin [this message]
2020-05-01 18:37 ` Russell King - ARM Linux admin
2020-05-02 12:21 ` Sergei Shtylyov
2020-05-02 12:21 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501183703.GS1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.