All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Priit Laes <plaes@plaes.org>
Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-sunxi@googlegroups.com, Priit Laes <plaes@plaes.org>
Subject: Re: [PATCH v3 4/6] dt-bindings: net: sun7i-gmac: Add syscon support
Date: Fri, 1 May 2020 16:12:24 -0500	[thread overview]
Message-ID: <20200501211224.GA2673@bogus> (raw)
In-Reply-To: <20200430115702.5768-5-plaes@plaes.org>

On Thu, 30 Apr 2020 14:57:00 +0300, Priit Laes wrote:
> Now that driver supports syscon-based regmap access, document also the
> devicetree binding.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
>  .../bindings/net/allwinner,sun7i-a20-gmac.yaml    | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.example.dt.yaml: ethernet@1c50000: clock-names: ['stmmaceth'] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.example.dt.yaml: ethernet@1c50000: clocks: [[4294967295, 49]] is too short

See https://patchwork.ozlabs.org/patch/1280292

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Priit Laes <plaes@plaes.org>
Cc: devicetree@vger.kernel.org, Priit Laes <plaes@plaes.org>,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/6] dt-bindings: net: sun7i-gmac: Add syscon support
Date: Fri, 1 May 2020 16:12:24 -0500	[thread overview]
Message-ID: <20200501211224.GA2673@bogus> (raw)
In-Reply-To: <20200430115702.5768-5-plaes@plaes.org>

On Thu, 30 Apr 2020 14:57:00 +0300, Priit Laes wrote:
> Now that driver supports syscon-based regmap access, document also the
> devicetree binding.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
>  .../bindings/net/allwinner,sun7i-a20-gmac.yaml    | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.example.dt.yaml: ethernet@1c50000: clock-names: ['stmmaceth'] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.example.dt.yaml: ethernet@1c50000: clocks: [[4294967295, 49]] is too short

See https://patchwork.ozlabs.org/patch/1280292

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-01 21:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 11:56 [PATCH v2 0/6] ARM: sunxi: Clean up sun7i-a20-gmac-clk usage Priit Laes
2020-04-30 11:56 ` Priit Laes
2020-04-30 11:56 ` [PATCH v3 1/6] clk: sunxi-ng: a20: Register regmap for sun7i CCU Priit Laes
2020-04-30 11:56   ` Priit Laes
2020-04-30 14:51   ` Maxime Ripard
2020-04-30 14:51     ` Maxime Ripard
2020-04-30 11:56 ` [PATCH v3 2/6] clk: sunxi-ng: a31: Register regmap for sun6i CCU Priit Laes
2020-04-30 11:56   ` Priit Laes
2020-04-30 11:56 ` [PATCH v3 3/6] net: stmmac: dwmac-sunxi: Implement syscon-based clock handling Priit Laes
2020-04-30 11:56   ` Priit Laes
2020-04-30 14:58   ` Maxime Ripard
2020-04-30 14:58     ` Maxime Ripard
2020-04-30 11:57 ` [PATCH v3 4/6] dt-bindings: net: sun7i-gmac: Add syscon support Priit Laes
2020-04-30 11:57   ` Priit Laes
2020-04-30 15:00   ` Maxime Ripard
2020-04-30 15:00     ` Maxime Ripard
2020-05-01 21:12   ` Rob Herring [this message]
2020-05-01 21:12     ` Rob Herring
2020-04-30 11:57 ` [PATCH v3 5/6] ARM: dts: sun7i: Use syscon-based implementation for gmac Priit Laes
2020-04-30 11:57   ` Priit Laes
2020-04-30 11:57 ` [PATCH v3 6/6] ARM: dts: sun6i: " Priit Laes
2020-04-30 11:57   ` Priit Laes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501211224.GA2673@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=plaes@plaes.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.