All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Qian Cai <cai@lca.pw>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] iommu/amd: fix a race in fetch_pte()
Date: Sun, 3 May 2020 20:39:27 +0200	[thread overview]
Message-ID: <20200503183927.GA18353@8bytes.org> (raw)
In-Reply-To: <E351FE35-3130-48B0-90ED-BC55469C73F7@lca.pw>

Hi Qian,

On Sun, May 03, 2020 at 09:04:03AM -0400, Qian Cai wrote:
> > On Apr 29, 2020, at 7:20 AM, Joerg Roedel <joro@8bytes.org> wrote:
> > Can you please test this branch:
> > 
> > 	https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=amd-iommu-fixes
> > 
> > It has the previous fix in it and a couple more to make sure the
> > device-table is updated and flushed before increase_address_space()
> > updates domain->pt_root.
> 
> I believe this closed the existing races as it had survived for many
> days. Great work!

Thanks a lot for testing these changes! Can I add your Tested-by when I
send them to the mailing list tomorrow?

Regards,

	Joerg

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Qian Cai <cai@lca.pw>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] iommu/amd: fix a race in fetch_pte()
Date: Sun, 3 May 2020 20:39:27 +0200	[thread overview]
Message-ID: <20200503183927.GA18353@8bytes.org> (raw)
In-Reply-To: <E351FE35-3130-48B0-90ED-BC55469C73F7@lca.pw>

Hi Qian,

On Sun, May 03, 2020 at 09:04:03AM -0400, Qian Cai wrote:
> > On Apr 29, 2020, at 7:20 AM, Joerg Roedel <joro@8bytes.org> wrote:
> > Can you please test this branch:
> > 
> > 	https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=amd-iommu-fixes
> > 
> > It has the previous fix in it and a couple more to make sure the
> > device-table is updated and flushed before increase_address_space()
> > updates domain->pt_root.
> 
> I believe this closed the existing races as it had survived for many
> days. Great work!

Thanks a lot for testing these changes! Can I add your Tested-by when I
send them to the mailing list tomorrow?

Regards,

	Joerg


  reply	other threads:[~2020-05-03 18:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  2:12 [RFC PATCH] iommu/amd: fix a race in fetch_pte() Qian Cai
2020-04-07  2:12 ` Qian Cai
2020-04-07 15:36 ` Qian Cai
2020-04-07 15:36   ` Qian Cai
2020-04-08 14:19   ` Joerg Roedel
2020-04-08 14:19     ` Joerg Roedel
2020-04-14  1:36     ` Qian Cai
2020-04-14  1:36       ` Qian Cai
2020-04-17  1:42       ` Qian Cai
2020-04-17  1:42         ` Qian Cai
2020-04-18 12:10         ` Joerg Roedel
2020-04-18 12:10           ` Joerg Roedel
2020-04-18 13:01           ` Qian Cai
2020-04-18 13:01             ` Qian Cai
2020-04-18 18:34             ` Joerg Roedel
2020-04-18 18:34               ` Joerg Roedel
2020-04-20  2:07               ` Qian Cai
2020-04-20  2:07                 ` Qian Cai
2020-04-20 13:26               ` Qian Cai
2020-04-20 13:26                 ` Qian Cai
2020-04-29  8:47                 ` Joerg Roedel
2020-04-29  8:47                   ` Joerg Roedel
2020-04-29 11:20                 ` Joerg Roedel
2020-04-29 11:20                   ` Joerg Roedel
2020-04-30  1:04                   ` Qian Cai
2020-04-30  1:04                     ` Qian Cai
2020-05-03 13:04                   ` Qian Cai
2020-05-03 13:04                     ` Qian Cai
2020-05-03 18:39                     ` Joerg Roedel [this message]
2020-05-03 18:39                       ` Joerg Roedel
2020-05-03 19:12                       ` Qian Cai
2020-05-03 19:12                         ` Qian Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200503183927.GA18353@8bytes.org \
    --to=joro@8bytes.org \
    --cc=cai@lca.pw \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.