All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libsepol/tests: drop ncurses dependency
@ 2020-05-01  9:23 Nicolas Iooss
  2020-05-01 13:58 ` James Carter
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2020-05-01  9:23 UTC (permalink / raw)
  To: selinux

ncurses library is not used anywhere.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
---
 .travis.yml             | 1 -
 libsepol/tests/Makefile | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 918958acfc80..4361d26cbb83 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -53,7 +53,6 @@ addons:
     - libcap-ng-dev # This package is not whitelisted for the container infrastructure (https://github.com/travis-ci/apt-package-whitelist/issues/1096)
     - libcunit1-dev
     - libdbus-glib-1-dev
-    - libncurses5-dev
     - libpcre3-dev
     - patch
     - python3-dev
diff --git a/libsepol/tests/Makefile b/libsepol/tests/Makefile
index e7e305e8150b..fc9bd1a303be 100644
--- a/libsepol/tests/Makefile
+++ b/libsepol/tests/Makefile
@@ -32,7 +32,7 @@ all: $(EXE) $(policies)
 policies: $(policies)
 
 $(EXE): $(objs) $(parserobjs) $(LIBSEPOL)
-	$(CC) $(LDFLAGS) $(objs) $(parserobjs) -lcunit -lcurses $(LIBSEPOL) -o $@
+	$(CC) $(LDFLAGS) $(objs) $(parserobjs) -lcunit $(LIBSEPOL) -o $@
 
 %.conf.std: $(m4support) %.conf
 	$(M4) $(M4PARAMS) $^ > $@
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] libsepol/tests: drop ncurses dependency
  2020-05-01  9:23 [PATCH] libsepol/tests: drop ncurses dependency Nicolas Iooss
@ 2020-05-01 13:58 ` James Carter
  2020-05-04  8:48   ` Petr Lautrbach
  0 siblings, 1 reply; 3+ messages in thread
From: James Carter @ 2020-05-01 13:58 UTC (permalink / raw)
  To: Nicolas Iooss; +Cc: SElinux list

On Fri, May 1, 2020 at 5:25 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> ncurses library is not used anywhere.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>

Acked-by: James Carter <jwcart2@gmail.com>


> ---
>  .travis.yml             | 1 -
>  libsepol/tests/Makefile | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 918958acfc80..4361d26cbb83 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -53,7 +53,6 @@ addons:
>      - libcap-ng-dev # This package is not whitelisted for the container infrastructure (https://github.com/travis-ci/apt-package-whitelist/issues/1096)
>      - libcunit1-dev
>      - libdbus-glib-1-dev
> -    - libncurses5-dev
>      - libpcre3-dev
>      - patch
>      - python3-dev
> diff --git a/libsepol/tests/Makefile b/libsepol/tests/Makefile
> index e7e305e8150b..fc9bd1a303be 100644
> --- a/libsepol/tests/Makefile
> +++ b/libsepol/tests/Makefile
> @@ -32,7 +32,7 @@ all: $(EXE) $(policies)
>  policies: $(policies)
>
>  $(EXE): $(objs) $(parserobjs) $(LIBSEPOL)
> -       $(CC) $(LDFLAGS) $(objs) $(parserobjs) -lcunit -lcurses $(LIBSEPOL) -o $@
> +       $(CC) $(LDFLAGS) $(objs) $(parserobjs) -lcunit $(LIBSEPOL) -o $@
>
>  %.conf.std: $(m4support) %.conf
>         $(M4) $(M4PARAMS) $^ > $@
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libsepol/tests: drop ncurses dependency
  2020-05-01 13:58 ` James Carter
@ 2020-05-04  8:48   ` Petr Lautrbach
  0 siblings, 0 replies; 3+ messages in thread
From: Petr Lautrbach @ 2020-05-04  8:48 UTC (permalink / raw)
  To: SElinux list; +Cc: Nicolas Iooss, James Carter

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

On Fri, May 01, 2020 at 09:58:12AM -0400, James Carter wrote:
> On Fri, May 1, 2020 at 5:25 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
> >
> > ncurses library is not used anywhere.
> >
> > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> 
> Acked-by: James Carter <jwcart2@gmail.com>

Applied.

> 
> > ---
> >  .travis.yml             | 1 -
> >  libsepol/tests/Makefile | 2 +-
> >  2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 918958acfc80..4361d26cbb83 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -53,7 +53,6 @@ addons:
> >      - libcap-ng-dev # This package is not whitelisted for the container infrastructure (https://github.com/travis-ci/apt-package-whitelist/issues/1096)
> >      - libcunit1-dev
> >      - libdbus-glib-1-dev
> > -    - libncurses5-dev
> >      - libpcre3-dev
> >      - patch
> >      - python3-dev
> > diff --git a/libsepol/tests/Makefile b/libsepol/tests/Makefile
> > index e7e305e8150b..fc9bd1a303be 100644
> > --- a/libsepol/tests/Makefile
> > +++ b/libsepol/tests/Makefile
> > @@ -32,7 +32,7 @@ all: $(EXE) $(policies)
> >  policies: $(policies)
> >
> >  $(EXE): $(objs) $(parserobjs) $(LIBSEPOL)
> > -       $(CC) $(LDFLAGS) $(objs) $(parserobjs) -lcunit -lcurses $(LIBSEPOL) -o $@
> > +       $(CC) $(LDFLAGS) $(objs) $(parserobjs) -lcunit $(LIBSEPOL) -o $@
> >
> >  %.conf.std: $(m4support) %.conf
> >         $(M4) $(M4PARAMS) $^ > $@
> > --
> > 2.26.2
> >
> 

-- 
()  ascii ribbon campaign - against html e-mail 
/\  www.asciiribbon.org   - against proprietary attachments

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-04  8:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-01  9:23 [PATCH] libsepol/tests: drop ncurses dependency Nicolas Iooss
2020-05-01 13:58 ` James Carter
2020-05-04  8:48   ` Petr Lautrbach

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.