Re: [PATCH v6] checkpatch: add support to check 'Fixes:' tag format

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Wang YanQing <udknight@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Matteo Croce <mcroce@redhat.com>
Subject: Re: [PATCH v6] checkpatch: add support to check 'Fixes:' tag format
Date: Mon, 04 May 2020 10:22:42 +0000	[thread overview]
Message-ID: <20200504102242.GA13013@udknight> (raw)
In-Reply-To: <38251b1f-e89b-7b3a-6045-f5ce1dc2596a@web.de>

On Mon, May 04, 2020 at 11:45:02AM +0200, Markus Elfring wrote:
> 
> >  4: Add support to check and emit sensible diagnostics
> >     info for description which spans across more than
> >     two lines.
> 
> My software concerns are growing also for the preferred dependency management.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id\x0e698dfa282211e414076f9dc7e83c1c288314fd#n138
>

Hi! Markus Elfring

This feature is a side effect of missing right '")' detection, so I think
it is acceptable to add it.

But I agree with you, this patch is a little big, I don't want to add more
code into it.

Joe, what is your opinion? Do you think this version is good enough to merge?

Thanks!

WARNING: multiple messages have this Message-ID (diff)

From: Wang YanQing <udknight@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Matteo Croce <mcroce@redhat.com>
Subject: Re: [PATCH v6] checkpatch: add support to check 'Fixes:' tag format
Date: Mon, 4 May 2020 18:22:42 +0800	[thread overview]
Message-ID: <20200504102242.GA13013@udknight> (raw)
In-Reply-To: <38251b1f-e89b-7b3a-6045-f5ce1dc2596a@web.de>

On Mon, May 04, 2020 at 11:45:02AM +0200, Markus Elfring wrote:
> 
> >  4: Add support to check and emit sensible diagnostics
> >     info for description which spans across more than
> >     two lines.
> 
> My software concerns are growing also for the preferred dependency management.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=0e698dfa282211e414076f9dc7e83c1c288314fd#n138
>

Hi! Markus Elfring

This feature is a side effect of missing right '")' detection, so I think
it is acceptable to add it.

But I agree with you, this patch is a little big, I don't want to add more
code into it.

Joe, what is your opinion? Do you think this version is good enough to merge?

Thanks!

next prev parent reply	other threads:[~2020-05-04 10:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04  8:20 [PATCH v6] checkpatch: add support to check 'Fixes:' tag format Wang YanQing
2020-05-04  8:20 ` Wang YanQing
2020-05-04  9:45 ` Markus Elfring
2020-05-04  9:45   ` Markus Elfring
2020-05-04 10:22   ` Wang YanQing [this message]
2020-05-04 10:22     ` Wang YanQing
2020-05-04 11:17     ` [v6] " Markus Elfring
2020-05-04 11:17       ` Markus Elfring
2020-05-04 18:34 ` [PATCH v6] " Joe Perches
2020-05-04 18:34   ` Joe Perches
2020-05-23  2:30   ` Wang YanQing
2020-05-23  2:30     ` Wang YanQing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200504102242.GA13013@udknight \
    --to=udknight@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=alexei.starovoitov@gmail.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcroce@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.