Re: [GIT PULL] Ressurect the atomisp staging driver

[Mauro Carvalho Chehab <mchehab@kernel.org>]

Em Mon, 4 May 2020 10:16:28 +0200
Patrik Gfeller <patrik.gfeller@gmail.com> escreveu:

> On Sun, 3 May 2020 18:07:51 +0200
> Patrik Gfeller <patrik.gfeller@gmail.com> wrote:
> 
> > On Sun, 3 May 2020 18:03:54 +0200
> > Francescodario Cuzzocrea <francescodario.cuzzocrea@mail.polimi.it> wrote:
> >   
> > > Il giorno dom 3 mag 2020 alle ore 17:32 Mauro Carvalho Chehab <      
> >  [...]    
> > > 
> > > Thanks a lot !!
> > >     
> >  [...]    
> > > According to my understarding mine which is baytrail should be  ISP2400    
> > 
> > I have ISP2401 (rev B) ... I'll give it a try :-) - thanks Mauro!  
> 
> I was not able yet to compile the kernel 4.4 successfully yet. 

Yesterday, I imported only a subset of the yocto patches. I imported today
all 24 patches from it, as some patches depend on hacks on other upstream
stuff. You'll need to do a:

	$ git remote update && git reset --hard origin/yocto_intel_atom

To update your local branch.

> I get quite
> some warnings that are treated as errors. I assume that I can "resolve"
> this by removing the respective compiler flag (-Werror).

Yeah, you may need to to that. There's a Kernel option with disables
-Werror. You may also change the Makefile to add things like:

	# HACK! While this driver is in bad shape, don't enable several warnings
	#       that would be otherwise enabled with W=1
	ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
	ccflags-y += $(call cc-disable-warning, missing-prototypes)
	ccflags-y += $(call cc-disable-warning, missing-declarations)
	ccflags-y += $(call cc-disable-warning, suggest-attribute=format)
	ccflags-y += $(call cc-disable-warning, unused-const-variable)
	ccflags-y += $(call cc-disable-warning, unused-but-set-variable)

(this is what we do with the upstream version, as this driver is on
bad shape)

> But there are a few things that will take more time for me to investigate:
> 
> drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_cmd.c:36:10: fatal error: linux/kct.h: No such file or directory
> include/media/v4l2-subdev.h:821:51: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’
> include/media/v4l2-subdev.h:822:15: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’
> 
> I'll keep you updated.

Maybe now with the other patches applied, this could have been solved.

Thanks,
Mauro