Re: [GIT PULL] Ressurect the atomisp staging driver

[Patrik Gfeller <patrik.gfeller@gmail.com>]

On Mon, 4 May 2020 14:08:33 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> wrote:

> Em Mon, 4 May 2020 12:45:39 +0200
> Patrik Gfeller <patrik.gfeller@gmail.com> escreveu:
> 
> > On Mon, 4 May 2020 10:49:34 +0200
> > Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
> >   
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
> > 
> > There are still errors when I try to build. I've found code like the
> > one below:
> > 
> > const struct v4l2_ioctl_ops atomisp_ioctl_ops = {
> > 	.vidioc_querycap = atomisp_querycap,
> > #ifndef CONFIG_INTEL_MID_ISP
> > 	.vidioc_g_chip_ident = atomisp_g_chip_ident,
> > #endif
> > 	.vidioc_enum_input = atomisp_enum_input,
> > 
> > Therefore I've tried with "CONFIG_INTEL_MID_ISP=y". Not sure if this is
> > a good idea function wise - but it compiles.  
> 
> Yes, that's it. You also need:
> 
> CONFIG_REGULATOR_WHISKEY_COVE=y         
> 
> and maybe some other stuff. Take a look at the Yocto's *.cfg files I pointed
> with the options (see enclosed).
> 
> 
> 
> > But the last step of the
> > module build produces some scary warnings:
> > 
> > WARNING: "cpu_tss" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "pv_lock_ops" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "__alloc_workqueue_key" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "v4l2_subdev_querymenu" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "intel_mid_msgbus_write32" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > ...
> > 
> > Maybe this is related to my partial build (only the module to test if
> > it builds). I'll now do a full build of the kernel.  
> 
> Yeah, either that or there are some config options with different values.
> 
> I was able to do a full build here without the above errors, although
> I had to turn of some CONFIG options that were otherwise failing.

Strange - I do not get it :-/ ... can you send me the .config file and
Makefile you use; probably I missed something.

> 
> 
> Thanks,
> Mauro
> 
> ~/meta-intel-aero/recipes-kernel/linux/linux-yocto $ cat *.cfg
> CONFIG_USB_ACM=y
> CONFIG_USB_WDM=y
> CONFIG_USB_USBNET=y
> CONFIG_USB_NET_CDC_MBIM=y
> CONFIG_MEDIA_PCI_SUPPORT=y
> 
> CONFIG_VIDEO_DEV=y
> CONFIG_MEDIA_SUPPORT=y
> CONFIG_VIDEO_V4L2=y
> CONFIG_INTEL_MID_ISP=y
> CONFIG_VIDEO_ATOMISP=m
> CONFIG_VIDEO_OV7251=y
> CONFIG_VIDEO_OV8858=y
> CONFIG_I2C_CHARDEV=y
> CONFIG_GPIO_SYSFS=y
> CONFIG_DYNAMIC_DEBUG=y
> CONFIG_PRINTK_TIME=y
> CONFIG_DMADEVICES=y
> CONFIG_DW_DMAC_CORE=y
> CONFIG_DW_DMAC=y
> # DRONE CODE CONFIG
> CONFIG_HAVE_INTEL_TXT=y
> CONFIG_MMU_NOTIFIER=y
> CONFIG_PCI_ATS=y
> CONFIG_PCI_PASID=y
> 
> CONFIG_VFIO_IOMMU_TYPE1=y
> CONFIG_VFIO_VIRQFD=y
> CONFIG_VFIO=y
> CONFIG_VFIO_PCI=y
> CONFIG_VFIO_PCI_MMAP=y
> CONFIG_VFIO_PCI_INTX=y
> CONFIG_IRQ_BYPASS_MANAGER=y
> 
> CONFIG_IOMMU_API=y
> CONFIG_IOMMU_IOVA=y
> CONFIG_DMAR_TABLE=y
> CONFIG_INTEL_IOMMU=y
> CONFIG_INTEL_IOMMU_SVM=y
> CONFIG_INTEL_IOMMU_DEFAULT_ON=y
> CONFIG_INTEL_IOMMU_FLOPPY_WA=y
> 
> CONFIG_X86_INTEL_LPSS=y
> CONFIG_I2C_DESIGNWARE_CORE=y
> CONFIG_I2C_DESIGNWARE_PCI=y
> CONFIG_I2C_DESIGNWARE_PLATFORM=y
> CONFIG_SERIAL_8250_DW=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_ACPI=y
> CONFIG_NF_NAT_FTP=y
> CONFIG_NF_NAT_IPV4=y
> CONFIG_NF_NAT_IRC=y
> CONFIG_NF_NAT_NEEDED=y
> CONFIG_NF_NAT_SIP=y
> CONFIG_IP_NF_NAT=y
> CONFIG_GPIOLIB=y
> CONFIG_DEBUG_PINCTRL=y
> CONFIG_PINCTRL_CHERRYVIEW=y
> 
> #GPIO Keys
> CONFIG_KEYBOARD_GPIO=y
> CONFIG_INPUT_MISC=y
> CONFIG_INPUT_SOC_BUTTON_ARRAY=y
> CONFIG_REGULATOR=y
> CONFIG_REGULATOR_DEBUG=y
> CONFIG_REGULATOR_FIXED_VOLTAGE=y
> CONFIG_REGULATOR_GPIO=y
> CONFIG_REGULATOR_WHISKEY_COVE=y
> CONFIG_INTEL_SOC_DTS_THERMAL=y
> CONFIG_SPI=y
> CONFIG_SPI_MASTER=y
> CONFIG_SPI_SPIDEV=y
> CONFIG_SPI_PXA2XX=y
> CONFIG_SPI_PXA2XX_DMA=y
> CONFIG_SPI_PXA2XX_PCI=y
> CONFIG_USB_ETH=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_PCI=y
> CONFIG_USB_DWC3_GADGET=y
> CONFIG_USB_OTG=y
> CONFIG_USB_OTG_FSM=y
> CONFIG_INTEL_CHT_PHY=y
> CONFIG_NOP_USB_XCEIV=y
> CONFIG_IIO=y
> CONFIG_INTEL_SOC_PMIC=y
> CONFIG_ITCO_WDT=y
> # CONFIG_ITCO_VENDOR_SUPPORT is not set
> CONFIG_LPC_ICH=y
> 

with kind regards,
Patrik