Re: [PATCH v2 04/34] media: bcm2835-unicam: Driver for CCP2/CSI2 camera interface

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5279 bytes --]

Hi Laurent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc4]
[cannot apply to linuxtv-media/master anholt/for-next next-20200504]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Laurent-Pinchart/Drivers-for-the-BCM283x-CSI-2-CCP2-receiver-and-ISP/20200505-054310
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9851a0dee7c28514f149f7e4f60ec1b06286cc1b
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/media/platform/bcm2835/bcm2835-unicam.c: In function 'unicam_probe_complete':
>> drivers/media/platform/bcm2835/bcm2835-unicam.c:2531:8: error: implicit declaration of function 'v4l2_device_register_ro_subdev_nodes'; did you mean 'v4l2_device_register_subdev_nodes'? [-Werror=implicit-function-declaration]
    2531 |  ret = v4l2_device_register_ro_subdev_nodes(&unicam->v4l2_dev);
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |        v4l2_device_register_subdev_nodes
   drivers/media/platform/bcm2835/bcm2835-unicam.c: In function 'get_first_supported_format':
>> drivers/media/platform/bcm2835/bcm2835-unicam.c:1014:18: warning: 'ret' is used uninitialized in this function [-Wuninitialized]
    1014 |  for (i = 0; ret != -EINVAL && ret != -ENOIOCTLCMD; ++i) {
   during RTL pass: mach
   drivers/media/platform/bcm2835/bcm2835-unicam.c: In function 'register_node':
   drivers/media/platform/bcm2835/bcm2835-unicam.c:2483:1: internal compiler error: in priority, at haifa-sched.c:1599
    2483 | }
         | ^
   0x527435 priority
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/haifa-sched.c:1599
   0xeeff2a priority
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/haifa-sched.c:1595
   0xeeff2a apply_replacement
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/haifa-sched.c:4719
   0xef0b20 undo_replacements_for_backtrack
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/haifa-sched.c:4454
   0xef0d63 restore_last_backtrack_point
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/haifa-sched.c:4551
   0xef4f5e schedule_block(basic_block_def**, void*)
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/haifa-sched.c:6952
   0xf72558 schedule_ebb(rtx_insn*, rtx_insn*, bool)
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/sched-ebb.c:537
   0xf72bd1 schedule_ebbs()
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/sched-ebb.c:656
   0xc94f9b c6x_reorg
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/config/c6x/c6x.c:5943
   0x984d9d execute
   	/tmp/build-crosstools-xh-9.3.0-2.34/gcc/gcc-9.3.0/gcc/reorg.c:3992
   Please submit a full bug report,
   with preprocessed source if appropriate.
   Please include the complete backtrace with any bug report.
   See <https://gcc.gnu.org/bugs/> for instructions.

vim +2531 drivers/media/platform/bcm2835/bcm2835-unicam.c

  2504	
  2505	static int unicam_probe_complete(struct unicam_device *unicam)
  2506	{
  2507		int ret;
  2508	
  2509		unicam->v4l2_dev.notify = unicam_notify;
  2510	
  2511		unicam->sensor_config = v4l2_subdev_alloc_pad_config(unicam->sensor);
  2512		if (!unicam->sensor_config)
  2513			return -ENOMEM;
  2514	
  2515		unicam->sensor_embedded_data = (unicam->sensor->entity.num_pads >= 2);
  2516	
  2517		ret = register_node(unicam, &unicam->node[IMAGE_PAD],
  2518				    V4L2_BUF_TYPE_VIDEO_CAPTURE, IMAGE_PAD);
  2519		if (ret) {
  2520			unicam_err(unicam, "Unable to register image video device.\n");
  2521			goto unregister;
  2522		}
  2523	
  2524		ret = register_node(unicam, &unicam->node[METADATA_PAD],
  2525				    V4L2_BUF_TYPE_META_CAPTURE, METADATA_PAD);
  2526		if (ret) {
  2527			unicam_err(unicam, "Unable to register metadata video device.\n");
  2528			goto unregister;
  2529		}
  2530	
> 2531		ret = v4l2_device_register_ro_subdev_nodes(&unicam->v4l2_dev);
  2532		if (ret) {
  2533			unicam_err(unicam, "Unable to register subdev nodes.\n");
  2534			goto unregister;
  2535		}
  2536	
  2537		/*
  2538		 * Release the initial reference, all references are now owned by the
  2539		 * video devices.
  2540		 */
  2541		unicam_put(unicam);
  2542		return 0;
  2543	
  2544	unregister:
  2545		unregister_nodes(unicam);
  2546		unicam_put(unicam);
  2547	
  2548		return ret;
  2549	}
  2550	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52564 bytes --]