From: Michal Kubecek <mkubecek@suse.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Chris Healy <cphealy@gmail.com>,
michael@walle.cc
Subject: Re: [PATCH net-next v2 08/10] net: phy: marvell: Add cable test support
Date: Tue, 5 May 2020 12:52:41 +0200 [thread overview]
Message-ID: <20200505105241.GL8237@lion.mk-sys.cz> (raw)
In-Reply-To: <20200505001821.208534-9-andrew@lunn.ch>
On Tue, May 05, 2020 at 02:18:19AM +0200, Andrew Lunn wrote:
> The Marvell PHYs have a couple of different register sets for
> performing cable tests. Page 7 provides the simplest to use.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> drivers/net/phy/marvell.c | 202 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 202 insertions(+)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 7fc8e10c5f33..72afc67f7f35 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -27,6 +27,7 @@
> #include <linux/module.h>
> #include <linux/mii.h>
> #include <linux/ethtool.h>
> +#include <linux/ethtool_netlink.h>
> #include <linux/phy.h>
> #include <linux/marvell_phy.h>
> #include <linux/bitfield.h>
> @@ -35,6 +36,7 @@
> #include <linux/io.h>
> #include <asm/irq.h>
> #include <linux/uaccess.h>
> +#include <uapi/linux/ethtool_netlink.h>
>
> #define MII_MARVELL_PHY_PAGE 22
> #define MII_MARVELL_COPPER_PAGE 0x00
This shouldn't be necessary, <linux/ethtool_netlink.h> includes the UAPI
header.
[...]
> +static int mavell_vct7_cable_test_report_trans(int result)
Typo: "mavell".
Michal
next prev parent reply other threads:[~2020-05-05 10:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 0:18 [PATCH net-next v2 00/10] Ethernet Cable test support Andrew Lunn
2020-05-05 0:18 ` [PATCH net-next v2 01/10] net: phy: Add cable test support to state machine Andrew Lunn
2020-05-05 0:18 ` [PATCH net-next v2 02/10] net: phy: Add support for polling cable test Andrew Lunn
2020-05-05 3:15 ` Florian Fainelli
2020-05-05 0:18 ` [PATCH net-next v2 03/10] net: ethtool: netlink: Add support for triggering a " Andrew Lunn
2020-05-05 3:18 ` Florian Fainelli
2020-05-05 7:15 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 04/10] net: ethtool: Add attributes for cable test reports Andrew Lunn
2020-05-05 3:19 ` Florian Fainelli
2020-05-05 8:28 ` Michal Kubecek
2020-05-05 13:15 ` Andrew Lunn
2020-05-05 13:24 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 05/10] net: ethtool: Make helpers public Andrew Lunn
2020-05-05 3:20 ` Florian Fainelli
2020-05-05 8:29 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 06/10] net: ethtool: Add infrastructure for reporting cable test results Andrew Lunn
2020-05-05 3:21 ` Florian Fainelli
2020-05-05 10:42 ` Michal Kubecek
2020-05-05 13:19 ` Andrew Lunn
2020-05-05 0:18 ` [PATCH net-next v2 07/10] net: ethtool: Add helpers for reporting " Andrew Lunn
2020-05-05 3:22 ` Florian Fainelli
2020-05-05 10:50 ` Michal Kubecek
2020-05-05 13:22 ` Andrew Lunn
2020-05-05 13:32 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 08/10] net: phy: marvell: Add cable test support Andrew Lunn
2020-05-05 3:24 ` Florian Fainelli
2020-05-05 10:11 ` Michael Walle
2020-05-05 13:32 ` Andrew Lunn
2020-05-05 10:52 ` Michal Kubecek [this message]
2020-05-05 0:18 ` [PATCH net-next v2 09/10] net: phy: Put interface into oper testing during cable test Andrew Lunn
2020-05-05 3:24 ` Florian Fainelli
2020-05-05 11:26 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 10/10] net: phy: Send notifier when starting the " Andrew Lunn
2020-05-05 3:25 ` Florian Fainelli
2020-05-05 11:32 ` Michal Kubecek
2020-05-05 13:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505105241.GL8237@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.