From: Michal Kubecek <mkubecek@suse.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Chris Healy <cphealy@gmail.com>,
michael@walle.cc
Subject: Re: [PATCH net-next v2 04/10] net: ethtool: Add attributes for cable test reports
Date: Tue, 5 May 2020 15:24:17 +0200 [thread overview]
Message-ID: <20200505132417.GI5989@lion.mk-sys.cz> (raw)
In-Reply-To: <20200505131548.GE208718@lunn.ch>
On Tue, May 05, 2020 at 03:15:48PM +0200, Andrew Lunn wrote:
> > > + +---------------------------------------------+--------+---------------------+
> > > + | ``ETHTOOL_A_CABLE_TEST_HEADER`` | nested | reply header |
> > > + +---------------------------------------------+--------+---------------------+
> > > + | ``ETHTOOL_A_CABLE_TEST_STATUS`` | u8 | completed |
> > > + +---------------------------------------------+--------+---------------------+
> > > + | ``ETHTOOL_A_CABLE_TEST_NTF_NEST`` | nested | all the results |
> > > + +-+-------------------------------------------+--------+---------------------+
> > > + | | ``ETHTOOL_A_CABLE_TEST_STATUS`` | u8 | completed |
> > > + +-+-------------------------------------------+--------+---------------------+
> >
> > You have ETHTOOL_A_CABLE_TEST_STATUS both here and on top level. AFAICS
> > the top level attribute is the right one - but the name is
> > ETHTOOL_A_CABLE_TEST_NTF_STATUS.
>
> Hi Michal
>
> They need better names. The first one is about the test run
> status. Started vs complete. A notification is sent when the test is
> started, and a second one at the end with the actual test results. The
> second status is per pair, indicating open, shorted, O.K.
> Maybe this second one shouldd be ETHTOOL_A_CABLE_TEST_NTF_PAIR_STATUS.
The per-pair status is ETHTOOL_A_CABLE_RESULTS_CODE (nested within
ETHTOOL_A_CABLE_TEST_NTF_RESULT), isn't it?
Based on the code, I would say second ETHTOOL_A_CABLE_TEST_STATUS line
should be dropped and first fixed to ETHTOOL_A_CABLE_TEST_NTF_STATUS.
Michal
next prev parent reply other threads:[~2020-05-05 13:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 0:18 [PATCH net-next v2 00/10] Ethernet Cable test support Andrew Lunn
2020-05-05 0:18 ` [PATCH net-next v2 01/10] net: phy: Add cable test support to state machine Andrew Lunn
2020-05-05 0:18 ` [PATCH net-next v2 02/10] net: phy: Add support for polling cable test Andrew Lunn
2020-05-05 3:15 ` Florian Fainelli
2020-05-05 0:18 ` [PATCH net-next v2 03/10] net: ethtool: netlink: Add support for triggering a " Andrew Lunn
2020-05-05 3:18 ` Florian Fainelli
2020-05-05 7:15 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 04/10] net: ethtool: Add attributes for cable test reports Andrew Lunn
2020-05-05 3:19 ` Florian Fainelli
2020-05-05 8:28 ` Michal Kubecek
2020-05-05 13:15 ` Andrew Lunn
2020-05-05 13:24 ` Michal Kubecek [this message]
2020-05-05 0:18 ` [PATCH net-next v2 05/10] net: ethtool: Make helpers public Andrew Lunn
2020-05-05 3:20 ` Florian Fainelli
2020-05-05 8:29 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 06/10] net: ethtool: Add infrastructure for reporting cable test results Andrew Lunn
2020-05-05 3:21 ` Florian Fainelli
2020-05-05 10:42 ` Michal Kubecek
2020-05-05 13:19 ` Andrew Lunn
2020-05-05 0:18 ` [PATCH net-next v2 07/10] net: ethtool: Add helpers for reporting " Andrew Lunn
2020-05-05 3:22 ` Florian Fainelli
2020-05-05 10:50 ` Michal Kubecek
2020-05-05 13:22 ` Andrew Lunn
2020-05-05 13:32 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 08/10] net: phy: marvell: Add cable test support Andrew Lunn
2020-05-05 3:24 ` Florian Fainelli
2020-05-05 10:11 ` Michael Walle
2020-05-05 13:32 ` Andrew Lunn
2020-05-05 10:52 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 09/10] net: phy: Put interface into oper testing during cable test Andrew Lunn
2020-05-05 3:24 ` Florian Fainelli
2020-05-05 11:26 ` Michal Kubecek
2020-05-05 0:18 ` [PATCH net-next v2 10/10] net: phy: Send notifier when starting the " Andrew Lunn
2020-05-05 3:25 ` Florian Fainelli
2020-05-05 11:32 ` Michal Kubecek
2020-05-05 13:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505132417.GI5989@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.