All of lore.kernel.org
 help / color / mirror / Atom feed
* [habanaai:dev/ogabbay/gaudi 23/23] drivers/misc/habanalabs/gaudi/gaudi.c:440:20: sparse: sparse: symbol 'gaudi_queue_type' was not declared. Should it be static?
@ 2020-05-05 16:23 kbuild test robot
  2020-05-05 16:23 ` [RFC PATCH habanaai] gaudi_queue_type[] can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-05-05 16:23 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3658 bytes --]

tree:   https://github.com/HabanaAI/linux.git dev/ogabbay/gaudi
head:   01f551e8186dbf88db2379f0476ce4aae0e3a291
commit: 01f551e8186dbf88db2379f0476ce4aae0e3a291 [23/23] add gaudi files
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-191-gc51a0382-dirty
        git checkout 01f551e8186dbf88db2379f0476ce4aae0e3a291
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/misc/habanalabs/gaudi/gaudi.c:440:20: sparse: sparse: symbol 'gaudi_queue_type' was not declared. Should it be static?
>> drivers/misc/habanalabs/gaudi/gaudi.c:4493:6: sparse: sparse: symbol 'gaudi_add_end_of_cb_packets' was not declared. Should it be static?
>> drivers/misc/habanalabs/gaudi/gaudi.c:4527:6: sparse: sparse: symbol 'gaudi_update_eq_ci' was not declared. Should it be static?
>> drivers/misc/habanalabs/gaudi/gaudi.c:675:33: sparse: sparse: cast truncates bits from constant value (7ff8000000 becomes f8000000)
>> drivers/misc/habanalabs/gaudi/gaudi.c:2061:26: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
>> drivers/misc/habanalabs/gaudi/gaudi.c:2065:25: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
>> drivers/misc/habanalabs/gaudi/gaudi.c:2069:26: sparse: sparse: cast truncates bits from constant value (7ffc494000 becomes fc494000)
>> drivers/misc/habanalabs/gaudi/gaudi.c:2073:25: sparse: sparse: cast truncates bits from constant value (7ffc492000 becomes fc492000)
>> drivers/misc/habanalabs/gaudi/gaudi.c:2105:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
   drivers/misc/habanalabs/gaudi/gaudi.c:2138:9: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
   drivers/misc/habanalabs/gaudi/gaudi.c:2212:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
   drivers/misc/habanalabs/gaudi/gaudi.c:2216:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
   drivers/misc/habanalabs/gaudi/gaudi.c:2244:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
   drivers/misc/habanalabs/gaudi/gaudi.c:2313:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
   drivers/misc/habanalabs/gaudi/gaudi.c:2317:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
   drivers/misc/habanalabs/gaudi/gaudi.c:2347:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
   drivers/misc/habanalabs/gaudi/gaudi.c:2418:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
   drivers/misc/habanalabs/gaudi/gaudi.c:2422:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
   drivers/misc/habanalabs/gaudi/gaudi.c:2452:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
>> drivers/misc/habanalabs/gaudi/gaudi.c:2955:27: sparse: sparse: cast truncates bits from constant value (7ff0000000 becomes f0000000)
   drivers/misc/habanalabs/gaudi/gaudi.c:6884:9: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH habanaai] gaudi_queue_type[] can be static
  2020-05-05 16:23 [habanaai:dev/ogabbay/gaudi 23/23] drivers/misc/habanalabs/gaudi/gaudi.c:440:20: sparse: sparse: symbol 'gaudi_queue_type' was not declared. Should it be static? kbuild test robot
@ 2020-05-05 16:23 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-05-05 16:23 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]


Fixes: 01f551e8186d ("add gaudi files")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 gaudi.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index 043bd0aeb33cd..6d0ec4e588b5d 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -437,7 +437,7 @@ gaudi_tpc_interrupts_cause[GAUDI_NUM_OF_TPC_INTR_CAUSE] = {
 	"tpc_lbw_bresp_err"
 };
 
-enum hl_queue_type gaudi_queue_type[GAUDI_QUEUE_ID_SIZE] = {
+static enum hl_queue_type gaudi_queue_type[GAUDI_QUEUE_ID_SIZE] = {
 	QUEUE_TYPE_EXT, /* GAUDI_QUEUE_ID_DMA_0_0 */
 	QUEUE_TYPE_EXT, /* GAUDI_QUEUE_ID_DMA_0_1 */
 	QUEUE_TYPE_EXT, /* GAUDI_QUEUE_ID_DMA_0_2 */
@@ -4490,7 +4490,7 @@ static int gaudi_cs_parser(struct hl_device *hdev, struct hl_cs_parser *parser)
 		return gaudi_parse_cb_no_mmu(hdev, parser);
 }
 
-void gaudi_add_end_of_cb_packets(struct hl_device *hdev, u64 kernel_address,
+static void gaudi_add_end_of_cb_packets(struct hl_device *hdev, u64 kernel_address,
 				u32 len, u64 cq_addr, u32 cq_val, u32 msi_vec,
 				bool eb)
 {
@@ -4524,7 +4524,7 @@ void gaudi_add_end_of_cb_packets(struct hl_device *hdev, u64 kernel_address,
 	cq_pkt->addr = cpu_to_le64(CFG_BASE + mmPCIE_MSI_INTR_0 + msi_vec * 4);
 }
 
-void gaudi_update_eq_ci(struct hl_device *hdev, u32 val)
+static void gaudi_update_eq_ci(struct hl_device *hdev, u32 val)
 {
 	WREG32(mmCPU_IF_EQ_RD_OFFS, val);
 }

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-05 16:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-05 16:23 [habanaai:dev/ogabbay/gaudi 23/23] drivers/misc/habanalabs/gaudi/gaudi.c:440:20: sparse: sparse: symbol 'gaudi_queue_type' was not declared. Should it be static? kbuild test robot
2020-05-05 16:23 ` [RFC PATCH habanaai] gaudi_queue_type[] can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.