From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] pty04: Fix build for kernel headers < v4.2-rc1
Date: Wed, 6 May 2020 16:14:12 +0200 [thread overview]
Message-ID: <20200506141412.GA26506@dell5510> (raw)
In-Reply-To: <1588328084.11511511.1588773609302.JavaMail.zimbra@redhat.com>
> ----- Original Message -----
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > https://travis-ci.org/github/pevik/ltp/builds/683787204
> > configure.ac | 1 +
> > include/lapi/tty.h | 17 +++++++++++++++++
> > testcases/kernel/pty/pty04.c | 17 ++++++++++-------
> > 3 files changed, 28 insertions(+), 7 deletions(-)
> > create mode 100644 include/lapi/tty.h
> Works for me (rhel6/7), thanks Petr.
OK, I'll merge with your ack and Cyril's and Richard's suggestion.
I want to fix minimal version as well. Works well on our 3.0 kernel.
Other kernel has a problem 2.6.32-696.el6.x86_64, but IMHO that does not mean
that the test is not valid for this kernel.
./pty04
tst_test.c:1246: INFO: Timeout per run is 0h 05m 00s
pty04.c:95: INFO: PTS path is /dev/pts/1
pty04.c:149: INFO: Netdev is sl0
pty04.c:158: INFO: Netdev MTU is 8192 (we set 8192)
pty04.c:175: INFO: Bound netdev 5 to socket 5
pty04.c:208: INFO: Reading from socket 5
pty04.c:123: PASS: Wrote PTY 1
pty04.c:133: PASS: Wrote PTY 2
pty04.c:213: PASS: Read netdev 1
pty04.c:217: PASS: Read netdev 2
pty04.c:249: BROK: ioctl(4,TIOCVHANGUP,...) failed: EINVAL (22)
tst_test.c:373: BROK: Reported by child (12112)
Can please anybody double check, that with this patch it should be possible to
run this test even on v2.6.25 (which added can module)?
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-06 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 13:48 [LTP] [PATCH 1/1] pty04: Fix build for kernel headers < v4.2-rc1 Petr Vorel
2020-05-06 13:55 ` Cyril Hrubis
2020-05-06 14:00 ` Jan Stancek
2020-05-06 14:14 ` Petr Vorel [this message]
2020-05-06 14:45 ` Petr Vorel
2020-05-06 15:47 ` Petr Vorel
2020-05-06 15:56 ` Cyril Hrubis
2020-05-06 16:01 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506141412.GA26506@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.